From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 06/14] eal: arm: ret_vector.h improvements
Date: Wed, 18 Nov 2015 19:56:25 +0100 [thread overview]
Message-ID: <1827952.FiSe5LrlIQ@xps13> (raw)
In-Reply-To: <1446802833-22265-7-git-send-email-jerin.jacob@caviumnetworks.com>
2015-11-06 15:10, Jerin Jacob:
> added the definition of rte_xmm and xmm_t for acl noen implementation.
> removed the emulated _mm_* functions
2 nits:
- noen -> neon
- this kind of change deserves more explanations
> +#include "arm_neon.h"
I think it should be <arm_neon.h>
It won't block the merge of this patch,
but as you are becoming the ARMv8 maintainer, please try to check
even minor things which make read of DPDK code and history easier.
next prev parent reply other threads:[~2015-11-18 18:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 9:40 [dpdk-dev] [PATCH v3 00/14] DPDK armv8-a support Jerin Jacob
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 01/14] eal: arm64: add armv8-a version of rte_atomic_64.h Jerin Jacob
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 02/14] eal: arm64: add armv8-a version of rte_cpuflags_64.h Jerin Jacob
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 03/14] eal: arm64: add armv8-a version of rte_prefetch_64.h Jerin Jacob
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 04/14] eal: arm64: add armv8-a version of rte_cycles_64.h Jerin Jacob
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 05/14] eal: arm64: rte_memcpy_64.h version based on libc memcpy Jerin Jacob
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 06/14] eal: arm: ret_vector.h improvements Jerin Jacob
2015-11-18 18:56 ` Thomas Monjalon [this message]
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 07/14] app: test_cpuflags: test the new cpu flags added for arm64 Jerin Jacob
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 08/14] acl: arm64: acl implementation using NEON gcc intrinsic Jerin Jacob
2015-11-06 9:52 ` Ananyev, Konstantin
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 09/14] mk: add support for armv8 on top of armv7 Jerin Jacob
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 10/14] mk: add support for thunderx machine target based on armv8-a Jerin Jacob
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 11/14] updated release note for armv8 support for DPDK 2.2 Jerin Jacob
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 12/14] maintainers: claim responsibility for ARMv8 Jerin Jacob
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 13/14] eal: introduce rte_smp_*mb() for memory barriers to use between lcores Jerin Jacob
2015-11-06 9:40 ` [dpdk-dev] [PATCH v3 14/14] eal: arm: define rte_smp_mb(), rte_smp_wmb(), rte_smp_rmb() for arm Jerin Jacob
2015-11-18 21:48 ` [dpdk-dev] [PATCH v3 00/14] DPDK armv8-a support Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1827952.FiSe5LrlIQ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).