From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>,
christian.ehrhardt@canonical.com
Cc: dev@dpdk.org, dodji@redhat.com, Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>,
kevin.laatz@intel.com
Subject: Re: [dpdk-dev] [PATCH] ci: build and use libabigail 1.6
Date: Mon, 17 Feb 2020 16:15:36 +0100 [thread overview]
Message-ID: <1829806.xz2uEaWSZ7@xps> (raw)
In-Reply-To: <20200217135929.30987-1-david.marchand@redhat.com>
17/02/2020 14:59, David Marchand:
> libabigail 1.2 (at least) reports changes in 'const' property as an ABI
> breakage [1].
> This was fixed upstream in libabigail 1.4 [2], and a bug has been opened
> in launchpad [3].
>
> But for now, build and use the last version 1.6 so that the ABI checks
> can be kept.
>
> 1: https://travis-ci.com/DPDK/dpdk/jobs/287872118#L2242
> 2: https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commitdiff;h=215b7eb4fe8b986fe1cc87d9d8e7412998038392
> 3: https://bugs.launchpad.net/ubuntu/+source/libabigail/+bug/1863607
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> + LIBABIGAIL_REPO=${LIBABIGAIL_REPO:-https://sourceware.org/git/libabigail.git}
> + LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6}
> +
> + if [ "$(cat libabigail/VERSION 2>/dev/null)" != "$LIBABIGAIL_VERSION" ]; then
> + rm -rf libabigail
> + # if we change libabigail, invalidate existing abi cache
> + rm -rf reference
> + fi
> +
> + if [ ! -d libabigail ]; then
> + git clone --single-branch -b $LIBABIGAIL_VERSION $LIBABIGAIL_REPO libabigail/src
> + cd libabigail/src && autoconf -vfi && cd -
> + mkdir libabigail/src/build
> + cd libabigail/src/build && ../configure --prefix=$(pwd)/libabigail && cd -
> + make -C libabigail/src/build all install
> +
> + rm -rf libabigail/src
> + echo $LIBABIGAIL_VERSION > libabigail/VERSION
> + fi
Can we avoid compiling libabigail ourself?
Is there an up-to-date Ubuntu package somewhere?
next prev parent reply other threads:[~2020-02-17 15:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 13:59 David Marchand
2020-02-17 15:15 ` Thomas Monjalon [this message]
2020-02-17 18:47 ` Aaron Conole
2020-02-18 9:40 ` David Marchand
2020-02-18 11:18 ` David Marchand
2020-02-18 14:55 ` Aaron Conole
2020-02-18 15:07 ` David Marchand
2020-02-18 14:29 ` [dpdk-dev] [PATCH v2] " David Marchand
2020-02-18 15:46 ` Thomas Monjalon
2020-02-18 16:38 ` David Marchand
2020-02-19 8:13 ` Dodji Seketeli
2020-02-18 20:13 ` [dpdk-dev] [PATCH v3] " David Marchand
2020-02-18 20:31 ` Aaron Conole
2020-02-18 20:59 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1829806.xz2uEaWSZ7@xps \
--to=thomas@monjalon.net \
--cc=aconole@redhat.com \
--cc=christian.ehrhardt@canonical.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dodji@redhat.com \
--cc=kevin.laatz@intel.com \
--cc=maicolgabriel@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).