From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 75657316B for ; Mon, 28 Jan 2019 01:39:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0075020964; Sun, 27 Jan 2019 19:39:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 27 Jan 2019 19:39:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Z+GVGx1BURcf2l41g0VRXRivv7Zm+OTdq3ZTPZ/+VuU=; b=VTxAVfi0hoUU wDkcxwFVkWiVESALXmiSghcJCbJfzG0bzKY/U62nvQgcmQsoqYaHdYDrZUfLDXZo QHsjwne1PY9L/Q435R0lleHAB+TOTwJApPQJd7YBzLXSII6gQ6eCJN780DWWfuj/ wCY+D9Bff+BCKtk4DcI6hRbuT81h/V8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Z+GVGx1BURcf2l41g0VRXRivv7Zm+OTdq3ZTPZ/+V uU=; b=fxJwt3GxI92lvCHqJB8XPyoGgxdmCb/Rc+ytkBABcy1cN0WlL6QYqYm0m JwFnVPhXDLMQexnislogA18ppPlj0H4WELkqmN9dtwN1poh6vQBVV/5+hCwerLfo y1Wig6MdDtLCYK2jTfjm06UTg0mycb7Feg9P7mMAekcFDfyoVqxXQN1etoL/BCZt CLDA+4ylBtdmXCGq1dzsudE3siJ1sUuRXjTUzS8JFOgilvoCrOLL7h6XV4OHckUy /ionfcSGMHOvTKTV0MfwZRo5sqsfqid0UnLA6nY33y+F4GKmYxzwfu3wVCuIjDMU mjtik62oyJCBL8q++UMPMur68G0XA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrieelgddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 664DA10281; Sun, 27 Jan 2019 19:39:13 -0500 (EST) From: Thomas Monjalon To: Vipin Varghese Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com, ferruh.yigit@intel.com, sanjay.padubidri@intel.com, amol.patel@intel.com Date: Mon, 28 Jan 2019 01:39:12 +0100 Message-ID: <1830265.56Hsnbp04L@xps> In-Reply-To: <20190124230541.58343-1-vipin.varghese@intel.com> References: <20181030141847.23861-1-vipin.varghese@intel.com> <20190124230541.58343-1-vipin.varghese@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] doc/patches: add meson build to contributing guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2019 00:39:15 -0000 25/01/2019 00:05, Vipin Varghese: > Patches has to be validated for meson devtool script for > code and document changes. Updating documentation for meson > build steps in checking Compilation category. > > Signed-off-by: Vipin Varghese > Tested-by: Marko Kovacevic > Acked-by: Marko Kovacevic > --- > > V4: > - spelling correction for Compilation - Thomas Monjalon > - restored double space for new header - Thomas Monjalon > - reword the meson compilation content - Vipin Varghese > - Added 'tested' and 'acked' from - Marko Kovacevic > > V3: > removed extra character - Vipin Varghese > > V2: > updated the meson build options - Bruce Richardson > --- > doc/guides/contributing/patches.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst > index a64bb0368..e9048bbc0 100644 > --- a/doc/guides/contributing/patches.rst > +++ b/doc/guides/contributing/patches.rst > @@ -473,6 +473,14 @@ The recommended configurations and options to test compilation prior to submitti > export DPDK_DEP_PCAP=y > export DPDK_DEP_SSL=y The lines above are about the "make system". We need a transition to explain that the "meson system" is different. > +Compilation of patches is to be tested with ``test-meson-builds.sh`` script > +in ``devtools`` directory of the DPDK repo:: Would be more straight-forward to give the full path: devtools/test-meson-builds.sh No need to add "DPDK repo". > + > + devtools/test-meson-builds.sh Do we really need to repeat the script name here? > + > +The script internally checks for dependencies and tool chain. Then builds with tool chain -> toolchain > +shared and static libraries for Linux and BSD targets. Why "Linux and BSD" ? It is just testing for the running OS.