From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E96365F24 for ; Fri, 26 Oct 2018 01:58:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 87F2221E0B; Thu, 25 Oct 2018 19:58:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 19:58:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=f80MQx9d4iFoMyLJnYel9zs4eayeECvK/U+RqBaX5dE=; b=NhfAdr/uMIu7 OajCXY1vkh3GCjJCIG/lRe9t4k4KMMX4/HLem3b553vqCJIdjCd2dobqQJ7aN6V4 lSO+i0q6Ia5FNaHJzuG1bWKVd8H4YB7xptHyu4jcgAc4vO8voEL/JZRhcgOegYNM SIQ4L8prk4KYnT1XOww2aoPCSLVWw2g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=f80MQx9d4iFoMyLJnYel9zs4eayeECvK/U+RqBaX5 dE=; b=wprRUMhtqrljre0u/Xh3XsAzidgXE7I5XZWTe+F3bE4mrro9UNUqlcm1Y TCWVEkW1xvH8L5XR51Atk5R4uNkmanreduTbhYxl6d+1Bw5WQpuUau7htcW8xcmB TvdHZytTrEf7Q5WLowQ5Mq5dHYmnO+CSEyJaZTwiO+ayNgQNX4QLJKcLggBuBqqU RCqygka/8+/sOFEsT6dju4znYpJu2QPFS3PiSIKvur1fJRlaCp69bFFuYHEBn7x5 Amxbrl2hh54zhvY27ZGBt4cb0eNU1SDBuMu2AgrV1XKhgFYj6weF61ngV0N4HCAN OSuMnz+WvW6X8rVjhO2cQd40sKvTg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B9810102EA; Thu, 25 Oct 2018 19:58:01 -0400 (EDT) From: Thomas Monjalon To: "Richardson, Bruce" , "Laatz, Kevin" Cc: dev@dpdk.org, "Van Haaren, Harry" , "stephen@networkplumber.org" , "gaetan.rivet@6wind.com" , "shreyansh.jain@nxp.com" , "mattias.ronnblom@ericsson.com" , Ciara Power , Brian Archbold Date: Fri, 26 Oct 2018 01:58:05 +0200 Message-ID: <1831985.fi8zdvLe0H@xps> In-Reply-To: <59AF69C657FD0841A61C55336867B5B0726BFB95@IRSMSX103.ger.corp.intel.com> References: <20181024132725.5142-1-kevin.laatz@intel.com> <1823463.pdHNGopkkG@xps> <59AF69C657FD0841A61C55336867B5B0726BFB95@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 23:58:04 -0000 25/10/2018 23:16, Richardson, Bruce: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 25/10/2018 22:44, Bruce Richardson: > > > On Thu, Oct 25, 2018 at 10:41:53PM +0200, Thomas Monjalon wrote: > > > > 25/10/2018 22:29, Thomas Monjalon: > > > > > 24/10/2018 18:03, Kevin Laatz: > > > > > > --- a/lib/librte_telemetry/meson.build > > > > > > +++ b/lib/librte_telemetry/meson.build > > > > > > @@ -5,3 +5,5 @@ sources = files('rte_telemetry.c') headers = > > > > > > files('rte_telemetry.h', 'rte_telemetry_internal.h') deps += > > > > > > ['metrics', 'ethdev'] cflags += '-DALLOW_EXPERIMENTAL_API' > > > > > > +jansson = cc.find_library('jansson', required: true) ext_deps > > > > > > ++= jansson > > > > > > > > > > I just discovered an issue when trying to compile for arm64 (with > > > > > devtools/test-meson-builds.sh): > > > > > > > > > > /usr/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../aarch64-linux- > > gnu/bin/ld: > > > > > cannot find -ljansson > > > > > > > > > > I am worried because it is a real blocker. > > > > > > > > The dependency must be optional. > > > > Should we disable the library if jansson is not found? > > > > > > > Yes, it should be. > > > > > > Needs: > > > > > > jansson = cc.find_library('jansson', required: false) > > > build = jansson.found() > > > > And for the makefile? > > > > It has been introduced (too early) in patch 3: > > LDLIBS += -ljansson > > I think we must use pkg-config to check if jansson is found. > > I didn't look at the makefile, because you never asked! :-) The code is already written in examples/power: https://patches.dpdk.org/patch/46984/