From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18BEEA0540; Thu, 7 Jul 2022 13:19:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B309040A7B; Thu, 7 Jul 2022 13:19:24 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 5BACB406B4 for ; Thu, 7 Jul 2022 13:19:23 +0200 (CEST) Received: from [192.168.1.38] (unknown [188.170.75.69]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 72DD6C7; Thu, 7 Jul 2022 14:19:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 72DD6C7 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1657192762; bh=qKYqjsAE+nJ4EemGLb1dOvv5SuPlNa6fD8y9krcf+h0=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=BcZUHoESqhPJp+/XDQ/Z/120Zx8m9Ee/V7uuvp56++sg3Np+Rjabguy7SZQJl2RiS Du9ChSWuwWh+AfnSQYyuDJOnwG4QW5PsDYIhZ2x/Pc/BVHJU05Z5NCABkwhpXDeajw wvBJ1+yTYU+6LFYTV/8l4UicDahdrLMMi1rsD850= Message-ID: <183199df-9c7f-b4c1-fef2-355a46768223@oktetlabs.ru> Date: Thu, 7 Jul 2022 14:19:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] net/af_xdp: limit libbpf version to <= v0.7.0 Content-Language: en-US From: Andrew Rybchenko To: Thomas Monjalon , "Loftus, Ciara" Cc: "dev@dpdk.org" , "ferruh.yigit@xilinx.com" References: <20220624060634.295136-1-ciara.loftus@intel.com> <9193135.JRmrKFJ9eK@thomas> <3237285.2IRrRt1zHL@thomas> <34eee5ae-69a5-b39a-9187-8ab536fd5e88@oktetlabs.ru> In-Reply-To: <34eee5ae-69a5-b39a-9187-8ab536fd5e88@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/24/22 14:48, Andrew Rybchenko wrote: > On 6/24/22 13:10, Thomas Monjalon wrote: >> 24/06/2022 10:37, Loftus, Ciara: >>>> >>>> 24/06/2022 08:06, Ciara Loftus: >>>>> Linking with libbpf v0.8.0 causes deprication warnings. As a temporary >>>>> measure, prevent linking with libbpf versions v0.8.0 and greater. This >>>>> limitation should be removed in the future when appropriate >>>>> compatibility measures are introduced. >>>>> >>>>> Signed-off-by: Ciara Loftus >>>>> --- >>>>> -bpf_dep = dependency('libbpf', required: false, method: 'pkg-config') >>>>> -if not bpf_dep.found() >>>>> -    bpf_dep = cc.find_library('bpf', required: false) >>>>> -endif >>>>> +bpf_dep = dependency('libbpf', version : '<=0.7.0', required: false, >>>> method: 'pkg-config') >>>> >>>> It is also removing the find_library() method. >>>> Any reason it was there? >>>> >>> >>> My understanding is that one can't check the library version using >>> that method. >>> So it was a valid method of picking up the library until now where we >>> always need to check the version before linking. >> >> OK I see > > IMHO checking library version is a bad approach. We should file > the library of whatever version and check for symbols etc in it > and provide corresponding HAVE_ defines to handle it in code. I'm marking the patch as discarded since it is a step in a wrong direction.