From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 5874A8E7D for ; Sun, 1 Nov 2015 23:20:29 +0100 (CET) Received: by wmll128 with SMTP id l128so47014524wml.0 for ; Sun, 01 Nov 2015 14:20:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=mPyanc6RRnsQmPCq8UGiwAr/KYHEK+dZ3NdzGUlgsSU=; b=m6jtiupd0WLGJ17WJutB9upOcBUpSr+2BV/fyxZ4iZVNVOr5MpaF5hXGq1qWhjewnp bgcq2k912X92YbjUswRtql6eM+WSChxHrO5At6aG9L8IaEoVqK/ZVM0VhE2Pc+zruxMn +afD3Re3Wxh+lihglR5lQvhAycd1d4PMAlpIpg/F0ZTaUX7Ofj6e/cQbLFccTRaf84LZ J1lKRTwNOnM0+o8m9Daj/O+wmV5QG3FradkUCmarBmcNYlPfWxlD5OS6dgFC2Z2xdMNB TuxQwh1j0aKKAoZKyfvVA8YYq0cSA1mfEWbFMc8FoeludVghLc5vTfG/QHUUy5MO5MuF 06wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=mPyanc6RRnsQmPCq8UGiwAr/KYHEK+dZ3NdzGUlgsSU=; b=R2rMTYVVQX2DbBGUe0eBoWUuiKbNe4fCmhMnjzvflL3hVEUTigGXQwjbbAJo6+3FPi qHqbCLO6TAdsz+Wv3JdCG+SeWSN/xx/mBWZIFkIjB4Zzg7NjPPmMM3ENrH4gbDHYNjjD Uu/iPt+EchYmmRjrJCIJK4rj2VDInvzBy+9Fe+2mX9qN5p2p94AIIAQs5c6o6IxU2k/6 8Kb4wOe1bu+aCWLOr2V/P0VQ7BCLgwqaCKHxe7408X4OOt+PGxl5SH5O1l5DCtFEyq6o feZO2GrhOXHF3TYi6oOwzCV6dzdq/RRX9MxZVIVPgMP8ESMSaPOAIbw7eKz9VGAXgNwQ L4eA== X-Gm-Message-State: ALoCoQmbTNON1lyoJnJhBJiOAvbQfTSTgOV+SR/3m8WyAE3rmmJ48IV6uS7p1byjUmC1YicKtg8G X-Received: by 10.28.12.140 with SMTP id 134mr10454439wmm.9.1446416429209; Sun, 01 Nov 2015 14:20:29 -0800 (PST) Received: from xps13.localnet (123.26.90.92.rev.sfr.net. [92.90.26.123]) by smtp.gmail.com with ESMTPSA id ka10sm18948765wjc.30.2015.11.01.14.20.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Nov 2015 14:20:28 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Date: Sun, 01 Nov 2015 23:11:07 +0100 Message-ID: <18320386.mavPrt1dXu@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1445810400-8978-2-git-send-email-marcdevel@gmail.com> References: <1443993003-1059-1-git-send-email-marcdevel@gmail.com> <1445810400-8978-1-git-send-email-marcdevel@gmail.com> <1445810400-8978-2-git-send-email-marcdevel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 1/5] ethdev: Added ETH_SPEED_CAP bitmap for ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2015 22:20:29 -0000 2015-10-25 22:59, Marc Sune: > +#define ETH_SPEED_CAP_NOT_PHY (0) /*< No phy media > */ > +#define ETH_SPEED_CAP_10M_HD (1 << 0) /*< 10 Mbps half-duplex> */ > +#define ETH_SPEED_CAP_10M_FD (1 << 1) /*< 10 Mbps full-duplex> */ > +#define ETH_SPEED_CAP_100M_HD (1 << 2) /*< 100 Mbps half-duplex> */ > +#define ETH_SPEED_CAP_100M_FD (1 << 3) /*< 100 Mbps full-duplex> */ > +#define ETH_SPEED_CAP_1G (1 << 4) /*< 1 Gbps > */ > +#define ETH_SPEED_CAP_2_5G (1 << 5) /*< 2.5 Gbps > */ > +#define ETH_SPEED_CAP_5G (1 << 6) /*< 5 Gbps > */ > +#define ETH_SPEED_CAP_10G (1 << 7) /*< 10 Mbps > */ > +#define ETH_SPEED_CAP_20G (1 << 8) /*< 20 Gbps > */ > +#define ETH_SPEED_CAP_25G (1 << 9) /*< 25 Gbps > */ > +#define ETH_SPEED_CAP_40G (1 << 10) /*< 40 Gbps > */ > +#define ETH_SPEED_CAP_50G (1 << 11) /*< 50 Gbps > */ > +#define ETH_SPEED_CAP_56G (1 << 12) /*< 56 Gbps > */ > +#define ETH_SPEED_CAP_100G (1 << 13) /*< 100 Gbps > */ In the patch 3, you rename this flags. It would be easier to understand if the right names were used in the first patch. > @@ -837,6 +860,7 @@ struct rte_eth_dev_info { > uint16_t vmdq_queue_base; /**< First queue ID for VMDQ pools. */ > uint16_t vmdq_queue_num; /**< Queue number for VMDQ pools. */ > uint16_t vmdq_pool_base; /**< First ID of VMDQ pools. */ > + uint32_t speed_capa; /**< Supported speeds bitmap (ETH_SPEED_CAP_). */ When renaming ETH_SPEED_CAP, this line is not changed later.