From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id D2148CBD0 for ; Thu, 16 Jun 2016 17:36:47 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id k184so32872453wme.1 for ; Thu, 16 Jun 2016 08:36:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=lmS/lBbuQKAjqeGWatjLpec/LCqHIEGWkS6z4/x1aDk=; b=J6r/5fsqqzKFl9ZTDqs51X1nD4+g6arb5uJOPNfGUV7OeCvDuZMIlj8+f+4ujFG7t8 PRkLrHQI7oERa1XWuWedCDcHzJ35ROJtsiTAOSrfHHfsJWE0w1tj93OvDfK/ZXxVvugA y/ObFm9VBVO24oT99OdMIwMcNN3A28XfX/f6aUBz7B7mG1Zbg5cIpBvx8bmBEmzzWLVv caeadCYRP6R1l9eYVWf9yIVGSURsKP+vrMOYagP8mLsWVn2Hb6WuDr5YkRTZifNrzwRk md8SwZGPVlyIlS5rTUfSVilWhgvOAtYnJn9SvPsDYpClmpZcAWilD4Hm/lnDiDoacnAT bicA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=lmS/lBbuQKAjqeGWatjLpec/LCqHIEGWkS6z4/x1aDk=; b=SR0t5gcV266Y3C0iEAccCfmQGZkoKS16ICyq4Xnma+aJWsOneI/qHzNJ/IUG1xL9zR /S+RU1VE8dBca+d6t7a4gocOAsSCxlLen7yEyNXB6y4mmRuw5eIdK/iTwwqhGvWrtWjd BhARqSccTNcKsZxuR2zA6C5CDbmtdVa1F2cJ/fAt3kGRMqa++hCD0vQKRanztLMywMdT YYTntXK/7JvB8ffSCW9SoT1JKdmSoMX3sAd+vvc2w0Tg8s3Oz9BI8MjtQjedKJDHqyRZ Gojg0wwhtTx5KSH2xCLY0362rEnDA7VKS8CuDimwyxt0+REih6XimyBRc6aWJnLqpf4T 0nVg== X-Gm-Message-State: ALyK8tKXjVxd7fHYMUUNujkhETZsANdhpqpCbsqWJE+4S1HUgPQlLxNSGpp2V5oos35UurC8 X-Received: by 10.28.88.206 with SMTP id m197mr5419756wmb.43.1466091406703; Thu, 16 Jun 2016 08:36:46 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id hq2sm44220289wjb.36.2016.06.16.08.36.45 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 16 Jun 2016 08:36:45 -0700 (PDT) From: Thomas Monjalon To: Wenzhuo Lu Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, jing.d.chen@intel.com, cunming.liang@intel.com, jingjing.wu@intel.com, helin.zhang@intel.com Date: Thu, 16 Jun 2016 17:36:44 +0200 Message-ID: <183283063.SXjPEFlxzi@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1465959814-16557-2-git-send-email-wenzhuo.lu@intel.com> References: <1465191653-28408-1-git-send-email-wenzhuo.lu@intel.com> <1465959814-16557-1-git-send-email-wenzhuo.lu@intel.com> <1465959814-16557-2-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/4] lib/librte_ether: support device reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2016 15:36:48 -0000 2016-06-15 11:03, Wenzhuo Lu: > +/** > + * Reset an Ethernet device. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + */ > +int > +rte_eth_dev_reset(uint8_t port_id); Please explain in the doxygen comment what means a reset. We must understand why and when an application should call it. And it must be clear for a PMD developper how to implement it. What is the return value?