From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3EDF95F51; Wed, 10 Apr 2019 23:14:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C85CA214DF; Wed, 10 Apr 2019 17:14:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 10 Apr 2019 17:14:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=AR+O5urK92Ua+ILay7d2miu7UJBx1aJheWOzm//Wu6s=; b=A/e6hHI63HS1 jtbx1en4Tv8XbAKG8eHBjhbqrLh5Nc6weN/MANeAIehfF3sg7kxK6XBqj/5CyRxE 0X73HVgnW/ZuQAPv9fKmuaqLPM1ooklLA452uyB1GO2YMQ8JOtN3PcA8r4hFCvCi z+dJQSBN3ZCOH9MU2ieqm/YQSZ3lHBA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=AR+O5urK92Ua+ILay7d2miu7UJBx1aJheWOzm//Wu 6s=; b=XlSt8gwoIR1NEM/WaF0e0zg/GNdCm0dyT3IIDtX6CpvNcVdmLxGPo4aCJ b+KKIKRsgW1OfEO745QMBh9eXHr+gcIBOtNVLbHeSDN3zrgc6Jy01h9YJilzL2vr TMY4dbT2gbn9qpMfohaMQxUrYUQJDycTqqAHXVpKtyPgl0l5uzqFwK3v+u+duPuz ZJx/MF8vsRh119bKGmfxa78mgXZ/pDHC3FdjoOW3GyjR0aE9L8/32PT64/FSswPD q4WE00JhMpP0f5NQg2wgROhGforsnDX4ZKLhAMhOwDseYkkktmeTmf4omskKj0XT woL9tRLbhCmuyQSeGhLAB9qGcvuOg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudejgdduiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A60B7E408B; Wed, 10 Apr 2019 17:14:20 -0400 (EDT) From: Thomas Monjalon To: David Christensen Cc: ferruh.yigit@intel.com, arybchenko@solarflare.com, dev@dpdk.org, radhika.chirra@ibm.com, stable@dpdk.org, Vivian Kong Date: Wed, 10 Apr 2019 23:14:19 +0200 Message-ID: <1832941.R5tAQzo2FV@xps> In-Reply-To: References: <1554927376-93022-1-git-send-email-drc@linux.vnet.ibm.com> <1741590.oPye4Mstr3@xps> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] ethdev: missing typecast from void in eth_dev_pci_specific_init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 21:14:24 -0000 10/04/2019 22:58, David Christensen: > > This is a duplicate of this patch: > >=20 > > https://patches.dpdk.org/patch/52505/ > >=20 > > You are from 2 different Linux teams at IBM, > > you hit the same issue at the same time, > > you both miss to give an explanation, > > funny. >=20 > We both work for infrastructure teams who are supporting a project team=20 > that is developing a DPDK application that runs across multiple CPU=20 > architectures and encountered the error. >=20 > The error comes from g++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0: >=20 > [CXX] g++ -o utils/pcap_handle.o -c utils/pcap_handle.cc -g3=20 > -ggdb3 -mcpu=3Dnative -mtune=3Dnative -isystem=20 > /home/rchirra/gen/io/ppc64include -std=3Dgnu++11 -flax-vector-conversions= =20 > -Werror -isystem /home/rchirra/gen/io >=20 > In file included from drivers/pmd.cc:7:0: > /home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h: > In function =E2=80=98int eth_dev_pci_specific_init(rte_eth_dev*, void*)= =E2=80=99: > /home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h:75:35:=20 > error: invalid conversion from =E2=80=98void*=E2=80=99 to =E2=80=98rte_pc= i_device*=E2=80=99 [-fpermissive] > struct rte_pci_device *pci_dev =3D bus_device; > ^~~~~~~~~~ > make[1]: *** [drivers/pmd.o] Error 1 >=20 > Do you believe that more permissive compiler flags are the better answer? No, we should not force any compiler flag of the application. We are even trying to support pedantic flags in the app. So it seems we must fix it. We just need to change the title to mention it fixes the build for C++, and add the error message in the body. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AAA81A0096 for ; Wed, 10 Apr 2019 23:14:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B24431B11C; Wed, 10 Apr 2019 23:14:25 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3EDF95F51; Wed, 10 Apr 2019 23:14:24 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C85CA214DF; Wed, 10 Apr 2019 17:14:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 10 Apr 2019 17:14:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=AR+O5urK92Ua+ILay7d2miu7UJBx1aJheWOzm//Wu6s=; b=A/e6hHI63HS1 jtbx1en4Tv8XbAKG8eHBjhbqrLh5Nc6weN/MANeAIehfF3sg7kxK6XBqj/5CyRxE 0X73HVgnW/ZuQAPv9fKmuaqLPM1ooklLA452uyB1GO2YMQ8JOtN3PcA8r4hFCvCi z+dJQSBN3ZCOH9MU2ieqm/YQSZ3lHBA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=AR+O5urK92Ua+ILay7d2miu7UJBx1aJheWOzm//Wu 6s=; b=XlSt8gwoIR1NEM/WaF0e0zg/GNdCm0dyT3IIDtX6CpvNcVdmLxGPo4aCJ b+KKIKRsgW1OfEO745QMBh9eXHr+gcIBOtNVLbHeSDN3zrgc6Jy01h9YJilzL2vr TMY4dbT2gbn9qpMfohaMQxUrYUQJDycTqqAHXVpKtyPgl0l5uzqFwK3v+u+duPuz ZJx/MF8vsRh119bKGmfxa78mgXZ/pDHC3FdjoOW3GyjR0aE9L8/32PT64/FSswPD q4WE00JhMpP0f5NQg2wgROhGforsnDX4ZKLhAMhOwDseYkkktmeTmf4omskKj0XT woL9tRLbhCmuyQSeGhLAB9qGcvuOg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudejgdduiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A60B7E408B; Wed, 10 Apr 2019 17:14:20 -0400 (EDT) From: Thomas Monjalon To: David Christensen Cc: ferruh.yigit@intel.com, arybchenko@solarflare.com, dev@dpdk.org, radhika.chirra@ibm.com, stable@dpdk.org, Vivian Kong Date: Wed, 10 Apr 2019 23:14:19 +0200 Message-ID: <1832941.R5tAQzo2FV@xps> In-Reply-To: References: <1554927376-93022-1-git-send-email-drc@linux.vnet.ibm.com> <1741590.oPye4Mstr3@xps> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] ethdev: missing typecast from void in eth_dev_pci_specific_init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410211419.FB92WLqTQzIpPBv_cbYk7K8ohayO-iKUAGapaQJcMAg@z> 10/04/2019 22:58, David Christensen: > > This is a duplicate of this patch: > >=20 > > https://patches.dpdk.org/patch/52505/ > >=20 > > You are from 2 different Linux teams at IBM, > > you hit the same issue at the same time, > > you both miss to give an explanation, > > funny. >=20 > We both work for infrastructure teams who are supporting a project team=20 > that is developing a DPDK application that runs across multiple CPU=20 > architectures and encountered the error. >=20 > The error comes from g++ (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0: >=20 > [CXX] g++ -o utils/pcap_handle.o -c utils/pcap_handle.cc -g3=20 > -ggdb3 -mcpu=3Dnative -mtune=3Dnative -isystem=20 > /home/rchirra/gen/io/ppc64include -std=3Dgnu++11 -flax-vector-conversions= =20 > -Werror -isystem /home/rchirra/gen/io >=20 > In file included from drivers/pmd.cc:7:0: > /home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h: > In function =E2=80=98int eth_dev_pci_specific_init(rte_eth_dev*, void*)= =E2=80=99: > /home/rchirra/gen/io/deps/dpdk/build/include/rte_ethdev_pci.h:75:35:=20 > error: invalid conversion from =E2=80=98void*=E2=80=99 to =E2=80=98rte_pc= i_device*=E2=80=99 [-fpermissive] > struct rte_pci_device *pci_dev =3D bus_device; > ^~~~~~~~~~ > make[1]: *** [drivers/pmd.o] Error 1 >=20 > Do you believe that more permissive compiler flags are the better answer? No, we should not force any compiler flag of the application. We are even trying to support pedantic flags in the app. So it seems we must fix it. We just need to change the title to mention it fixes the build for C++, and add the error message in the body.