From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 963684318A; Tue, 17 Oct 2023 15:27:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8444F42DDD; Tue, 17 Oct 2023 15:27:37 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 831F440270; Tue, 17 Oct 2023 15:27:35 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 673F73200AAA; Tue, 17 Oct 2023 09:27:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 17 Oct 2023 09:27:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1697549253; x=1697635653; bh=NJ0Dv2OXE8bkekvOKutTgjyFjd7VBl5um1a v/P5Bieg=; b=l5h0KWXU/pYKLO/vazBVozsGXzkF53zPXfPaxI2auHs/vKCBLxN j+AU/preZ7qgRbso0gvmfSs6Kvd1EmAgK0dIcjKxvyh9dAFPv2vMXJNOAtjQXY+t 2eS2qy3OljQ/V0u28BMqP2nh2uRExfKKkdeMsijt6vCKE6D7hgX87GwS0Utks0K4 kL0n5FfUSAMFyXK8DqqLa8cEaMlmDDgkXKMq/guRiWx1jNb9QJh339nhCy1IW0x0 eQpRY2IF2jIxquiwOzXxYQkzDJCkjSB7yGU/VzgR7HVmWDyJ2Dz4+Amj+NR/Tb+9 RyjPrj3NEvYXyFsLnf8vFPID/0YvzMwgGIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1697549253; x=1697635653; bh=NJ0Dv2OXE8bkekvOKutTgjyFjd7VBl5um1a v/P5Bieg=; b=sASWDa5MMYJWrpH4LgalfdzYMQYz6EwGH2psWubWzFKlbKk7pTu V0dRZnwJXN2loE1Kn24ndZaDzKfXBFaUjxSYLha3EYPJREaUKQXLPDQlLRM8Mu1V DhWkPva0ANu4Y3YI4+uVNkXQQXutxQ0Ruy0CPr9ousWZwsqtgHVgrqzG5k2IaGxA Qflo5CyJzoJLh9uVYtRGOaOsk/2Iyo82WFLj9J/6MXaBiGUCnWwaU6HaUlB5lY9x gVVOoH40RCp5Fx4Az4iKvy1ib4L7k/CIBZS+7dLseT8X0oEtMt79R+G4sd4bQAC/ l4MDfPuN28apjRk8F8VJqaA2qh/VWmaNIvA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjedvgdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Oct 2023 09:27:33 -0400 (EDT) From: Thomas Monjalon To: Vladimir Medvedkin Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH] fib6: fix adding default route as first route Date: Tue, 17 Oct 2023 15:27:31 +0200 Message-ID: <1832985.QCnGb9OGeP@thomas> In-Reply-To: <20231002151201.675868-1-vladimir.medvedkin@intel.com> References: <20231002151201.675868-1-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/10/2023 17:12, Vladimir Medvedkin: > Currently when adding default route as first route > it is not added and no error is reported. > When we enter the loop over an address range in > the general case we will eventually reach the check > for when the range has ended, and exit the loop. > However when adding default route as first route, > since address range covered begins and ends at zero > this also triggers loop exit without writing to the table. > > Fixed by adding check for default route, > i.e. both ledge and redge are equal to 0::0. > > Bugzilla ID: 1272 > Fixes: c3e12e0f0354 ("fib: add dataplane algorithm for IPv6") > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin Applied, thanks.