From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id AE0E01C893
 for <dev@dpdk.org>; Mon, 14 May 2018 16:11:43 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 24A7821DB7;
 Mon, 14 May 2018 10:11:42 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Mon, 14 May 2018 10:11:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=MSpct/qN/j7BlLK3zCdBD0Gd1J
 /L5wtxTPriZFHriw8=; b=RnZ1fAVNCwimOKMbXEYlkgR614voyWtlGZ3D1FaxVv
 CH4JsaSeeepcjelmXhNTl2eRFVURQCwquVA1G/KtPwZSg9Djzyumy4SQPTXdvW8x
 6FnyxCDPwAAmZitJnABAwT/rynf9TvtiCqMCExP5KhMEInChTxmzapCaYJDnxcff
 Y=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=MSpct/
 qN/j7BlLK3zCdBD0Gd1J/L5wtxTPriZFHriw8=; b=G8gye69yAgUrJdgnMV7Bp3
 CQyud5+iDmvYIw/44BDQsHHdH4okRfrXVgaDPXyWVoa34o3BFSSl+mZmlT3a2qhc
 CWFIa33qKfOnL3+N1ynS57iPBLbb77nqINnUHjJIAjDx/nM9dGISYZouvMI6l7yn
 Yv4HYC0hT3jT4F184O4C7z2bHu07wAB/cSufHdamMj2MJeJXvfSCs0Zpzde+cIkL
 TGsw8KK9ZarYdeQs/te5JjXR3NKX+rtWtLbAoOB2T4EGleWPQT4wkDDdMxFpXd1I
 aZnIAyO4fuKhjd59RI//codEloVl0eg7R20LxCfRXh+KviFgxFw8DrsMAo+ne2VA
 ==
X-ME-Sender: <xms:HZn5WvmmggxFIn0Zf0X1wjY2tmLug5NRRMd5cpC8L8iWt-OgvDnkaw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 542D9E5095;
 Mon, 14 May 2018 10:11:41 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Wei Dai <wei.dai@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, Qi Zhang <qi.z.zhang@intel.com>
Date: Mon, 14 May 2018 16:11:40 +0200
Message-ID: <1833263.kcaJZ8Err9@xps>
In-Reply-To: <1526304030-15507-1-git-send-email-wei.dai@intel.com>
References: <1526299235-54090-1-git-send-email-wei.dai@intel.com>
 <1526304030-15507-1-git-send-email-wei.dai@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v14] ethdev: new Rx/Tx offloads API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 May 2018 14:11:43 -0000

14/05/2018 15:20, Wei Dai:
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

[...]
>   *   hasn't been set in the input argument eth_conf->rxmode.offloads
>   *   to rte_eth_dev_configure(), it is a new added offloading, it must be
>   *   per-queue type and it is enabled for the queue.
> + *   No need to repeat any bit in rx_conf->offloads which has already been
> + *   enabled in rte_eth_dev_configure() at port level. An offloading enabled
> + *   at port level can't be disabled at queue level.

OK

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Thanks a lot Wei!