From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id DFE2F37B1 for ; Fri, 20 Jan 2017 15:29:26 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id c85so39307076wmi.1 for ; Fri, 20 Jan 2017 06:29:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=oHJyxlsFLYNNnV8oHnSe4tkHC++PLqc666jcm1Anrks=; b=FYZ/F0RmNRxTRoWdDaa41EZaNvgsuuBV5yWGa5wPBILESukaef873ayo+FCf3V3DvV zvI4MC5OXUY3RqSU/gOAjkTtNqok2CSKIq2zNP/VE8AGSFzZUXj5kgVRuWt5Q2PuW9K9 CdEOyB0wG+7mnoTIduMm6edfJp+osgbgk7mH55q55GHjT3CY6cTtd+ZcN/w7zyE4ZUck 4EKXot8hLaIIH4XjZnQ+W4Gks9Mtfyu51RXHw1DUOsS8g1OtJ9FBfXr1ZRIgaplMbpz5 lOq76ujFgjCzIQ3Ib8anQwGAbbF9UXZsqfo6uTKGt/873ejajd28S9HKTaYZgc4Dc/2o g12g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=oHJyxlsFLYNNnV8oHnSe4tkHC++PLqc666jcm1Anrks=; b=WrytfDExV7mL+QNGp7Ccg2K0Tw5YM7gtsfqNlTPWMcMWGdCihu7+kdq6sw+1djeqbF QqtTPOsPj2K5L0YUc3BmUsbxsVs/UT10VMB37ze0V9Wn4cXRVzawK6L6CYGbb50geIVf ZqRMDrb8VNwXzJP7y5j9rjhiTvMjUdpoyJPafhlLVkOQJzJ8cGhhC07UgP9xSDvBJCb5 zo87Gkl0E3w1yTw/Dsa2s9eerzLX5OOg6tv7eVbSIAI0OHH0kCt+mkw0mBBAus43FaeZ /hmepc48H6EZkh8pPQJTzuj/b9rTU8UTCqVl7PEP17YJKLzAcgjeqZZf9v7dwcIiQwTE ibQg== X-Gm-Message-State: AIkVDXL/YsQ4Kua+qudHx6hOCAO2NAWawEMpgXA8c35b2Ss7I6xlBpW0DL2+xgKIX9Df5gGE X-Received: by 10.28.185.193 with SMTP id j184mr3967991wmf.86.1484922566525; Fri, 20 Jan 2017 06:29:26 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 53sm12891wrt.20.2017.01.20.06.29.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jan 2017 06:29:25 -0800 (PST) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, ferruh.yigit@intel.com Date: Fri, 20 Jan 2017 15:29:25 +0100 Message-ID: <18339814.hMek8iyv21@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1484841140-24117-1-git-send-email-arybchenko@solarflare.com> References: <1484841140-24117-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/sfc: enable TSO by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 14:29:27 -0000 2017-01-19 15:52, Andrew Rybchenko: > Signed-off-by: Andrew Rybchenko > --- > It is a mistake that TSO support is compiled out by default. > We would be happy to enable it by deafult, but strictly speaking > it is not a bug fix. > > Arguments to enable are: > - be more feature-rich (and user-friendly) in default config > - the most of internal testing is done with TSO enabled > > config/common_base | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/config/common_base b/config/common_base > index b9fb8e2..134e9b9 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -261,7 +261,7 @@ CONFIG_RTE_LIBRTE_BNXT_PMD=y > # > CONFIG_RTE_LIBRTE_SFC_EFX_PMD=y > CONFIG_RTE_LIBRTE_SFC_EFX_DEBUG=n > -CONFIG_RTE_LIBRTE_SFC_EFX_TSO=n > +CONFIG_RTE_LIBRTE_SFC_EFX_TSO=y There should not be such option in the build-time configuration. Why keeping it (even enabled by default)?