From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id C4BFE937C for ; Fri, 13 Nov 2015 17:02:12 +0100 (CET) Received: by wmec201 with SMTP id c201so88247593wme.0 for ; Fri, 13 Nov 2015 08:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=A15N+ESMfFI2MmlO5TFONTPFYI8txA4ayzmSbsic5Bk=; b=ei2n76B+rAlMt27eSvQQcGPPa+JpCCZkQZxutYfuvGUxc3eKLsDoUzM0ktbkDZbioj 5U1rcqsGRyvh8AtSnXdvccoFm1u+vG519RGr5t70v4Qx4OrOijfc8WgpZyBzL3tFJWT6 p5ocVb5kACuG+ncsOXFfUSSnuBieMIVjhuWkdzgan4KmkAlZTJMYSxWm0Lg0kvHPQ17Q dHIbgo8t9qxV6VlnEBOqXfYJPGkccVT3d58NlEFTDrgfc+5Ib/9rn7P7o+jwcl96WLrF nABnTC3GgM3kfRmAAfy9t6FoHAZoo/X0WIXjWBIjq8gdeb9grAR6IQSQzJhw+mvI1mVT WTHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=A15N+ESMfFI2MmlO5TFONTPFYI8txA4ayzmSbsic5Bk=; b=j6z+D89EgrURH+RM2PEYAfTOLO5roWr7eXqU/2XNTY4wl7XZ6jn4cupDMhzK/c5nX+ LZ1Pi+yyoNkjX2DGim7hqc5blVr5QU2vK61qA6ohYGjnbHeAKFF7muCTSAysdGlHFszJ msyIe4tF+O52SiHQ/4Lku8tGMaH7BWqpaZ7ZqDCzShIF9fJC3kGgO3UmioIg42uzjQrC gnHrp7O7ISTbw9IlJguR9aR60qAu/WEA9ULdRMysNCAXd0OMA8gKyB4Wu9YMc+ZCFd2O qoR01cPdjc6JWb5boyZDFl1WJ4OOk06Pu0ZuDDPzKAd6Xv8XxWTxLzZHKBqx7S1RJGbO DfHg== X-Gm-Message-State: ALoCoQmj0HlWhWkD4GH65ul1q/ORpgWYRWnFTMy7v3PehoC0BOI37VJ7ndQz7QLXzqt64nNAt1ZM X-Received: by 10.28.213.12 with SMTP id m12mr4985727wmg.26.1447430532677; Fri, 13 Nov 2015 08:02:12 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id q1sm20479821wjy.31.2015.11.13.08.02.11 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 13 Nov 2015 08:02:11 -0800 (PST) From: Thomas Monjalon To: Declan Doherty Date: Fri, 13 Nov 2015 17:00:59 +0100 Message-ID: <1834242.iLgMQtWqy4@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1447176763-19303-8-git-send-email-declan.doherty@intel.com> References: <1447101259-18972-1-git-send-email-declan.doherty@intel.com> <1447176763-19303-1-git-send-email-declan.doherty@intel.com> <1447176763-19303-8-git-send-email-declan.doherty@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 07/10] qat_crypto_pmd: Addition of a new QAT DPDK PMD. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 16:02:12 -0000 2015-11-10 17:32, Declan Doherty: > --- a/lib/librte_mbuf_offload/rte_mbuf_offload.h > +++ b/lib/librte_mbuf_offload/rte_mbuf_offload.h > @@ -123,17 +123,10 @@ rte_pktmbuf_offload_get(struct rte_mbuf *m, enum rte_mbuf_ol_op_type type) > { > struct rte_mbuf_offload *ol = m->offload_ops; > > - if (m->offload_ops != NULL && m->offload_ops->type == type) > - return ol; > - > - ol = m->offload_ops; > - while (ol != NULL) { > + for (ol = m->offload_ops; ol != NULL; ol = ol->next) > if (ol->type == type) > return ol; > > - ol = ol->next; > - } > - > return ol; > } Strange: why changing the code of the previous patch?