From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F077A054F; Tue, 2 Mar 2021 13:40:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5860D4014E; Tue, 2 Mar 2021 13:40:47 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 9948140142 for ; Tue, 2 Mar 2021 13:40:45 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E5F8C5C019C; Tue, 2 Mar 2021 07:40:43 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 02 Mar 2021 07:40:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= I3nGm8Psz5yc4uYFPpK43yFLIDIAe1ah56LwABLEJLw=; b=Ww0VCantI7P5tlWH EefasXWVDZOI0PYYeqWGczmuYc3maCzjFrBc/em84Oj73JhwWIRIj9RC5VwkAdv4 6YlSU+bVlVtH6cWCtQqiz/ptaBHlPwYFe7FD71XifulR47dfvG/vx3il/TM3G8BA zv6glTq7TUOPyIaNRKM71+b7CW0g0vEVM+BFprPRtrycuSaqvMnQ5bHE1Mjd1YXQ Pr3hMxBIisjigp73N/+c0NxAcs/gGWgCuOdbhSfC//1L1BPKNftxoqKI5Ym+VhnA dsF+1T1i1q62J1ttIt6CdOcymXZUZyE1aMTzVaEcwc70FsJ+1EVIVoAEeE1/Cr+I bvJ7hQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=I3nGm8Psz5yc4uYFPpK43yFLIDIAe1ah56LwABLEJ Lw=; b=S40qaeCbNAACKbZMqFz0ZsP0xMiG9m+OGfZbWmd8CIvZRAQmCNwzWnfl0 P12zQCST9dvnlza5ZaD3tPdvdnwidW2zrZxS8WEQNYUOcFm5lM7ouGSIpCxWbOuf 0wIyz84woe2pLxC6dZShYKSntZMdjJRHfq+6t7hkXkBnEcwHaYkfRrKY7N4TTDDk 1nHB4FsguNibhjS4mthq134wGEEuKB6qjwCv/V2A5GJadnvRcmNRdD94T97La2x6 eu4Om43YJ8KuZL4diaQAHE9LWTnNy6j9ZAy4OvR7SqzUKpe+Jdwh+cy+oJFFa/Vw JdDdsMHeAYNRknBp5W45SDK17Crdw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddttddggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AC0D724005A; Tue, 2 Mar 2021 07:40:41 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Kevin Laatz , ciara.power@intel.com, dev@dpdk.org, david.marchand@redhat.com Date: Tue, 02 Mar 2021 13:40:39 +0100 Message-ID: <18349908.mb9rSiqodV@thomas> In-Reply-To: <20210302110630.GD1396@bricha3-MOBL.ger.corp.intel.com> References: <2019455.957uq3bD9f@thomas> <11617595.khkVX0lYF1@thomas> <20210302110630.GD1396@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] telemetry logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/03/2021 12:18, Bruce Richardson: > On Tue, Mar 02, 2021 at 12:01:12PM +0100, Thomas Monjalon wrote: > > 02/03/2021 11:42, Bruce Richardson: > > > On Tue, Mar 02, 2021 at 11:23:41AM +0100, Thomas Monjalon wrote: > > > > 02/03/2021 11:14, Bruce Richardson: > > > > > On Mon, Mar 01, 2021 at 08:22:15PM +0100, Thomas Monjalon wrote: > > > > > > Hi, > > > > > > Sorry if I already asked this question. > > > > > > Would it be possible to use rte_log in rte_telemetry > > > > > > instead of returning telemetry_log_error at init? > > > > > > > > > > > It probably could be made to work by passing in the log function at init > > > > > time. Haven't delved too much into the details, though. > > > > > > > > Actually I think a better question is about the need to init telemetry > > > > if not used. It can generate an error without a need. > > > > Instead of the existing option --no-telemetry, > > > > what do you think of initializing the telemetry on its first use? > > > > This way we could remove the dependency of EAL on telemetry? > > > > > > > There is no real first use - the various libraries all register their callbacks > > > inside the init functions of the shared libraries. Having it initialized > > > inside EAL makes things very useful, because it means that all DPDK apps > > > automatically have telemetry available. > > > > Registering libs should be always possible, yes. > > But the init of the socket can be deffered to its use, no? > > > Not sure what you mean here? When would you see the socket init taking > place if not in EAL init? I think my request is just impossible. My wish is that telemetry socket is initialized only when we need it. But no, I don't know how to detect a socket query before creating the socket... > Of course, the other alternative to this problem is a solution you were > previously suggesting: to move basic services such as logging to a separate > library so that we split EAL into two parts, with the init being in the > second higher-level part. Obviously this is a very significant amount of > work though, so unlikely to be undertaken quickly. I agree it would be an interesting and huge work.