From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 277732C16
for <dev@dpdk.org>; Thu, 3 Aug 2017 23:28:45 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id DD77C2093D;
Thu, 3 Aug 2017 17:28:44 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
by compute1.internal (MEProxy); Thu, 03 Aug 2017 17:28:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=jPL0QynUe7Bh7ac
71haBst+vXlPcFSgVpswlzapqTM8=; b=TEi8br0kwfSzoFvTO2xRxxvorNpCLud
H7FTbjyqGka8igv+LMCmOap+PvgGWCSc/9pp4HDCL2xNOlos+c1/Dty6skwrB43L
Cjx6fVtHTJSbiNx/fg5ywCpUPy7Swd0iNt3Mc/9RWozfTQueuC2D0VptucrUEjN1
LFdKZessfX64=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
fm1; bh=jPL0QynUe7Bh7ac71haBst+vXlPcFSgVpswlzapqTM8=; b=LToRBUtJ
gjT6amRj0W36W3/FYbDck5nH/7iEPHVpHZJFvsvtHD/CI6JW+YMayGIogoECzfXI
QTelah6IXhgwGKYEnuRPIMi6Pmfjv8FzAp+uQxxrOs0mDB45Pk80RYrzOBa4Dpts
pAaDmWzg/JKsWF1zyanB1xgJZSk8IPs/K/HmnVtV67txZWFU+VNkcwR2xG+zi7mi
Ac2DP6aeLOmik+pZsxXSlhK8bUW4JWS+mREV1yHvwffU7hxRdw9lMitufJQcxkqu
wpom/ifrflYVHH3+fyDmnnrbKiBPH3hq/eYeLtcBmxprWGUmvXmXjrHwM2JwIxpx
6vemdNaSYQN2gA==
X-ME-Sender: <xms:jJWDWdA2gPbVs52mopUccN9waZmFvTzNqitlFxu36MvvaTyz6ZoqbA>
X-Sasl-enc: RG5UB+AgZO88dGAytOjVt620sUkD0PsH/JpyP+dIyqGv 1501795724
Received: from xps.localnet (196.114.118.80.rev.sfr.net [80.118.114.196])
by mail.messagingengine.com (Postfix) with ESMTPA id 760A324691;
Thu, 3 Aug 2017 17:28:44 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com
Date: Thu, 03 Aug 2017 23:28:42 +0200
Message-ID: <1835087.fN3h1d379y@xps>
In-Reply-To: <20170802172554.17079-1-yskoh@mellanox.com>
References: <20170802172554.17079-1-yskoh@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix statistics for error packets
on vectorized Rx
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Aug 2017 21:28:46 -0000
02/08/2017 19:25, Yongseok Koh:
> If there's a Rx completion with error (e.g, MTU mismatch), it is handled
> later out of main burst loop as a slow path for performance reason.
> Statistics should be corrected by subtracting counters of errored packets.
> Also, the last entry of mlx5_ptype_table[] must be RTE_PTYPE_ALL_MASK to
> mark error in completion.
>
> Fixes: ea16068c0064 ("net/mlx5: fix L4 packet type support")
> Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86")
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied, thanks