From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7216E43DED; Wed, 3 Apr 2024 16:52:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 434234025C; Wed, 3 Apr 2024 16:52:22 +0200 (CEST) Received: from fout2-smtp.messagingengine.com (fout2-smtp.messagingengine.com [103.168.172.145]) by mails.dpdk.org (Postfix) with ESMTP id 3829F40144; Wed, 3 Apr 2024 16:52:21 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfout.nyi.internal (Postfix) with ESMTP id A79EC1380150; Wed, 3 Apr 2024 10:52:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 03 Apr 2024 10:52:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1712155940; x=1712242340; bh=jw3/wtw1mnA2YUVsJG42NGaLCg9AMlo95RIG7t/M6Eg=; b= s9YtjLjozYyy/VzxENKYPKvCxA5Uc5I8keJ8PWPcycGbRN9QGc823YES0xUYgBZN ii5T5943oM9lT/yvQNd4W8uMYx8ArWJnGgedamLJ7nhjrl2tkdJyR0YRItp2usmg 0RJ39YxxVRQ3nhPZSPdNAYo7Qgx+U4a+ELbyEwDiyfzPQ7insz40p0kr0RgvtPIn 2N5XPfhPDsX4uoDNvjVkO/+lyS7BeylMjlEXAFjvr2Zl5E5llWKkoYvW7FFqvTbY m2etdp+IcOIGc4g5ePctYfk5kbmTNZ1T/Jarnevwd8NTcEr3omoD66n586fhmI18 7XF97/9bQg6ZP/IiFOA9cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712155940; x= 1712242340; bh=jw3/wtw1mnA2YUVsJG42NGaLCg9AMlo95RIG7t/M6Eg=; b=I 5g4+rK7uCRPf860b8NHii3ovFG0m2lKsC0e0X+YUFlxUsoAvqlvPctPVbTHY947F iwfRa9eTeJvMWunLSJ0ORpCbPe41X2Q82G7NIrON9O1q6CwDYeS/MqRrR9iBSOx+ U34Ay8PE4O6aSP7/sOYPirOM9FyyBsQN349imOCdPSd28wa3pj2P9pjI1LetG42f DiOi/H35FiAY4sLK7sWK37muEJ0sYss/gHU1wmrjGw8xYPl/CI5nxLl10mg0ju5M U+/x/UnqSLjFBucYs3OY7gxnGlpuLJSuJVLlFzastzJB4z/y/VBLYuogJqLmLbL1 APLWgXmxdkMrkIjKZwnUw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefiedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Apr 2024 10:52:19 -0400 (EDT) From: Thomas Monjalon To: Ashish Sadanandan Cc: dev@dpdk.org, nelio.laranjeiro@6wind.com, stable@dpdk.org Subject: Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h Date: Wed, 03 Apr 2024 16:52:18 +0200 Message-ID: <1836105.FMhQkTaH9n@thomas> In-Reply-To: References: <20240202051335.776290-1-ashish.sadanandan@gmail.com> <20240318024415.555614-1-ashish.sadanandan@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/04/2024 18:03, Ashish Sadanandan: > Hi everyone, > I've made the updates as suggested. Could someone please review the latest > patchset? Not sure if I followed the new patchset instructions correctly, > I've always had trouble with that part. I remember we were discussing about aligning all files. I was waiting for a patch applying the rule we discussed. > On Sun, Mar 17, 2024 at 8:44=E2=80=AFPM Ashish Sadanandan < > ashish.sadanandan@gmail.com> wrote: >=20 > > The header was missing the extern "C" directive which causes name > > mangling of functions by C++ compilers, leading to linker errors > > complaining of undefined references to these functions. > > > > Also updated the coding style contribution guideline with a new > > "Language Linkage" section stating `extern "C"` block should be added to > > public headers. > > > > Fixes: 86c743cf9140 ("eal: define generic vector types") > > Cc: nelio.laranjeiro@6wind.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Ashish Sadanandan > > --- > > .mailmap | 2 +- > > doc/guides/contributing/coding_style.rst | 21 +++++++++++++++++++++ > > lib/eal/include/generic/rte_vect.h | 8 ++++++++ > > 3 files changed, 30 insertions(+), 1 deletion(-) > > > > --- a/doc/guides/contributing/coding_style.rst > > +++ b/doc/guides/contributing/coding_style.rst > > +Language Linkage > > +~~~~~~~~~~~~~~~~ > > + > > +Public headers should enclose all function and variable declarations a= nd > > definitions in an ``extern "C"`` block to facilitate interoperability w= ith > > C++. > > + > > +.. code-block:: c > > + > > + #ifndef _FILE_H_ > > + #define _FILE_H_ > > + > > + #ifdef __cplusplus > > + extern "C" { > > + #endif > > + > > + /* Code */ > > + > > + #ifdef __cplusplus > > + } > > + #endif > > + > > + #endif /* _FILE_H_ */ This is not describing where the includes should be placed.