* [dpdk-dev] [PATCH] pdump: close client socket
@ 2016-07-04 16:17 Reshma Pattan
2016-07-04 16:31 ` Mcnamara, John
0 siblings, 1 reply; 3+ messages in thread
From: Reshma Pattan @ 2016-07-04 16:17 UTC (permalink / raw)
To: dev; +Cc: Reshma Pattan
Close the client socket before returning on error.
Coverity issue: 127555
Fixes: f3c1829130ac ("pdump: check missing home environment variable")
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
lib/librte_pdump/rte_pdump.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c
index ee566cb..22ed476 100644
--- a/lib/librte_pdump/rte_pdump.c
+++ b/lib/librte_pdump/rte_pdump.c
@@ -677,7 +677,7 @@ pdump_create_client_socket(struct pdump_request *p)
RTE_LOG(ERR, PDUMP,
"Failed to get client socket path: %s:%d\n",
__func__, __LINE__);
- return -1;
+ goto exit;
}
addr.sun_family = AF_UNIX;
addr_len = sizeof(struct sockaddr_un);
@@ -728,6 +728,7 @@ pdump_create_client_socket(struct pdump_request *p)
ret = server_resp.err_value;
} while (0);
+exit:
close(socket_fd);
unlink(addr.sun_path);
return ret;
--
2.5.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] pdump: close client socket
2016-07-04 16:17 [dpdk-dev] [PATCH] pdump: close client socket Reshma Pattan
@ 2016-07-04 16:31 ` Mcnamara, John
2016-07-10 13:01 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Mcnamara, John @ 2016-07-04 16:31 UTC (permalink / raw)
To: Pattan, Reshma, dev; +Cc: Pattan, Reshma
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Reshma Pattan
> Sent: Monday, July 4, 2016 5:17 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>
> Subject: [dpdk-dev] [PATCH] pdump: close client socket
>
> Close the client socket before returning on error.
>
> Coverity issue: 127555
>
> Fixes: f3c1829130ac ("pdump: check missing home environment variable")
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] pdump: close client socket
2016-07-04 16:31 ` Mcnamara, John
@ 2016-07-10 13:01 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-07-10 13:01 UTC (permalink / raw)
To: Pattan, Reshma; +Cc: dev, Mcnamara, John
> > Close the client socket before returning on error.
> >
> > Coverity issue: 127555
> >
> > Fixes: f3c1829130ac ("pdump: check missing home environment variable")
> >
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-10 13:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-04 16:17 [dpdk-dev] [PATCH] pdump: close client socket Reshma Pattan
2016-07-04 16:31 ` Mcnamara, John
2016-07-10 13:01 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).