From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id D22F96837
 for <dev@dpdk.org>; Tue, 24 Feb 2015 20:24:53 +0100 (CET)
Received: by wghn12 with SMTP id n12so7439698wgh.1
 for <dev@dpdk.org>; Tue, 24 Feb 2015 11:24:53 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=2zBsaE+/0L4/9LIQFeX3K1BrcmCI1LNgUHlzQETVNbI=;
 b=WS5QRAouDng2rDSbXHtC3aiWlBXVvTT0MxPc8yQ6KF0bzK+ZLPCagrv7gH4JRyYrSm
 u+lNX1YKNyJV6/2NO4PRnh/6rFouk/rZqy3QPM0FT09D+xANT/XDNIz6obwbqshgjCo7
 fs8wWgWlJBLfEeR3Q+HO5TsIOQiCune4jiUPdDLtvtaoqkCmVpab+g+ZCWG9UgXuAahK
 o483jHlJMi1SHnB+fwj0jqtIbRjNXoe4r6m3NIWqwOxdgw/KK9VDbe9vyYx/7IqZYAs2
 NQ8eD6FBbG6SiqY2xWuhRr9RVN7hUhd9T9T9FnpwFRpQOpq8LYZOsiSceNQwXlvLLmqM
 el7Q==
X-Gm-Message-State: ALoCoQkTzCYCnbdvH8vuCB71t8eg+e8VJJz3bcKnJvy6F/Xjzx4kHCd8IQaEX2cZkw6t7eHxAm1v
X-Received: by 10.180.78.202 with SMTP id d10mr33131947wix.25.1424805893629;
 Tue, 24 Feb 2015 11:24:53 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id jy7sm11955578wid.22.2015.02.24.11.24.52
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 24 Feb 2015 11:24:52 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Date: Tue, 24 Feb 2015 20:24:20 +0100
Message-ID: <1836720.DS2V1117TQ@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <54EC4F7B.6080907@igel.co.jp>
References: <54E5ED96.9040402@igel.co.jp>
 <1424770891-19243-1-git-send-email-david.marchand@6wind.com>
 <54EC4F7B.6080907@igel.co.jp>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] devargs: restore empty devargs as ""
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2015 19:24:54 -0000

2015-02-24 19:16, Tetsuya Mukawa:
> On 2015/02/24 18:41, David Marchand wrote:
> > Following commit c07691ae1089, an implicit change has been done in the devargs
> > api.
> > This triggers problem in virtual pmds that did not check for parameters validity
> > as it was implicitely valid.
> >
> > Fix this by restoring the empty argument as "" and add a note in the api.
> > Restore associated tests.
> >
> > Fixes: c07691ae1089 ("devargs: remove limit on parameters length")
> > Reported-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> > Signed-off-by: David Marchand <david.marchand@6wind.com>
> 
> Hi David,
> 
> I've confirmed this patch fixes the issue descried in above comment.

Applied, thanks