From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 94BC71BADE for ; Thu, 26 Oct 2017 14:33:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1709D20805; Thu, 26 Oct 2017 08:33:59 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 26 Oct 2017 08:33:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=otHl//LbHxJtC40VH2t6PSd+QJ NKCM7OS507Li3sveE=; b=NfVhNn2tzcpnFbJiqkB8VFvt0sTQWBM8tj0AZ53ytu 9I/YLb6ho/XmzV2DyWwZ/bp2quEwretC1c518nrgywS8TUrfVD7NH1KEGHcar8tU 1VK6gIYocG6XR7EnEkJGtIrbRmrwa1nbwaIfJEy0mdA+v+Q0h9JxrCeSdtUf6aGk Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=otHl// LbHxJtC40VH2t6PSd+QJNKCM7OS507Li3sveE=; b=MIE/n7kpSsc3UR9x6gPLpS MrXcJfniBnNc0Iq+h9IBE1kWcweNgsecNqmXPmncWO5tKXH2Rdm+IPliBEbBOo25 vNjLLJ7QOUHwm4HumLPc95EFV+JyJxLYq3MQeHcjIK1j1qYldjKV3k58TcTEmiEk t73mobjiR0inleclyP3E2zkv66bcsBeH97G8SY08CeMgzqvolOVg2qrMxWCpyKPg +28rE1nfDSAzF/Oo3UfD9rJ8yWpKiWjH2VQIN5vIwilGQp5SMSZFkZI0TE4B8OiO uDUfnGWi1qJj/XciCZyaUSgciEbPGGVrvXgk9Sa9Se0WGGAi7/XMoUO/xVCDls2A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B439A24009; Thu, 26 Oct 2017 08:33:58 -0400 (EDT) From: Thomas Monjalon To: Radu Nicolau Cc: David Marchand , dev@dpdk.org, Declan Doherty , Pablo de Lara , Hemant Agrawal , borisp@mellanox.com, aviadye@mellanox.com, sandeep.malik@nxp.com, Jerin Jacob , "Mcnamara, John" , "Ananyev, Konstantin" , shahafs@mellanox.com, Olivier Matz , Akhil Goyal Date: Thu, 26 Oct 2017 14:33:57 +0200 Message-ID: <1837995.9rLZR0Gx80@xps> In-Reply-To: <99778dc4-9fea-e859-71b8-c1ff910eebd2@intel.com> References: <1509013365-13819-1-git-send-email-radu.nicolau@intel.com> <2193963.B775pDLU5T@xps> <99778dc4-9fea-e859-71b8-c1ff910eebd2@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/3] net/ixgbe: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 12:33:59 -0000 26/10/2017 14:28, Radu Nicolau: > > On 10/26/2017 12:39 PM, Thomas Monjalon wrote: > > 26/10/2017 13:27, David Marchand: > >> On Thu, Oct 26, 2017 at 1:01 PM, Radu Nicolau wrote: > >>> On 10/26/2017 11:36 AM, David Marchand wrote: > >>>> On Thu, Oct 26, 2017 at 12:22 PM, Radu Nicolau > >>>> wrote: > >>>>> --- a/drivers/net/ixgbe/Makefile > >>>>> +++ b/drivers/net/ixgbe/Makefile > >>>>> +ifneq ($(MAKECMDGOALS),clean) > >>>>> +ifneq ($(CONFIG_RTE_LIBRTE_SECURITY),y) > >>>>> +$(error "RTE_LIBRTE_SECURITY is required to build RTE_LIBRTE_IXGBE_PMD") > >>>>> +endif > >>>>> +endif > >>>> This is a no go for me unless you explain how it is impossible to > >>>> disable it in the code. > >>>> > >>>> > >>> It can be disabled in the code, but as far as I know there is a general push > >>> back against having conditionally compiled code. I originally had the > >>> security sections in ixgbe PMD isolated, but the feedback was to have them > >>> always on. > >> In my mind, this was to stop having features enabled per pmd (and stop > >> the nightmare with 10 options in a pmd). > >> Having features globally enabled for all or nothing is still > >> acceptable, is it not ? > > Yes there is a config option for rte_security, > > and it is acceptable. > > The code depending on it must be ifdef'ed. > > Given that both ixgbe and dpaa2_sec are now security enabled PMDs, I > would go with Konstantin's proposal, have rte_security listed as a > dependency (instead of the explicit check). Please consider my request instead. Until now we are ifdef'ing code to allow disabling any lib. We are not going to change our mind during the last days of a release. Please just fix it for now.