From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D02371B780 for ; Wed, 31 Jan 2018 14:31:50 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 62DAC20C63; Wed, 31 Jan 2018 08:31:50 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 31 Jan 2018 08:31:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=wmU80TVZtSTpGI6bH4bIt4XRrn yCePMxpQthoMDY21E=; b=bhr9gipiM7lZOqw1A2IFsSQywc2GERsRZ698qYln4k t+M3w0dZjK0s403DcJ2zrLgv1ZEkyYzxUyijXM5zwBKp6vWooZ+IWOLAwdIcYI7P 7VyCLjh0FCoAP2OgiJqJ47a8+0v0wt9S/4oro9wc3+vL+mXK7waTrBzwvJxdpRxE k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wmU80T VZtSTpGI6bH4bIt4XRrnyCePMxpQthoMDY21E=; b=nRQuPpr2JPRMGjyjDyWv7a 2Dti2rJdTlEvUTWiuYgx1L1Htku23r6bm0TdY2LAZ1vL7Y5jCCwUktjofhl13bEo N+6sgnKF8gaWgDv6IYJn/LJSnwFjaYswge4dzjzzUqLXcyyQeZ0hzMo33Xg5hQne MLzE+J340VCEYXGwACN3lrmGCuUfV9Dpxwpt2u9zmSoN48dTWgDGee/bzhCgFg2J f6Pou9hseoVsdfY2L4bXqem/aiSeL2CC4PSKUu4Gy8e/YLgZBK5J12dli49YTdiS aRC6JsmfZA+Y9uiAEjC1ptNxWhTIul57R0iaGQvU64tpSTVBugMCovmTooA0u64A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 105DF24803; Wed, 31 Jan 2018 08:31:50 -0500 (EST) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org, hemant.agrawal@nxp.com, fiona.trahe@intel.com, rosen.xu@intel.com Date: Wed, 31 Jan 2018 14:31:04 +0100 Message-ID: <1838229.CbHqTgKorz@xps> In-Reply-To: <2766742.IHp3MJlWRC@xps> References: <20180130145710.24757-1-shreyansh.jain@nxp.com> <20180131091318.7894-8-shreyansh.jain@nxp.com> <2766742.IHp3MJlWRC@xps> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 07/10] drivers/raw: introduce skeleton rawdev driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 13:31:51 -0000 31/01/2018 14:20, Thomas Monjalon: > 31/01/2018 10:13, Shreyansh Jain: > > Skeleton rawdevice driver, on the lines of eventdev skeleton, is for > > showcasing the rawdev library. This driver implements some of the > > operations of the library based on which a test module can be > > developed. > >=20 > > Design of skeleton involves a virtual device which is plugged into > > VDEV bus on initialization. > >=20 > > Also, enable compilation of rawdev skeleton driver. > >=20 > > Signed-off-by: Shreyansh Jain > > --- >=20 > It does not compile on 32-bit: >=20 > drivers/raw/skeleton_rawdev/skeleton_rawdev.h:13:51: error: > format =E2=80=98%lu=E2=80=99 expects argument of type =E2=80=98long unsi= gned int=E2=80=99, but argument 6 has type =E2=80=98uint64_t {aka long long= unsigned int}=E2=80=99 [-Werror=3Dformat=3D] > rte_log(RTE_LOG_ ## level, skeleton_pmd_logtype, "%s(): " fmt "\n", \ =46ixed when applying: =2D-- a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c +++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c @@ -7,6 +7,7 @@ #include #include #include +#include #include =20 #include @@ -329,7 +330,7 @@ static int skeleton_rawdev_get_attr(struct rte_rawdev *= dev, SKELETON_ATTRIBUTE_NAME_MAX)) { *attr_value =3D skeldev->attr[i].value; done =3D 1; =2D SKELETON_PMD_DEBUG("Attribute (%s) Value (%lu)", + SKELETON_PMD_DEBUG("Attribute (%s) Value (%" PRIu64= ")", attr_name, *attr_value); break; }