From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 467722BA1 for ; Mon, 11 Jul 2016 16:17:25 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id o80so52892009wme.1 for ; Mon, 11 Jul 2016 07:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=45rfvCWzors8qsDxyaK2JctXtB5lUN4P/eoiSi5nUkQ=; b=pgGV2mA1eqfAOeWL8Vztkphk5wFKX09dFjazBGV3GhXdiJ2a2QEgrlHuGaOWoo6aBa Qj8MQvAZnikqbNJLGrVfEbLPz3VsRo4bcMCXwvIfs9L2FYRJ1ssq9InUwoUXLcTRP29h xMAKg3Ai8UcmnNZb68f6AYcqKv/2Z2FTK160n8eav6Io16K8maVibt4czTTg1ypa578y IXZr0XkVwvNI++9zkxr5kvw/45fcE1c9yrxNvRWhNO6TFY4lUpZo70IjjanPcmnPaH3e vcoT7FN01t3LRHoZxGrV7mxq5RP66GoNN26a8CyG3OJOkAPXTv+gdZMyb9pGtJqenBJV zqVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=45rfvCWzors8qsDxyaK2JctXtB5lUN4P/eoiSi5nUkQ=; b=Qx13YR//Yi0M/a8OB4lCZblDsm2fQ6yXUQVy2ONZAiSmLoUKYjxwm4VeQ0GD8U6grP qB8dHenKMB0OO20ipIkkJLT0B+4tfWOCqR5FFYx6ymUx2VHoourK+noiBPXT90w1cVvN MO/ezVJtXT2mw9+BxfJGfm3+JWi2imrTLHqIqoJDws99F+yGiJY037kT9p9MOM27DL64 bAi0InJkRD3Pp2WThLfc34WSPoA+GUGqEjhwpVkRjG2svBvbACgyvCk+Ei+cjmIp/cx5 vfBCW4v2/51u37y2rOXy70abe4cjPmA2vTMOk+4m2VBCAdZycLdUJuGiDeacE2p5E9lj MMAQ== X-Gm-Message-State: ALyK8tKIBhBMP/dT2t8aSKH8L1dPozpyZu3e67HLkIpWGqMXxCKUn0sJrVoaJwsooYholWs8 X-Received: by 10.194.0.240 with SMTP id 16mr72551wjh.156.1468246645065; Mon, 11 Jul 2016 07:17:25 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id a191sm10678968wme.5.2016.07.11.07.17.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2016 07:17:24 -0700 (PDT) From: Thomas Monjalon To: "Doherty, Declan" Cc: "Azarewicz, PiotrX T" , dev@dpdk.org Date: Mon, 11 Jul 2016 16:17:19 +0200 Message-ID: <1838303.IRcXQLJGt7@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <4837007523CC9A4B9414D20C13DE6E64136D27B2@IRSMSX102.ger.corp.intel.com> References: <1464183292-24280-1-git-send-email-piotrx.t.azarewicz@intel.com> <21237364.CLn9ZV8ln9@xps13> <4837007523CC9A4B9414D20C13DE6E64136D27B2@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/1] examples/l2fwd-crypto: improve random key generator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2016 14:17:25 -0000 2016-06-08 07:46, Azarewicz, PiotrX T: > > 2016-05-25 15:34, Piotr Azarewicz: > > > This patch improve generate_random_key() function by replacing rand() > > > function with reading from /dev/urandom. > > > > > > CID 120136 : Calling risky function (DC.WEAK_CRYPTO) > > > dont_call: rand should not be used for security related applications, > > > as linear congruential algorithms are too easy to break > > > > > > Coverity issue: 120136 > > > > > > Signed-off-by: Piotr Azarewicz > > > > Is it relevant for this example? > > Maybe not. But it don't break anything, and in the end make Coverity tool happy. > > Declan, please share your opinion. Declan?