From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 76D9D235 for ; Sun, 9 Jul 2017 22:01:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 07AD520506; Sun, 9 Jul 2017 16:01:33 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 09 Jul 2017 16:01:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=5rI0qrisHDjUeO1 KlCz4VzcOpfGjX/Gh+cwED0lJ+t0=; b=WtKT3P6lmD+Ps+YejMWPjNoJgj46y/I wK/rSRPC1PUFB3xjpg8e3/NQp2DSOKGtYSK7zEDfdJtXCTO3ddQiE58ffKW03Zet gC6pZ2bT7WAOfU6PIykHsyZbrhRb/ABSoWT72Rqyz/u/6mMXdVw94ulkySXnFbq0 IMkNT7ZH0oB8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=5rI0qrisHDjUeO1KlCz4VzcOpfGjX/Gh+cwED0lJ+t0=; b=MnyfAjTq ml4sSFnyZoMXowKzLi/ZA6ezHAIMrpayaJjB6yXBWwYUjdtZAYG4vBhfj7nxWg6s XGKik/lhePA9d2VEwuvFuNZR96Wh7icvySd64F0FI9D+uwCLeOyTH1a+3Xrr3fbg xsoTldZzCXEyxTid5gzJe3K7NfWiamOaiCEuSp8SwKIlIaid0DONZOEDI2YL3vQB 3XO89p5DdfgJiL+c+zslnWgMYYNTwr0RBHLsDfpBvPG2P/9CBxT5K1dqg/Ey8xYh roOjEzFd+P2wO4L5aaYcfyYOuUUpnUHNSQf8NaSXJ8J5ndZLOdUFx6CUSrHImwas d1smtzW9mSA+xw== X-ME-Sender: X-Sasl-enc: g6Z2yS4QZxfp9AYkELUevqugujgGMJ2DRcKmRJTMrK7b 1499630492 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AFC5B7E71B; Sun, 9 Jul 2017 16:01:32 -0400 (EDT) From: Thomas Monjalon To: Cristian Dumitrescu Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, jasvinder.singh@intel.com, wenzhuo.lu@intel.com Date: Sun, 09 Jul 2017 22:01:31 +0200 Message-ID: <1838852.sCttUoyffy@xps> In-Reply-To: <1499182731-86830-1-git-send-email-cristian.dumitrescu@intel.com> References: <1499182731-86830-1-git-send-email-cristian.dumitrescu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [pull-request] next-tm 17.08 pre-rc1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 20:01:33 -0000 Hi, 04/07/2017 17:38, Cristian Dumitrescu: > http://dpdk.org/git/next/dpdk-next-tm I'm sorry to not have considered this tree as a high priority. I think it may be integrated in RC2 because it is a totally new area and should not break any existing code. I prefer to wait because I have seen some things to fix: 1/ There is a compilation error with clang (notified in related thread). 2/ Some functions are exposed in the API to query the ops. It seems dangerous and useless: - rte_eth_dev_tm_ops_get - rte_tm_ops_get 3/ The PMD interface file is referenced in the doxygen index: + [rte_tm_driver] (@ref rte_tm_driver.h), I see that rte_flow_driver.h is also referenced but it seems a mistake. 4/ As it is a totally new API, it should be declared as EXPERIMENTAL in the MAINTAINERS file and in the doxygen. 5/ There is no doc in the programmer's guide. 6/ There is no application to test it. I know that the points 5/ and 6/ are long to complete. However I would like to know what is the plan? And should we integrate TM in 17.08 without neither doc nor app?