[dpdk-dev] [PATCH 0/2] fixes for icc build errors

[dpdk-dev] [PATCH 0/2] fixes for icc build errors

[Daniel Mrzyglod]

This series of patches is to solve errors for Intel C Compiler 

Daniel Mrzyglod (2):
  examples/l2fwd-crypto: fix for icc
  examples: fix build errors for icc

 examples/ipsec-secgw/Makefile | 4 ++++
 examples/l2fwd-crypto/main.c  | 4 ++--
 examples/vmdq_dcb/Makefile    | 4 +++-
 3 files changed, 9 insertions(+), 3 deletions(-)

-- 
2.5.5

[dpdk-dev] [PATCH 1/2] examples/l2fwd-crypto: fix for icc

[Daniel Mrzyglod]

Fix for compilation errors for icc:
error #188: enumerated type mixed with another type

Fixes: 00c58901f1b3 ("examples/l2fwd-crypto: use key-value list of supported algorithms")

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
 examples/l2fwd-crypto/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index 35171d1..182dc56 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -902,7 +902,7 @@ parse_cipher_algo(enum rte_crypto_cipher_algorithm *algo, char *optarg)
 
 	for (i = 0; i < RTE_CRYPTO_CIPHER_LIST_END; i++) {
 		if (!strcmp(supported_cipher_algo[i], optarg)) {
-			*algo = i;
+			*algo = (enum rte_crypto_cipher_algorithm)i;
 			return 0;
 		}
 	}
@@ -978,7 +978,7 @@ parse_auth_algo(enum rte_crypto_auth_algorithm *algo, char *optarg)
 
 	for (i = 0; i < RTE_CRYPTO_AUTH_LIST_END; i++) {
 		if (!strcmp(supported_auth_algo[i], optarg)) {
-			*algo = i;
+			*algo = (enum rte_crypto_auth_algorithm)i;
 			return 0;
 		}
 	}
-- 
2.5.5

[dpdk-dev] [PATCH 2/2] examples: fix build errors for icc

[Daniel Mrzyglod]

error: loops in this subroutine are not good vectorization candidates
 (try compiling with O3 and/or IPO).

Solution to disable this diagnostic message
https://software.intel.com/en-us/forums/intel-c-compiler/topic/537688

Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Fixes: 8cc72f2814dd ("examples/vmdq_dcb: support X710")

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
 examples/ipsec-secgw/Makefile | 4 ++++
 examples/vmdq_dcb/Makefile    | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/examples/ipsec-secgw/Makefile b/examples/ipsec-secgw/Makefile
index da39e49..f9b59c2 100644
--- a/examples/ipsec-secgw/Makefile
+++ b/examples/ipsec-secgw/Makefile
@@ -42,6 +42,10 @@ APP = ipsec-secgw
 
 CFLAGS += -O3 -gdwarf-2
 CFLAGS += $(WERROR_FLAGS)
+ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
+CFLAGS_sa.o += -diag-disable=vec
+endif
+
 
 VPATH += $(SRCDIR)/librte_ipsec
 
diff --git a/examples/vmdq_dcb/Makefile b/examples/vmdq_dcb/Makefile
index 10a9a9a..8c51131 100644
--- a/examples/vmdq_dcb/Makefile
+++ b/examples/vmdq_dcb/Makefile
@@ -51,7 +51,9 @@ CFLAGS += $(WERROR_FLAGS)
 ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
 CFLAGS_main.o += -Wno-return-type
 endif
-
+ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
+CFLAGS_main.o += -diag-disable=vec
+endif
 EXTRA_CFLAGS += -O3 -g
 
 include $(RTE_SDK)/mk/rte.extapp.mk
-- 
2.5.5

Re: [dpdk-dev] [PATCH 2/2] examples: fix build errors for icc

[De Lara Guarch, Pablo]

Hi Daniel,

> -----Original Message-----
> From: Mrzyglod, DanielX T
> Sent: Monday, April 04, 2016 9:47 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing; De Lara Guarch, Pablo
> Subject: [PATCH 2/2] examples: fix build errors for icc
> 
> error: loops in this subroutine are not good vectorization candidates
>  (try compiling with O3 and/or IPO).
> 
> Solution to disable this diagnostic message
> https://software.intel.com/en-us/forums/intel-c-compiler/topic/537688
> 
> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
> Fixes: 8cc72f2814dd ("examples/vmdq_dcb: support X710")
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
 
Which ICC version are you using? I don't see any errors with ICC 15.0, so is it with 16.0?

Thanks,
Pablo

Re: [dpdk-dev] [PATCH 1/2] examples/l2fwd-crypto: fix for icc

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Mrzyglod, DanielX T
> Sent: Monday, April 04, 2016 9:47 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing; De Lara Guarch, Pablo
> Subject: [PATCH 1/2] examples/l2fwd-crypto: fix for icc
> 
> Fix for compilation errors for icc:
> error #188: enumerated type mixed with another type
> 
> Fixes: 00c58901f1b3 ("examples/l2fwd-crypto: use key-value list of
> supported algorithms")
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Re: [dpdk-dev] [PATCH 2/2] examples: fix build errors for icc

[Mrzyglod, DanielX T]

>From: De Lara Guarch, Pablo
>Sent: Monday, April 04, 2016 11:34 AM
>To: Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>; dev@dpdk.org
>Cc: Wu, Jingjing <jingjing.wu@intel.com>
>Subject: RE: [PATCH 2/2] examples: fix build errors for icc
>
>Hi Daniel,
>
>> -----Original Message-----
>> From: Mrzyglod, DanielX T
>> Sent: Monday, April 04, 2016 9:47 AM
>> To: dev@dpdk.org
>> Cc: Wu, Jingjing; De Lara Guarch, Pablo
>> Subject: [PATCH 2/2] examples: fix build errors for icc
>>
>> error: loops in this subroutine are not good vectorization candidates
>>  (try compiling with O3 and/or IPO).
>>
>> Solution to disable this diagnostic message
>> https://software.intel.com/en-us/forums/intel-c-compiler/topic/537688
>>
>> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
>> Fixes: 8cc72f2814dd ("examples/vmdq_dcb: support X710")
>>
>> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>
>Which ICC version are you using? I don't see any errors with ICC 15.0, so is it with
>16.0?

icc (ICC) 15.0.1 20141023
Copyright (C) 1985-2014 Intel Corporation.  All rights reserved.

When I did: make examples T=x86_64-native-linuxapp-icc
/mnt/shared/dtmrzglx/hubabuba/examples/vmdq_dcb/main.c(521): (col. 1) error: loops in this subroutine are not good vectorization candidates (try compiling with O3 and/or IPO).
compilation aborted for /mnt/shared/dtmrzglx/hubabuba/examples/vmdq_dcb/main.c (code 1)
/mnt/shared/dtmrzglx/hubabuba/mk/internal/rte.compile-pre.mk:126: recipe for target 'main.o' failed
make[4]: *** [main.o] Error 1
/mnt/shared/dtmrzglx/hubabuba/mk/rte.extapp.mk:42: recipe for target 'all' failed
make[3]: *** [all] Error 2
/mnt/shared/dtmrzglx/hubabuba/mk/rte.extsubdir.mk:46: recipe for target 'vmdq_dcb' failed
make[2]: *** [vmdq_dcb] Error 2
make[2]: *** Waiting for unfinished jobs....


/mnt/shared/dtmrzglx/hubabuba/examples/ipsec-secgw/sa.c(348): (col. 1) error: loops in this subroutine are not good vectorization candidates (try compiling with O3 and/or IPO).
compilation aborted for /mnt/shared/dtmrzglx/hubabuba/examples/ipsec-secgw/sa.c (code 1)
/mnt/shared/dtmrzglx/hubabuba/mk/internal/rte.compile-pre.mk:126: recipe for target 'sa.o' failed
make[4]: *** [sa.o] Error 1

Re: [dpdk-dev] [PATCH 2/2] examples: fix build errors for icc

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Mrzyglod, DanielX T
> Sent: Monday, April 04, 2016 10:38 AM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Cc: Wu, Jingjing
> Subject: RE: [PATCH 2/2] examples: fix build errors for icc
> 
> >From: De Lara Guarch, Pablo
> >Sent: Monday, April 04, 2016 11:34 AM
> >To: Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>; dev@dpdk.org
> >Cc: Wu, Jingjing <jingjing.wu@intel.com>
> >Subject: RE: [PATCH 2/2] examples: fix build errors for icc
> >
> >Hi Daniel,
> >
> >> -----Original Message-----
> >> From: Mrzyglod, DanielX T
> >> Sent: Monday, April 04, 2016 9:47 AM
> >> To: dev@dpdk.org
> >> Cc: Wu, Jingjing; De Lara Guarch, Pablo
> >> Subject: [PATCH 2/2] examples: fix build errors for icc
> >>
> >> error: loops in this subroutine are not good vectorization candidates
> >>  (try compiling with O3 and/or IPO).
> >>
> >> Solution to disable this diagnostic message
> >> https://software.intel.com/en-us/forums/intel-c-compiler/topic/537688
> >>
> >> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample
> application")
> >> Fixes: 8cc72f2814dd ("examples/vmdq_dcb: support X710")
> >>
> >> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> >
> >Which ICC version are you using? I don't see any errors with ICC 15.0, so is it
> with
> >16.0?

OK, I see that the problem is only in 15.0.1, but was fixed in 15.0.2 (my version).
Could you specify in the commit message the icc version that this patch is targeting?

Thanks,
Pablo
> 
> icc (ICC) 15.0.1 20141023
> Copyright (C) 1985-2014 Intel Corporation.  All rights reserved.
> 
> When I did: make examples T=x86_64-native-linuxapp-icc
> /mnt/shared/dtmrzglx/hubabuba/examples/vmdq_dcb/main.c(521): (col. 1)
> error: loops in this subroutine are not good vectorization candidates (try
> compiling with O3 and/or IPO).
> compilation aborted for
> /mnt/shared/dtmrzglx/hubabuba/examples/vmdq_dcb/main.c (code 1)
> /mnt/shared/dtmrzglx/hubabuba/mk/internal/rte.compile-pre.mk:126:
> recipe for target 'main.o' failed
> make[4]: *** [main.o] Error 1
> /mnt/shared/dtmrzglx/hubabuba/mk/rte.extapp.mk:42: recipe for target
> 'all' failed
> make[3]: *** [all] Error 2
> /mnt/shared/dtmrzglx/hubabuba/mk/rte.extsubdir.mk:46: recipe for target
> 'vmdq_dcb' failed
> make[2]: *** [vmdq_dcb] Error 2
> make[2]: *** Waiting for unfinished jobs....
> 
> 
> /mnt/shared/dtmrzglx/hubabuba/examples/ipsec-secgw/sa.c(348): (col. 1)
> error: loops in this subroutine are not good vectorization candidates (try
> compiling with O3 and/or IPO).
> compilation aborted for /mnt/shared/dtmrzglx/hubabuba/examples/ipsec-
> secgw/sa.c (code 1)
> /mnt/shared/dtmrzglx/hubabuba/mk/internal/rte.compile-pre.mk:126:
> recipe for target 'sa.o' failed
> make[4]: *** [sa.o] Error 1

[dpdk-dev] [PATCH v2] examples: fix build errors for icc

[Daniel Mrzyglod]

error: loops in this subroutine are not good vectorization candidates
 (try compiling with O3 and/or IPO).

this error occurs in icc 15.0.1

Solution to disable this diagnostic message
https://software.intel.com/en-us/forums/intel-c-compiler/topic/537688

Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
Fixes: 8cc72f2814dd ("examples/vmdq_dcb: support X710")

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
 examples/ipsec-secgw/Makefile | 4 ++++
 examples/vmdq_dcb/Makefile    | 4 +++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/examples/ipsec-secgw/Makefile b/examples/ipsec-secgw/Makefile
index da39e49..f9b59c2 100644
--- a/examples/ipsec-secgw/Makefile
+++ b/examples/ipsec-secgw/Makefile
@@ -42,6 +42,10 @@ APP = ipsec-secgw
 
 CFLAGS += -O3 -gdwarf-2
 CFLAGS += $(WERROR_FLAGS)
+ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
+CFLAGS_sa.o += -diag-disable=vec
+endif
+
 
 VPATH += $(SRCDIR)/librte_ipsec
 
diff --git a/examples/vmdq_dcb/Makefile b/examples/vmdq_dcb/Makefile
index 10a9a9a..8c51131 100644
--- a/examples/vmdq_dcb/Makefile
+++ b/examples/vmdq_dcb/Makefile
@@ -51,7 +51,9 @@ CFLAGS += $(WERROR_FLAGS)
 ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y)
 CFLAGS_main.o += -Wno-return-type
 endif
-
+ifeq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
+CFLAGS_main.o += -diag-disable=vec
+endif
 EXTRA_CFLAGS += -O3 -g
 
 include $(RTE_SDK)/mk/rte.extapp.mk
-- 
2.5.5

Re: [dpdk-dev] [PATCH 0/2] fixes for icc build errors

[Thomas Monjalon]

2016-04-04 10:46, Daniel Mrzyglod:
> This series of patches is to solve errors for Intel C Compiler 
> 
> Daniel Mrzyglod (2):
>   examples/l2fwd-crypto: fix for icc
>   examples: fix build errors for icc

Applied with precision about icc 15.0.1, thanks