From: Thomas Monjalon <thomas@monjalon.net>
To: Josh Soref <jsoref@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/1] fix spelling in code
Date: Wed, 12 Jan 2022 12:46:45 +0100 [thread overview]
Message-ID: <1840746.IobQ9Gjlxr@thomas> (raw)
In-Reply-To: <20220112072808.59713-2-jsoref@gmail.com>
12/01/2022 08:28, Josh Soref:
> Some additional comment fixes...
They are not only comments, some are functions or struct fields.
> The tool comes from https://github.com/jsoref
It requires some reviews. I started to review below.
> -cpt_lfs_alloc(struct dev *dev, uint8_t eng_grpmsk, uint8_t blkaddr,
> +cpt_lfs_alloc(struct dev *dev, uint8_t eng_grpmask, uint8_t blkaddr,
grpmsk is shorter and understandable.
Adding some letters is not a fix in this case.
> -cnstr_shdsc_authenc(uint32_t *descbuf, bool ps, bool swap,
> +cnstr_shdsc_authentic(uint32_t *descbuf, bool ps, bool swap,
That's a wrong change: authenc means authentication + encryption.
> -#define COMPRESSDEV_NAME_ZIP_PMD compress_octeonx
> +#define COMPRESSDEV_NAME_ZIP_PMD compress_octeontx
Good catch! I wonder how your tool finds it.
> - comp_dev->interm_buff_mz =
> + comp_dev->interim_buff_mz =
Not sure about this one.
> - UPDATE_STAT64(rx_stat_grxpf, rx_stat_xoffstateentered);
> + UPDATE_STAT64(rx_stat_grxpf, rx_stat_xoffsetateentered);
Looks wrong.
> - * inner_ofst: If zero, this is an outer header. If non-zero, this is
> + * inner_offset: If zero, this is an outer header. If non-zero, this is
I would not change this to respect how the author shortened it.
> @@ -106,7 +106,7 @@ typedef struct VhostUserCryptoSessionParam {
> uint8_t dir;
> uint8_t hash_mode;
> uint8_t chaining_dir;
> - uint8_t *ciphe_key;
> + uint8_t *cipher_key;
> uint8_t *auth_key;
> uint8_t cipher_key_buf[VHOST_USER_CRYPTO_MAX_CIPHER_KEY_LENGTH];
> uint8_t auth_key_buf[VHOST_USER_CRYPTO_MAX_HMAC_KEY_LENGTH];
It looks to be unused. Is it an API change?
next prev parent reply other threads:[~2022-01-12 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 7:28 [PATCH 0/1] Spelling code fixes* Josh Soref
2022-01-12 7:28 ` [PATCH 1/1] fix spelling in code Josh Soref
2022-01-12 11:46 ` Thomas Monjalon [this message]
2022-01-12 11:49 ` [PATCH 0/1] Spelling code fixes* Thomas Monjalon
2022-01-12 12:48 ` Josh Soref
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1840746.IobQ9Gjlxr@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jsoref@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).