From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F87BA034D; Wed, 12 Jan 2022 12:46:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A6AF426F6; Wed, 12 Jan 2022 12:46:53 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id DBFBD40040 for ; Wed, 12 Jan 2022 12:46:50 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 79F833201D9C; Wed, 12 Jan 2022 06:46:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 12 Jan 2022 06:46:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= pMb9LlliaM0OOJMmM1pLKBB4xQkbk6FP8CgS0Bb+nQE=; b=RGqQzQvu9TittSzU NCykLo7ZqGIiMwyzqeO8QAAkXDUw9FoQ4s7AmtIqvqLSQKaxxP9O+VVdeVxcmPz4 AekyrqiHsc733B2W8lTFub9IvPfkYOtvrthAGfJTdkNu5ET9RVkmzGK2k17BkWzf NJolDL0vCfTO/hsn41qN9tGG8QSLK/WlFYd7KeDduQgHSDhGG2xDrvmQScWtOuf4 9YAOFOfK2xiFjpVnxtbTkfe/UJ/9jqR1Ped62++r0PD3Ox4btFGRZ+Rm46eCxAdD KVwVTfzOZjM+Ev7iAEZsTERJuolvuc5rpBhDcnc2Sb5v6YexHEhV3RDehFcLv+R7 733rDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=pMb9LlliaM0OOJMmM1pLKBB4xQkbk6FP8CgS0Bb+n QE=; b=Kegfpb1RVKR4adJ9zH+mbiGg9R3JPFIvh1iZy1jcUwgw6HdLg3gEkpET1 jl7ho2tVsawRGJiP46cWEIJEXoMO3jqOwV9npZuJqXzZWJNtuJHHolhZd2xZyLKp SzVFKccjkZlxXyAL8Or+Tnr+LdcSUTz85qSOkY4GPNU9gk5cPwAF0CqUfzhJnEkL I+PefexYKA/4WN79YQzKgRtUg9me6v+Ge65jCWt9MkfugR1HMWg/graiwjDRyYDC i31RtI7+FPYpfrWzCJ99raTqjMGHH6G7vAd+eBQi14i/onFy/ETLuMnqFpke9zj0 MStfSu6lYStm0rYTn4+3G/XtKQE8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrtddugddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeegjeffhffhgefhteevffegffetleevkefhgffhfeegvdelueevteff gfduleevhfenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Jan 2022 06:46:48 -0500 (EST) From: Thomas Monjalon To: Josh Soref Cc: dev@dpdk.org Subject: Re: [PATCH 1/1] fix spelling in code Date: Wed, 12 Jan 2022 12:46:45 +0100 Message-ID: <1840746.IobQ9Gjlxr@thomas> In-Reply-To: <20220112072808.59713-2-jsoref@gmail.com> References: <20220112072808.59713-1-jsoref@gmail.com> <20220112072808.59713-2-jsoref@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/01/2022 08:28, Josh Soref: > Some additional comment fixes... They are not only comments, some are functions or struct fields. > The tool comes from https://github.com/jsoref It requires some reviews. I started to review below. > -cpt_lfs_alloc(struct dev *dev, uint8_t eng_grpmsk, uint8_t blkaddr, > +cpt_lfs_alloc(struct dev *dev, uint8_t eng_grpmask, uint8_t blkaddr, grpmsk is shorter and understandable. Adding some letters is not a fix in this case. > -cnstr_shdsc_authenc(uint32_t *descbuf, bool ps, bool swap, > +cnstr_shdsc_authentic(uint32_t *descbuf, bool ps, bool swap, That's a wrong change: authenc means authentication + encryption. > -#define COMPRESSDEV_NAME_ZIP_PMD compress_octeonx > +#define COMPRESSDEV_NAME_ZIP_PMD compress_octeontx Good catch! I wonder how your tool finds it. > - comp_dev->interm_buff_mz = > + comp_dev->interim_buff_mz = Not sure about this one. > - UPDATE_STAT64(rx_stat_grxpf, rx_stat_xoffstateentered); > + UPDATE_STAT64(rx_stat_grxpf, rx_stat_xoffsetateentered); Looks wrong. > - * inner_ofst: If zero, this is an outer header. If non-zero, this is > + * inner_offset: If zero, this is an outer header. If non-zero, this is I would not change this to respect how the author shortened it. > @@ -106,7 +106,7 @@ typedef struct VhostUserCryptoSessionParam { > uint8_t dir; > uint8_t hash_mode; > uint8_t chaining_dir; > - uint8_t *ciphe_key; > + uint8_t *cipher_key; > uint8_t *auth_key; > uint8_t cipher_key_buf[VHOST_USER_CRYPTO_MAX_CIPHER_KEY_LENGTH]; > uint8_t auth_key_buf[VHOST_USER_CRYPTO_MAX_HMAC_KEY_LENGTH]; It looks to be unused. Is it an API change?