From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 17AA62BBE for ; Sun, 9 Jul 2017 22:22:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 942692079D; Sun, 9 Jul 2017 16:22:51 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sun, 09 Jul 2017 16:22:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=ALheduWH8LtfS9t rm/eDjlgPaEZn3jhGH4ryksTdYys=; b=bsT/ZvoqO1NZw734ica605f0HefwsQu x6TWuoS14t9izEpZdARh6S1dALsAon7Es5P5KitNfqKP02PCUUaM/9vuWknv4MB3 mtK/VtCLbUBwF5rVkovjrkOkiW55B+N/yvCTIMSXog2QMvXAemtXkubabZ4+QZWY WV3r3Z0N4nXM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=ALheduWH8LtfS9trm/eDjlgPaEZn3jhGH4ryksTdYys=; b=j29rzRaT GtTWJI/i5vd2Si/aTePjlnsCfK4JVF6KGpL7p1G99ZZ6+dabRZU4qP+xmS3jvhQX rr0RLUhaWpXM7WcCbPf0pEkkV+wdjsA3O8vl1DIo05+OTnJi6w9cp/+5i2Scd7Kf /b55cu4/o6H0CGbljB8gbTclDerO3djKiYbcWkR/prB34VcOV/XASv9z6KursqVS x0CDrbJBeihSCFZQxrLf8WxJvNuhuvIcK3PHuTEBXk+KKPB3/fuQHzHYW//EZvLt BxzXVqnspjS1jcjGm0osr0OMKwJv0G7bDGOvD/JpxazW2MdPWAofe7Ro9hmWwcxF eTsxgbJbuBO3dw== X-ME-Sender: X-Sasl-enc: WY4anSMSvYqe28hvj/e03w5IzaTI47EZr1z1epyAQ+Rq 1499631771 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 409B17E71B; Sun, 9 Jul 2017 16:22:51 -0400 (EDT) From: Thomas Monjalon To: Tom Barbette Cc: dev@dpdk.org, "Mcnamara, John" Date: Sun, 09 Jul 2017 22:22:50 +0200 Message-ID: <1841065.2mqPad39Ri@xps> In-Reply-To: References: <20170705135944.20655-1-tom.barbette@ulg.ac.be> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ethernet api: Document rte_eth_vmdq_rx_conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 20:22:52 -0000 06/07/2017 10:29, Mcnamara, John: > From: Tom Barbette [mailto:tom.barbette@ulg.ac.be] > > > > From documentation it is very unclear how VMDq configuration can be > > tweaked, and online search offer very poor results. > > > > This patch will ultimately spawn an online documentation page for the > > rte_eth_vmdq_rx_conf struct which will eventually add a bit of > > documentation about the rx_mode tag and how to allow e.g. VMDq pools to > > receive packets without VLAN tags. > > > > Signed-off-by: Tom Barbette > > Hi Tom, > > Thanks for that. One minor, non-blocking, thing for future reference. The > subject line should be lowercase apart from acronyms. The maintainer > should be able to make that change when then apply the patch. This is just > for future reference. New title: ethdev: document VMDq Rx configuration > If there is any other missing documentation that you would care to add > then please do. :-) > > Acked-by: John McNamara Applied, thanks