From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f182.google.com (mail-we0-f182.google.com
 [74.125.82.182]) by dpdk.org (Postfix) with ESMTP id AC59D959
 for <dev@dpdk.org>; Tue, 24 Feb 2015 00:52:02 +0100 (CET)
Received: by wesk11 with SMTP id k11so21925281wes.11
 for <dev@dpdk.org>; Mon, 23 Feb 2015 15:52:02 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=CHA3k61JpHru6PNv2YZ+mDSmckrK6QazXf3avuZLpLo=;
 b=IWNvmNsnrw1+Jn/522vGtahuwv6lTmjgR+yXu81WIr7TpnKo3CwqOYJJyYUTK4QE1v
 3he0Am31Wli3h7QHzkGIe6WxmivR7K7jfDt47SxESKcEcXUL31CFVUtvQ8EzMCCYpmeK
 6DWWL37Lg1qxFhhfbaXbt3o+IE7GQm6Gfdiip/skuC9aCDynt4nSlPYBbPDgAsgOB+OJ
 Tn21qJFyJz6V4pCZw/yTg3elFzzMXK6mt4zP0TM7ikkDqVvXXDMS0XCbXKnbYkWlWYUn
 aSthwAn/pkizye0mvoL1A2gZe9aTqMGJsPCsY91oPXYTXYeVBB/7O9iOjREqr7wFEURb
 8d6Q==
X-Gm-Message-State: ALoCoQmPjHqOP0Pjl1q2VMDQTw2xieXRs50oEAP7kfkcofnW3FnYhzw3stAtw7i4wXXRghdBdcOU
X-Received: by 10.180.79.232 with SMTP id m8mr25700136wix.81.1424735522489;
 Mon, 23 Feb 2015 15:52:02 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id kj8sm57684730wjc.29.2015.02.23.15.52.01
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 23 Feb 2015 15:52:01 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 24 Feb 2015 00:51:31 +0100
Message-ID: <1841373.vEVYaVjUlG@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <20150205124330.GB28355@hmsreliant.think-freely.org>
References: <1423116841-19799-4-git-send-email-stephen@networkplumber.org>
 <20150205124330.GB28355@hmsreliant.think-freely.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org, Stephen Hemminger <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH v2 4/7] rte_sched: don't clear statistics
	when read
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Feb 2015 23:52:03 -0000

2015-02-05 07:43, Neil Horman:
> On Wed, Feb 04, 2015 at 10:13:58PM -0800, Stephen Hemminger wrote:
> > +
> > +/**
> > + * Hierarchical scheduler subport statistics reset
> > + *
> > + * @param port
> > + *   Handle to port scheduler instance
> > + * @param subport_id
> > + *   Subport ID
> > + * @return
> > + *   0 upon success, error code otherwise
> > + */
> > +int
> > +rte_sched_subport_stats_reset(struct rte_sched_port *port,
> > +			      uint32_t subport_id);
> > +
> >  /**
> >   * Hierarchical scheduler queue statistics read
> >   *
> > @@ -338,6 +353,20 @@ rte_sched_queue_read_stats(struct rte_sched_port *port,
> >  	struct rte_sched_queue_stats *stats,
> >  	uint16_t *qlen);
> >  
> > +/**
> > + * Hierarchical scheduler queue statistics reset
> > + *
> > + * @param port
> > + *   Handle to port scheduler instance
> > + * @param queue_id
> > + *   Queue ID within port scheduler
> > + * @return
> > + *   0 upon success, error code otherwise
> > + */
> > +int
> > +rte_sched_queue_stats_reset(struct rte_sched_port *port,
> > +			    uint32_t queue_id);
> > +
> Both need to be added to the version map to expose them properly.
> Neil

Stephen, this patchset is partially acked and could enter in 2.0.0-rc1.
May you send a v3 addressing comments? Or should I break the serie by
applying only some of them? Or postpone the serie to 2.1?