From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58FFDA00C5; Sun, 5 Jul 2020 22:00:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B7271DA47; Sun, 5 Jul 2020 22:00:23 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 562E41DA45 for ; Sun, 5 Jul 2020 22:00:22 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 9E54158040C; Sun, 5 Jul 2020 16:00:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 05 Jul 2020 16:00:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= TpQApRQMXZJX5inIB5klXtkyL8/BsLuvkIPuDqopLyk=; b=R/bR0ZNqp4SsuJFM Uh2iMBhdE8YvXUIzmtxC1/HNVzJr7+0Ovf6a9H9Tv7i1GVuaETP2Xj4SvQAmDkZ1 ArSXc5Qc7oy7oqxKrh3V/zUe5rIunwhWdAzFny3jn5I9UH8nZ2Px0TNF50G68lcZ 8GlT9y1tcPDblAUQe/AbjR9LRRMfkpzzThvfJzLV4kao5DNaJR/HG7a/F8a0Ylqh wkq+MqwSPPw8e/9oaMFDBP4fyQ37lHId80aFxUjLxtB3wKBMZzW11jVlbESS71fh mB3gIGER19s9Xt1z/nSfOPrbYk8LOjl8/g/tsT7Obo8OQu4eMKfHJIJHh7obQ5sw ySSZCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=TpQApRQMXZJX5inIB5klXtkyL8/BsLuvkIPuDqopL yk=; b=BHiKi/QI/91g7y8lKfrk8iM6l83zDnDPjiSGLD6F1aP6qCW+WDvin74iS CRZvLGAYJEVvhl+nZvVvNL6HZEAgXO3a5CTKhS03y0es8DBRvlv+LciNtSjaSRWZ Er515E5/APDiUdVnDZHd8+ADb+pYHocvUQgR5BaQL7UVkSr+nym27TqQnn51AJtF Bs79mdFkNVKviNpWva3ZSgQeRVAfZ3pAfVfBDepxqmj90oUC/wynX1/RoXjX4e5W Qph9xqcon0O6fsJlgB/ss3wwPEja1uwEGCJ1YiiaWg7WRsSe0pT5HXWZVggaC1+f 0Aj2aXjumvXjouB3QKagUqCDJ7CwA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedruddugddugeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepieelkeduvdekhedtiedvudefveefgeevffehjeefhfdttddtjefh leegtdelgedtnecuffhomhgrihhnpehmvghsohhnrdgsuhhilhgunecukfhppeejjedrud efgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2AA19328005D; Sun, 5 Jul 2020 16:00:19 -0400 (EDT) From: Thomas Monjalon To: "Kinsella, Ray" , Fady Bader Cc: dev@dpdk.org, "dev@dpdk.org" , Tasnim Bashar , Tal Shnaiderman , Yohad Tor , "dmitry.kozliuk@gmail.com" , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" , "pallavi.kadam@intel.com" , "ranjit.menon@intel.com" , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "nhorman@tuxdriver.com" Date: Sun, 05 Jul 2020 22:00:18 +0200 Message-ID: <1842931.9hOUdKzN8j@thomas> In-Reply-To: <29324685.utGxs7hIzm@thomas> References: <'20200531124151.16848-2-fady@mellanox.com'> <29324685.utGxs7hIzm@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/07/2020 11:00, Thomas Monjalon: > 05/07/2020 10:51, Fady Bader: > > From: Thomas Monjalon > > > 05/07/2020 09:00, Fady Bader: > > > > > On 30/06/2020 11:49, Kinsella, Ray wrote: > > > > > > On 22/06/2020 12:55, Fady Bader wrote: > > > > > >> --- a/lib/librte_eal/include/rte_function_versioning.h > > > > > >> +++ b/lib/librte_eal/include/rte_function_versioning.h > > > > > >> @@ -11,6 +11,10 @@ > > > > > >> #error Use of function versioning disabled, is > > > "use_function_versioning=true" > > > > > in meson.build? > > > > > > Do we need a meson error/rule that catches if people explicitly > > > > > > try to enable > > > > > function_versioning. > > > > > > We don't want to just silently fail under such circumstances? > > > > > > > > > > > > Would something in lib/meson.build would work better? > > > > > > > > > > > > if use_function_versioning and target_machine.system == "Windows" > > > > > > // complain loudly ... > > > > > > endif > > > > > > > > > > > > > > I think this would be a better approach. > > > > But instead of checking if the use of function versioning is enabled > > > > under Windows and then complain, I think we should simply disable it > > > > from Windows in the meson.build file. Something like this: > > > > > > > > if target_machine.system == "Windows" > > > > use_function_versioning = false > > > > endif > > > > > > Did you try? > > > > > > If you disable function versioning, compilation will fail with the #error message > > > above, right? > > > > > > > Yes, the compilation fails, we can also change the rte_function_versioning.h > > code in order not to fail under Windows. > > What do you think ? > > Function versioning CANNOT be supported currently on Windows. > Function versioning macros are MANDATORY in some libraries. > That's why I think the only path is to have a specific > implementation of the function versioning macros for Windows. After a closer look with Fady, the empty macros already exist for the static case. If disabling function versioning in shared case, the DLL is built with the object files compiled for the static library. Conclusion: disabling function versioning on Windows works (after disabling the error message).