From: Thomas Monjalon <thomas@monjalon.net>
To: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
Cc: dev@dpdk.org, Andy Green <andy@warmcat.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison
Date: Tue, 15 May 2018 16:46:05 +0200 [thread overview]
Message-ID: <1846600.PKkdRNXVvt@xps> (raw)
In-Reply-To: <MWHPR0701MB36754015E3641B299543FF439F9C0@MWHPR0701MB3675.namprd07.prod.outlook.com>
15/05/2018 00:16, Mody, Rasesh:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
> > Sent: Sunday, May 13, 2018 10:05 PM
> >
> > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:
> > In function ‘elink_check_kr2_wa’:
> > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28:
> > error: bitwise comparison always evaluates to false [-Werror=tautological-
> > compare]
> > ((next_page & 0xe0) == 0x2))));
> >
> > This was fixed elsewhere in 2014
> >
> > Signed-off-by: Andy Green <andy@warmcat.com>
> > Fixes: b5bf7719221d ("bnx2x: driver support routines")
> > Cc: stable@dpdk.org
> > ---
>
> Acked-by: Rasesh Mody <rasesh.mody@cavium.com>
I would appreciate a review of the 2 other bnx2x patches in this series, please.
next prev parent reply other threads:[~2018-05-15 14:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 1:51 [dpdk-dev] [PATCH v2 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Andy Green
2018-05-12 1:51 ` [dpdk-dev] [PATCH v2 1/4] net/bnx2x: do not cast function pointers as a policy Andy Green
2018-05-12 1:51 ` [dpdk-dev] [PATCH v2 2/4] net/bnx2x: correct unmeetable comparison Andy Green
2018-05-12 1:51 ` [dpdk-dev] [PATCH v2 3/4] net/mlx5: solve var may be used uninitialized Andy Green
2018-05-12 1:51 ` [dpdk-dev] [PATCH v2 4/4] net/bnx2x: solve overruns Andy Green
2018-05-14 5:04 ` [dpdk-dev] [PATCH v3 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Andy Green
2018-05-14 5:04 ` [dpdk-dev] [PATCH v3 1/4] net/bnx2x: do not cast function pointers as a policy Andy Green
2018-05-15 19:47 ` Mody, Rasesh
2018-05-14 5:04 ` [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable comparison Andy Green
2018-05-14 11:17 ` Ferruh Yigit
2018-05-14 22:17 ` Mody, Rasesh
2018-05-14 22:16 ` Mody, Rasesh
2018-05-15 14:46 ` Thomas Monjalon [this message]
2018-05-15 19:52 ` Mody, Rasesh
2018-05-14 5:04 ` [dpdk-dev] [PATCH v3 3/4] net/mlx5: solve var may be used uninitialized Andy Green
2018-05-15 17:25 ` Yongseok Koh
2018-05-14 5:04 ` [dpdk-dev] [PATCH v3 4/4] net/bnx2x: solve overruns Andy Green
2018-05-15 19:47 ` Mody, Rasesh
2018-05-15 20:30 ` [dpdk-dev] [PATCH v3 0/4] GCC8 fixes for MLX4/5/BNX2X PMD Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1846600.PKkdRNXVvt@xps \
--to=thomas@monjalon.net \
--cc=Rasesh.Mody@cavium.com \
--cc=andy@warmcat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).