From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id AC2671B820
 for <dev@dpdk.org>; Tue, 15 May 2018 16:46:07 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 348052205D;
 Tue, 15 May 2018 10:46:07 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 15 May 2018 10:46:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=lIVSvxKvf+kn9idxscGBaImJqu
 /Q2YrBZEFz79RnqWI=; b=s2QDiXClMTUvkPkP9yQdGAnV5YP07fRLQ36nKDLFPG
 V+MLc+4XZKiaruJqN/0cue210ILBhvvRD3Czz8Lw2bZMEMSIo3uzP+pdLFG9F7KW
 w6TIjVQCb++l3n61g1EzpRbb/8vNjmZ2fdfMmhlDXQoSxFZjLv1oW+g9kNTjX1TL
 Q=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=lIVSvx
 Kvf+kn9idxscGBaImJqu/Q2YrBZEFz79RnqWI=; b=IXndfS7WLcynr7WTLV/Grf
 xTzaRMzQqQR7fCt+1oEbBlTtZHU0+cTbaLhGHzxKA5SQabgonIxrjhfJtGR6zXgP
 z+nwNSGjXDknI3ygzBo6c/O439lQAhN0epKqx/3hTWtrksQsLcqNJmsl9DPYHf2t
 I/RqvOwQoG0iX86+535aKRQTzi+O8oTULLe20QrpKUdFGmg9b+7um3k1fVyo/8gx
 gX8P/9tCkyUp0PIXwyHRqn3RYSMQXP0hiop93N+U+0NLMzw/h8lW5/zxzWEoiv7D
 4TlkiTgmSNN7DKEsMizySU7TOBj+7at68rB7dPXWG9cDg1DQ+QEl7Gp+58IKMPDQ
 ==
X-ME-Sender: <xms:r_L6WlEu7Nx3L82gU2xJBoPQ2oSC5UWHneH4QcE_q0fs_iJo9vuVmw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 821EAE4854;
 Tue, 15 May 2018 10:46:06 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
Cc: dev@dpdk.org, Andy Green <andy@warmcat.com>
Date: Tue, 15 May 2018 16:46:05 +0200
Message-ID: <1846600.PKkdRNXVvt@xps>
In-Reply-To: <MWHPR0701MB36754015E3641B299543FF439F9C0@MWHPR0701MB3675.namprd07.prod.outlook.com>
References: <152627420173.53058.13179290989817984940.stgit@localhost.localdomain>
 <152627427362.53058.5993339273922161219.stgit@localhost.localdomain>
 <MWHPR0701MB36754015E3641B299543FF439F9C0@MWHPR0701MB3675.namprd07.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3 2/4] net/bnx2x: correct unmeetable
	comparison
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 15 May 2018 14:46:07 -0000

15/05/2018 00:16, Mody, Rasesh:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
> > Sent: Sunday, May 13, 2018 10:05 PM
> >=20
> > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:
> > In function =E2=80=98elink_check_kr2_wa=E2=80=99:
> > /home/agreen/projects/dpdk/drivers/net/bnx2x/elink.c:12922:28:
> > error: bitwise comparison always evaluates to false [-Werror=3Dtautolog=
ical-
> > compare]
> >         ((next_page & 0xe0) =3D=3D 0x2))));
> >=20
> > This was fixed elsewhere in 2014
> >=20
> > Signed-off-by: Andy Green <andy@warmcat.com>
> > Fixes: b5bf7719221d ("bnx2x: driver support routines")
> > Cc: stable@dpdk.org
> > ---
>=20
> Acked-by: Rasesh Mody <rasesh.mody@cavium.com>

I would appreciate a review of the 2 other bnx2x patches in this series, pl=
ease.