From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D14E7A0096 for <public@inbox.dpdk.org>; Wed, 5 Jun 2019 11:37:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A1D571BA9A; Wed, 5 Jun 2019 11:37:39 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id D00C61BA59 for <dev@dpdk.org>; Wed, 5 Jun 2019 11:37:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 71809588; Wed, 5 Jun 2019 05:37:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 05 Jun 2019 05:37:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rdm2M+z8WOLhXi6NnaKfDRdzBIzWgNRuWROLRWsMBCU=; b=iVNfv3RCFjds DdJHkjDS6FV3vnt6rWjjLAdfYyAkXP3BupaB25TWxmLxYoip/5mZzaSnaRUo9DBg +CEhc6x7N1eqP8yEYBuhYy5s7zkBaZB2flgNh42LC0yq8Zqa9LZBwjiwihUcAT7y pcOSai4OInXNxtgddUttPcuRB5UAXco= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=rdm2M+z8WOLhXi6NnaKfDRdzBIzWgNRuWROLRWsMB CU=; b=L85zbHq1a85zMisvbNqfiIAbpyC+1EENdbynTAPZA2BFtFBBXavRuMCty 6ZeXp/dDM67lZz5XWaBW1VAW1thA2O2eIegsqqq+0tAHQ/XqIisMf5zAk8LcFlEw 0ypNqhAazWHuC4eNFflCKSgfK4QxrsvHtC2RO/3XegJHMlFh7W2BCW5svQ3vRin0 BCIeca23iuTUUyrYBcSGqpZpiZYOXUbWeQD1PcEfjA++vX8aMuD1al9ETe/VQkn4 ehd5dDRV2GGPtefGcPFkj4Cph1zh35rdqLDFI0XfAWl5TJ3UakJz+3GfDgLx1h+Y U4xxtjphr79/84L2JOwOeEXki5IuQ== X-ME-Sender: <xms:YI33XEPZ3jK6sxMSaxwGsf0LDeKEolotfpTJ_7vhwVTk85uvLrMJjg> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudegvddgudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:YI33XPOo_eRr-67dTcc3a_Q1MRWS7Lgb6IApSzi2BQZ6ISi9qLi_Rw> <xmx:YI33XGQueqEPbo_CwXaP1kQLKxlz1TwhIlALjwoVn60AtdwScL6BRA> <xmx:YI33XBCi4hGF6YzlNzgl7JBW1SRjUODmLPGW3B8hczwvg0jH3QA00w> <xmx:YY33XA_Oq8qG2KmE5IHIhh4x--9w7wlILC8WpZsftS6IOgWkc25x2w> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D4841380089; Wed, 5 Jun 2019 05:37:35 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: bruce.richardson@intel.com, konstantin.ananyev@intel.com, adrien.mazarguil@6wind.com Cc: dev@dpdk.org, Marcin Smoczynski <marcinx.smoczynski@intel.com> Date: Wed, 05 Jun 2019 11:37:34 +0200 Message-ID: <1847238.2vmrsgWslk@xps> In-Reply-To: <20190514140416.4192-2-marcinx.smoczynski@intel.com> References: <20190514140416.4192-1-marcinx.smoczynski@intel.com> <20190514140416.4192-2-marcinx.smoczynski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Marcin, please remind to use --in-reply-to to have next versions in the same thread. Thanks Bruce, Konstantin, Adrien, any opinion about this patch? 14/05/2019 16:04, Marcin Smoczynski: > When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro > explicitly in its build recipe, it restricts visibility of a non POSIX > features subset, such as IANA protocol numbers (IPPROTO_* macros). > Non standard features are enabled by default for DPDK both for Linux > thanks to _GNU_SOURCE and for FreeBSD thanks to __BSD_VISIBLE. However > using XOPEN_SOURCE or POSIX_(C_)SOURCE in a component causes > __BSD_VISIBLE to be defined to 0 for FreeBSD, causing different feature > sets visibility for Linux and FreeBSD. It restricts from using IPPROTO > macros in public headers, such as rte_ip.h, despite the fact they are > already widely used in sources. > > Add __BSD_VISIBLE macro specified unconditionally for FreeBSD targets > which enforces feature sets visibility unification between Linux and > FreeBSD. > > Add single -D_GNU_SOURCE to config/meson.build as a project argument > instead of adding separate directive for each project subtree. > > This patch solves the problem of build breaks for [1] on FreeBSD [2] > following the discussion [3]. > > [1] https://mails.dpdk.org/archives/dev/2019-May/131885.html > [2] http://mails.dpdk.org/archives/test-report/2019-May/082263.html > [3] https://mails.dpdk.org/archives/dev/2019-May/132110.html > > Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>