From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by dpdk.org (Postfix) with ESMTP id 3CEE81B474 for ; Tue, 16 Apr 2019 10:09:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.west.internal (Postfix) with ESMTP id 09075500; Tue, 16 Apr 2019 04:09:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 16 Apr 2019 04:09:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=1/uoUelzRfcic9rfMj+pqFhsk7IGEHRAhhobm4Ji7pw=; b=aWAGOSSJMtbz En+nhVgVIWJJlPh9bSa4h2mufEAalsdeEUxAEpisF/zdKNq/9qn/iYYgvLx0rcgd 4njg8irMkgGjYwEvXcEz7V4mkijbNVowiBh9fQHpXoFpVlBycp9sPMt7eglP2Gsc h/4ewh7WA2ZNQ1w+QPV2KkWFYTMvzU8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=1/uoUelzRfcic9rfMj+pqFhsk7IGEHRAhhobm4Ji7 pw=; b=hSFmB0eK63ZvcuGZnOnPPV/J/MXjkn24UqWY3W9bk4BQQbzR07jtUs5A8 HsQ9CYu8BKA+PsqKTymuC+esvV3rWLMdqvII2mHzylPqvUqy8mnI+3L61DGn0yKh +CG7ki64ZJ3TFUUxoOGMkMzv5QAGHXEdwulHYIIuudY/X3AomYewXMiRJa/J9gBc BZT7TAbLvRvbVgyDzMj7yOO/aATf78874K5rC2ArLbfQJOA6ZMUFBO4fQ2Vk2Uhi Y7b8yt+Q3bBeU9q6IPlhXTK2jAqOo8voaBgOcuro62mQNqnlg235dp1589kzzLYU y9vvpkp6VaDZByKSR0a7bY2pc3ffw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfedugddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 43A04E407B; Tue, 16 Apr 2019 04:09:46 -0400 (EDT) From: Thomas Monjalon To: "Xu, Rosen" Cc: "Yigit, Ferruh" , "dev@dpdk.org" , "Zhang, Tianfei" , "Wei, Dan" , "Pei, Andy" , "Yang, Qiming" , "Wang, Haiyue" , "Chen, Santos" , "Zhang, Zhang" , "Lomartire, David" , "Hu, Jia" Date: Tue, 16 Apr 2019 10:09:43 +0200 Message-ID: <1849278.EChBP1P422@xps> In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A6AF7CE@SHSMSX104.ccr.corp.intel.com> References: <1551338000-120348-1-git-send-email-rosen.xu@intel.com> <4035e454-c105-9a01-c1c9-e9ba343a69e3@intel.com> <0E78D399C70DA940A335608C6ED296D73A6AF7CE@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 02/14] bus/ifpga: add function for AFU search by name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2019 08:09:51 -0000 16/04/2019 04:50, Xu, Rosen: > From: Yigit, Ferruh > > > --- a/drivers/bus/ifpga/rte_bus_ifpga.h > > > +++ b/drivers/bus/ifpga/rte_bus_ifpga.h > > > @@ -120,6 +120,15 @@ struct rte_afu_driver { } > > > > > > /** > > > + * Find AFU by AFU name. > > > + * > > > + * @param name > > > + * A pointer to AFU name string. > > > + */ > > > +struct rte_afu_device *__rte_experimental > > > +rte_ifpga_find_afu_by_name(const char *name); > > > + > > > > > > Hi Rosen, > > > > This is the bus code, and only drivers will call it right? I think there is no > > intention to make this run by application code, the functions need to be > > exported because driver and bus are different libraries. > > If above correct, there is no point of making the function experimental, can > > drop the __rte_experimental tag, and update .map file to not use > > EXPERIMENTAL. > > Hi Ferruh, > > Just double confirm with you, if I follow this modification, there is one checkpatch error. This is a warning, and Ferruh allows it in this case :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B5A89A00E6 for ; Tue, 16 Apr 2019 10:09:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D9991B476; Tue, 16 Apr 2019 10:09:52 +0200 (CEST) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by dpdk.org (Postfix) with ESMTP id 3CEE81B474 for ; Tue, 16 Apr 2019 10:09:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.west.internal (Postfix) with ESMTP id 09075500; Tue, 16 Apr 2019 04:09:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 16 Apr 2019 04:09:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=1/uoUelzRfcic9rfMj+pqFhsk7IGEHRAhhobm4Ji7pw=; b=aWAGOSSJMtbz En+nhVgVIWJJlPh9bSa4h2mufEAalsdeEUxAEpisF/zdKNq/9qn/iYYgvLx0rcgd 4njg8irMkgGjYwEvXcEz7V4mkijbNVowiBh9fQHpXoFpVlBycp9sPMt7eglP2Gsc h/4ewh7WA2ZNQ1w+QPV2KkWFYTMvzU8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=1/uoUelzRfcic9rfMj+pqFhsk7IGEHRAhhobm4Ji7 pw=; b=hSFmB0eK63ZvcuGZnOnPPV/J/MXjkn24UqWY3W9bk4BQQbzR07jtUs5A8 HsQ9CYu8BKA+PsqKTymuC+esvV3rWLMdqvII2mHzylPqvUqy8mnI+3L61DGn0yKh +CG7ki64ZJ3TFUUxoOGMkMzv5QAGHXEdwulHYIIuudY/X3AomYewXMiRJa/J9gBc BZT7TAbLvRvbVgyDzMj7yOO/aATf78874K5rC2ArLbfQJOA6ZMUFBO4fQ2Vk2Uhi Y7b8yt+Q3bBeU9q6IPlhXTK2jAqOo8voaBgOcuro62mQNqnlg235dp1589kzzLYU y9vvpkp6VaDZByKSR0a7bY2pc3ffw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfedugddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 43A04E407B; Tue, 16 Apr 2019 04:09:46 -0400 (EDT) From: Thomas Monjalon To: "Xu, Rosen" Cc: "Yigit, Ferruh" , "dev@dpdk.org" , "Zhang, Tianfei" , "Wei, Dan" , "Pei, Andy" , "Yang, Qiming" , "Wang, Haiyue" , "Chen, Santos" , "Zhang, Zhang" , "Lomartire, David" , "Hu, Jia" Date: Tue, 16 Apr 2019 10:09:43 +0200 Message-ID: <1849278.EChBP1P422@xps> In-Reply-To: <0E78D399C70DA940A335608C6ED296D73A6AF7CE@SHSMSX104.ccr.corp.intel.com> References: <1551338000-120348-1-git-send-email-rosen.xu@intel.com> <4035e454-c105-9a01-c1c9-e9ba343a69e3@intel.com> <0E78D399C70DA940A335608C6ED296D73A6AF7CE@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v8 02/14] bus/ifpga: add function for AFU search by name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190416080943.p0KMtlZGZXkLH9UMtqo3MVYyVfEzMUtNv-pSt_YMsdk@z> 16/04/2019 04:50, Xu, Rosen: > From: Yigit, Ferruh > > > --- a/drivers/bus/ifpga/rte_bus_ifpga.h > > > +++ b/drivers/bus/ifpga/rte_bus_ifpga.h > > > @@ -120,6 +120,15 @@ struct rte_afu_driver { } > > > > > > /** > > > + * Find AFU by AFU name. > > > + * > > > + * @param name > > > + * A pointer to AFU name string. > > > + */ > > > +struct rte_afu_device *__rte_experimental > > > +rte_ifpga_find_afu_by_name(const char *name); > > > + > > > > > > Hi Rosen, > > > > This is the bus code, and only drivers will call it right? I think there is no > > intention to make this run by application code, the functions need to be > > exported because driver and bus are different libraries. > > If above correct, there is no point of making the function experimental, can > > drop the __rte_experimental tag, and update .map file to not use > > EXPERIMENTAL. > > Hi Ferruh, > > Just double confirm with you, if I follow this modification, there is one checkpatch error. This is a warning, and Ferruh allows it in this case :)