From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8589DA052A; Mon, 20 Jan 2020 15:33:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 573C94C7B; Mon, 20 Jan 2020 15:33:15 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 91D394C7A; Mon, 20 Jan 2020 15:33:13 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 01DCE20F02; Mon, 20 Jan 2020 09:33:13 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 20 Jan 2020 09:33:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=cVC3bxIgPuVRio4QnmwXsVZod9jOqgLGE/sO6hARFoo=; b=cxYeTUz8UvP1 MA5/sqWdTl2pRjIEZqV3G5ZF9nySjO2wraFsq+kHqqfSLiaX83FuIGHhB4ycDxvH 5ygYFyv9awROzaMyB4l/iDS2qWL0YVaF5wf/lkbPuqQWCw4jy0bzriekTH1mz33y DLVaZHNMGmJHJ2ARvI0N1IyZp7wW9q4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=cVC3bxIgPuVRio4QnmwXsVZod9jOqgLGE/sO6hARF oo=; b=Eq0k4HFoOE3NlGRVUU5J1KSXtKEGzPZNvhKzuoZmFqAI1XoS08lVNM5ee 06/633ieSUqmoJZ9rsF0EHPyLTjwY+jaFzlae11oMdbXv09fNetm7o0CInOCR9R+ N8WZ8Eafo8lv1vevVL6bCMAyEgFmSjn0pgJspFTFEuVslz/gI1VRlXEhzu5lUPV6 j5Mc81e563tAMVbHDv9QehE3SVw693UGShZ0IHdsrJoN5Z4Jgcku9nuK/Tt6stq9 R7wI9bpnYrdowkgcQ6NzryrwollsyPUSHOdoOSDhtLeeTAQSPm6c56IQDxlbeYxq gCuQqcI9DzQlIYDx5RzOBVyMhRR3w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeigddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ED00680061; Mon, 20 Jan 2020 09:33:10 -0500 (EST) From: Thomas Monjalon To: "Trahe, Fiona" , "Trybula, ArturX" , "Mcnamara, John" Cc: "dev@dpdk.org" , "stable@dpdk.org" , "shallyv@marvell.com" , "Dybkowski, AdamX" , "Danilewicz, MarcinX" , Akhil Goyal Date: Mon, 20 Jan 2020 15:33:10 +0100 Message-ID: <1850623.NnIJQXNAa5@xps> In-Reply-To: References: <20200114115656.14611-1-arturx.trybula@intel.com> <3347026.0YcMNavOfZ@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/compress: replace test vector X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/01/2020 14:54, Mcnamara, John: > From: stable On Behalf Of Thomas Monjalon > > 15/01/2020 16:54, Akhil Goyal: > > > > > > > > > > This patch replaces existing test vector with a new one containing > > > > > C code to fix license issue. > > > > > > > > > > Signed-off-by: Artur Trybula > > > > Acked-by: Fiona Trahe > > > Applied to dpdk-next-crypto > > > > This is a terrible idea. > > Adding C code in a C project as text, and worst, its own code, will make > > grep matching on fake text. > > Hi, > > I don't think this is a valid criticism. The patch replace code in Pascal with some code in C as a compression test. The grep part isn't really relevant, it should be clear to anyone who finds a match. > > If you have a strong objection we will replace it with some more public domain text. Yes please, it will be less confusing. > > Why do you need so much text to compress? Please why do we need some code at all? > > Why not just opening our own code files as text? > > That probably isn't worth the effort. > > > Why stable@dpdk.org is Cc'ed in this email? > > Ok. We'll do that. I say Why? You say Ok :-) > > What is the license issue? > > The issue is that the Pascal code from the Calgary Corpus (a standard body of compression test input) doesn't have a license or explicitly say that it is in the public domain so it isn't clear if we can relicense it as BSD-3. We are being overly cautious here but we didn't want to run into any potential license issues. OK Please explain in the commit log.