[dpdk-dev] [PATCH 0/4] improve build coverage

[dpdk-dev] [PATCH 0/4] improve build coverage

[Bruce Richardson]

This patch aims to increase the amount of code coverage we get when
doing a basic build of DPDK using the build tools and scripts. It does this
by enabling in our makefiles and default build configuration extra drivers
and examples which don't have extra external requirements. It then adjusts
the testbuild script to ensure it covers the test binary which was recently
removed from the default build.

Bruce Richardson (4):
  examples: enable performance-thread in examples build
  config: enable crypto scheduler PMD by default
  devtools: remove special case build for perf thread example
  devtools: add autotest app to build script

 config/common_base     | 2 +-
 devtools/test-build.sh | 5 +----
 examples/Makefile      | 3 +++
 3 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.9.3

[dpdk-dev] [PATCH 1/4] examples: enable performance-thread in examples build

[Bruce Richardson]

The performance-thread example was not build by default in the make
examples build target. It will compile ok for x86_64 targets so add it to
the examples makefile list for that platform.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 examples/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/Makefile b/examples/Makefile
index da2bfdd..49b0703 100644
--- a/examples/Makefile
+++ b/examples/Makefile
@@ -78,6 +78,9 @@ DIRS-$(CONFIG_RTE_LIBRTE_LPM) += load_balancer
 DIRS-y += multi_process
 DIRS-y += netmap_compat/bridge
 DIRS-$(CONFIG_RTE_LIBRTE_REORDER) += packet_ordering
+ifeq ($(CONFIG_RTE_ARCH_X86_64),y)
+DIRS-y += performance-thread
+endif
 DIRS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ptpclient
 DIRS-$(CONFIG_RTE_LIBRTE_METER) += qos_meter
 DIRS-$(CONFIG_RTE_LIBRTE_SCHED) += qos_sched
-- 
2.9.3

[dpdk-dev] [PATCH 2/4] config: enable crypto scheduler PMD by default

[Bruce Richardson]

The crypto scheduler PMD has no external dependencies to enable that by
default.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 config/common_base | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/common_base b/config/common_base
index 2d54ddf..38e9483 100644
--- a/config/common_base
+++ b/config/common_base
@@ -440,7 +440,7 @@ CONFIG_RTE_LIBRTE_PMD_ZUC_DEBUG=n
 #
 # Compile PMD for Crypto Scheduler device
 #
-CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER=n
+CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER=y
 CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER_DEBUG=n
 
 #
-- 
2.9.3

[dpdk-dev] [PATCH 3/4] devtools: remove special case build for perf thread example

[Bruce Richardson]

Since performance-thread example app is now built as part of make examples
we don't need a special case line for it in testbuild.sh script

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 devtools/test-build.sh | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 5fed4c1..a38ffab 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -237,9 +237,6 @@ for conf in $configs ; do
 		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
 		O=$(readlink -m $dir/examples)
 	! echo $target | grep -q '^x86_64' || \
-	make -j$J -sC examples/performance-thread \
-		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
-		O=$(readlink -m $dir/examples/performance-thread)
 	unset RTE_TARGET
 	echo "################## $dir done."
 	unset dir
-- 
2.9.3

[dpdk-dev] [PATCH 4/4] devtools: add autotest app to build script

[Bruce Richardson]

Since the test app is no longer being build by default as part of a build,
we need to update the testbuild script to take account of this. Rather than
just doing a "make" in the build directory, we can instead do "make
test-build" which does a normal build as well as building the test
application too.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 devtools/test-build.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index a38ffab..0894bbd 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -227,7 +227,7 @@ for conf in $configs ; do
 	config $dir $target $options
 
 	echo "================== Build $dir"
-	make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
+	make -j$J test-build EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
 		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
 	! $short || break
 	echo "================== Build examples for $dir"
-- 
2.9.3

[dpdk-dev] [PATCH v2 0/4] improve build coverage

[Bruce Richardson]

This patch aims to increase the amount of code coverage we get when
doing a basic build of DPDK using the build tools and scripts. It does this
by enabling in our makefiles and default build configuration extra drivers
and examples which don't have extra external requirements. It then adjusts
the testbuild script to ensure it covers the test binary which was recently
removed from the default build.

V2: corrected test-build additions for the autotest binary, since
  test-build skips testpmd and the other apps. Therefore we need to run two
  build commands to build everything.

Bruce Richardson (4):
  examples: enable performance-thread in examples build
  config: enable crypto scheduler PMD by default
  devtools: remove special case build for perf thread example
  devtools: add autotest app to build script

 config/common_base     | 2 +-
 devtools/test-build.sh | 6 +++---
 examples/Makefile      | 3 +++
 3 files changed, 7 insertions(+), 4 deletions(-)

-- 
2.9.3

[dpdk-dev] [PATCH v2 1/4] examples: enable performance-thread in examples build

[Bruce Richardson]

The performance-thread example was not build by default in the make
examples build target. It will compile ok for x86_64 targets so add it to
the examples makefile list for that platform.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 examples/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/Makefile b/examples/Makefile
index da2bfdd..49b0703 100644
--- a/examples/Makefile
+++ b/examples/Makefile
@@ -78,6 +78,9 @@ DIRS-$(CONFIG_RTE_LIBRTE_LPM) += load_balancer
 DIRS-y += multi_process
 DIRS-y += netmap_compat/bridge
 DIRS-$(CONFIG_RTE_LIBRTE_REORDER) += packet_ordering
+ifeq ($(CONFIG_RTE_ARCH_X86_64),y)
+DIRS-y += performance-thread
+endif
 DIRS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ptpclient
 DIRS-$(CONFIG_RTE_LIBRTE_METER) += qos_meter
 DIRS-$(CONFIG_RTE_LIBRTE_SCHED) += qos_sched
-- 
2.9.3

[dpdk-dev] [PATCH v2 2/4] config: enable crypto scheduler PMD by default

[Bruce Richardson]

The crypto scheduler PMD has no external dependencies to enable that by
default.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 config/common_base | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/config/common_base b/config/common_base
index 2d54ddf..38e9483 100644
--- a/config/common_base
+++ b/config/common_base
@@ -440,7 +440,7 @@ CONFIG_RTE_LIBRTE_PMD_ZUC_DEBUG=n
 #
 # Compile PMD for Crypto Scheduler device
 #
-CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER=n
+CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER=y
 CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER_DEBUG=n
 
 #
-- 
2.9.3

[dpdk-dev] [PATCH v2 3/4] devtools: remove special case build for perf thread example

[Bruce Richardson]

Since performance-thread example app is now built as part of make examples
we don't need a special case line for it in testbuild.sh script

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 devtools/test-build.sh | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 5fed4c1..a38ffab 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -237,9 +237,6 @@ for conf in $configs ; do
 		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
 		O=$(readlink -m $dir/examples)
 	! echo $target | grep -q '^x86_64' || \
-	make -j$J -sC examples/performance-thread \
-		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
-		O=$(readlink -m $dir/examples/performance-thread)
 	unset RTE_TARGET
 	echo "################## $dir done."
 	unset dir
-- 
2.9.3

[dpdk-dev] [PATCH v2 4/4] devtools: add autotest app to build script

[Bruce Richardson]

Since the test app is no longer being build by default as part of a build,
we need to update the testbuild script to take account of this.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
V2: added in test-build as a new build action, since it skips the testpmd
  build when run.
---
 devtools/test-build.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index a38ffab..cc8f8dc 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -229,6 +229,9 @@ for conf in $configs ; do
 	echo "================== Build $dir"
 	make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
 		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
+	echo "================== Build tests for $dir"
+	make test-build -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
+		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
 	! $short || break
 	echo "================== Build examples for $dir"
 	export RTE_SDK=$(pwd)
-- 
2.9.3

Re: [dpdk-dev] [PATCH v2 1/4] examples: enable performance-thread in examples build

[Declan Doherty]

On 29/03/2017 5:38 PM, Bruce Richardson wrote:
> The performance-thread example was not build by default in the make
> examples build target. It will compile ok for x86_64 targets so add it to
> the examples makefile list for that platform.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  examples/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/examples/Makefile b/examples/Makefile
> index da2bfdd..49b0703 100644
> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -78,6 +78,9 @@ DIRS-$(CONFIG_RTE_LIBRTE_LPM) += load_balancer
>  DIRS-y += multi_process
>  DIRS-y += netmap_compat/bridge
>  DIRS-$(CONFIG_RTE_LIBRTE_REORDER) += packet_ordering
> +ifeq ($(CONFIG_RTE_ARCH_X86_64),y)
> +DIRS-y += performance-thread
> +endif
>  DIRS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ptpclient
>  DIRS-$(CONFIG_RTE_LIBRTE_METER) += qos_meter
>  DIRS-$(CONFIG_RTE_LIBRTE_SCHED) += qos_sched
>

Acked-by: Declan Doherty <declan.doherty@intel.com>

Re: [dpdk-dev] [PATCH v2 2/4] config: enable crypto scheduler PMD by default

[Declan Doherty]

On 29/03/2017 5:38 PM, Bruce Richardson wrote:
> The crypto scheduler PMD has no external dependencies to enable that by
> default.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  config/common_base | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/config/common_base b/config/common_base
> index 2d54ddf..38e9483 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -440,7 +440,7 @@ CONFIG_RTE_LIBRTE_PMD_ZUC_DEBUG=n
>  #
>  # Compile PMD for Crypto Scheduler device
>  #
> -CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER=n
> +CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER=y
>  CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER_DEBUG=n
>
>  #
>

Acked-by: Declan Doherty <declan.doherty@intel.com>

Re: [dpdk-dev] [PATCH v2 3/4] devtools: remove special case build for perf thread example

[Declan Doherty]

On 29/03/2017 5:38 PM, Bruce Richardson wrote:
> Since performance-thread example app is now built as part of make examples
> we don't need a special case line for it in testbuild.sh script
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  devtools/test-build.sh | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index 5fed4c1..a38ffab 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -237,9 +237,6 @@ for conf in $configs ; do
>  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
>  		O=$(readlink -m $dir/examples)
>  	! echo $target | grep -q '^x86_64' || \
> -	make -j$J -sC examples/performance-thread \
> -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> -		O=$(readlink -m $dir/examples/performance-thread)
>  	unset RTE_TARGET
>  	echo "################## $dir done."
>  	unset dir
>

Acked-by: Declan Doherty <declan.doherty@intel.com>

Re: [dpdk-dev] [PATCH v2 4/4] devtools: add autotest app to build script

[Declan Doherty]

On 29/03/2017 5:38 PM, Bruce Richardson wrote:
> Since the test app is no longer being build by default as part of a build,
> we need to update the testbuild script to take account of this.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> V2: added in test-build as a new build action, since it skips the testpmd
>   build when run.
> ---
>  devtools/test-build.sh | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index a38ffab..cc8f8dc 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -229,6 +229,9 @@ for conf in $configs ; do
>  	echo "================== Build $dir"
>  	make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
>  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
> +	echo "================== Build tests for $dir"
> +	make test-build -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
> +		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
>  	! $short || break
>  	echo "================== Build examples for $dir"
>  	export RTE_SDK=$(pwd)
>

Acked-by: Declan Doherty <declan.doherty@intel.com>

Re: [dpdk-dev] [PATCH v2 3/4] devtools: remove special case build for perf thread example

[Thomas Monjalon]

2017-03-29 17:38, Bruce Richardson:
> Since performance-thread example app is now built as part of make examples
> we don't need a special case line for it in testbuild.sh script
[...]
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -237,9 +237,6 @@ for conf in $configs ; do
>  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
>  		O=$(readlink -m $dir/examples)
>  	! echo $target | grep -q '^x86_64' || \
> -	make -j$J -sC examples/performance-thread \
> -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> -		O=$(readlink -m $dir/examples/performance-thread)

You are missing the x86_64 check.

This patch should be squashed with the first one.

Re: [dpdk-dev] [PATCH v2 4/4] devtools: add autotest app to build script

[Thomas Monjalon]

2017-03-29 17:38, Bruce Richardson:
> Since the test app is no longer being build by default as part of a build,
> we need to update the testbuild script to take account of this.
[...]
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -229,6 +229,9 @@ for conf in $configs ; do
>  	echo "================== Build $dir"
>  	make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
>  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
> +	echo "================== Build tests for $dir"
> +	make test-build -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
> +		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
>  	! $short || break
>  	echo "================== Build examples for $dir"
>  	export RTE_SDK=$(pwd)

It should be added after the "short break".

The test-build target rebuild all.
I think it should be standard apps like the examples
and not re-link the libs before building.
The other way is to merge it with the above command (default build).

Re: [dpdk-dev] [PATCH 2/4] config: enable crypto scheduler PMD by default

[Zhang, Roy Fan]

On 29/03/2017 15:04, Bruce Richardson wrote:
> The crypto scheduler PMD has no external dependencies to enable that by
> default.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>

Acked by: Fan Zhang <roy.fan.zhang@intel.com>

Re: [dpdk-dev] [PATCH v2 3/4] devtools: remove special case build for perf thread example

[Bruce Richardson]

On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote:
> 2017-03-29 17:38, Bruce Richardson:
> > Since performance-thread example app is now built as part of make examples
> > we don't need a special case line for it in testbuild.sh script
> [...]
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > @@ -237,9 +237,6 @@ for conf in $configs ; do
> >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> >  		O=$(readlink -m $dir/examples)
> >  	! echo $target | grep -q '^x86_64' || \
> > -	make -j$J -sC examples/performance-thread \
> > -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > -		O=$(readlink -m $dir/examples/performance-thread)
> 
> You are missing the x86_64 check.

That's in the makefile in the first patch
> 
> This patch should be squashed with the first one.
> 
Sure. Doesn't matter to me!

/Bruce

Re: [dpdk-dev] [PATCH v2 4/4] devtools: add autotest app to build script

[Bruce Richardson]

On Thu, Mar 30, 2017 at 04:36:11PM +0200, Thomas Monjalon wrote:
> 2017-03-29 17:38, Bruce Richardson:
> > Since the test app is no longer being build by default as part of a build,
> > we need to update the testbuild script to take account of this.
> [...]
> > --- a/devtools/test-build.sh
> > +++ b/devtools/test-build.sh
> > @@ -229,6 +229,9 @@ for conf in $configs ; do
> >  	echo "================== Build $dir"
> >  	make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
> >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
> > +	echo "================== Build tests for $dir"
> > +	make test-build -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
> > +		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
> >  	! $short || break
> >  	echo "================== Build examples for $dir"
> >  	export RTE_SDK=$(pwd)
> 
> It should be added after the "short break".
> 
You have no idea how many times in preparing the patchset I moved the
addition above the break, and then back below it, and above it again!
You pick what you think is best. :-)

> The test-build target rebuild all.
It rebuilds the libs, but not the apps, which is why we can't just
use test-build target, or we will skip testpmd.

> I think it should be standard apps like the examples
> and not re-link the libs before building.
> The other way is to merge it with the above command (default build).

I tried merging the two into a single command, i.e. "make all
test-build" but that failed with parallel builds because the two jobs
try and build some things at the same time and interfere with each
other. [The kernel drivers seemed to be the main problem]

/Bruce

Re: [dpdk-dev] [PATCH v2 3/4] devtools: remove special case build for perf thread example

[Thomas Monjalon]

2017-03-30 16:30, Bruce Richardson:
> On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote:
> > 2017-03-29 17:38, Bruce Richardson:
> > > Since performance-thread example app is now built as part of make examples
> > > we don't need a special case line for it in testbuild.sh script
> > [...]
> > > --- a/devtools/test-build.sh
> > > +++ b/devtools/test-build.sh
> > > @@ -237,9 +237,6 @@ for conf in $configs ; do
> > >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > >  		O=$(readlink -m $dir/examples)
> > >  	! echo $target | grep -q '^x86_64' || \
> > > -	make -j$J -sC examples/performance-thread \
> > > -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > -		O=$(readlink -m $dir/examples/performance-thread)
> > 
> > You are missing the x86_64 check.
> 
> That's in the makefile in the first patch

Sorry, I mean you should remove the above check:
	! echo $target | grep -q '^x86_64' || \

Re: [dpdk-dev] [PATCH v2 4/4] devtools: add autotest app to build script

[Thomas Monjalon]

For info, Ferruh did a similar patch:
	http://dpdk.org/patch/22443
Ferruh, OK to keep Bruce one?

2017-03-30 16:33, Bruce Richardson:
> On Thu, Mar 30, 2017 at 04:36:11PM +0200, Thomas Monjalon wrote:
> > 2017-03-29 17:38, Bruce Richardson:
> > > Since the test app is no longer being build by default as part of a build,
> > > we need to update the testbuild script to take account of this.
> > [...]
> > > --- a/devtools/test-build.sh
> > > +++ b/devtools/test-build.sh
> > > @@ -229,6 +229,9 @@ for conf in $configs ; do
> > >  	echo "================== Build $dir"
> > >  	make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
> > >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
> > > +	echo "================== Build tests for $dir"
> > > +	make test-build -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
> > > +		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
> > >  	! $short || break
> > >  	echo "================== Build examples for $dir"
> > >  	export RTE_SDK=$(pwd)
> > 
> > It should be added after the "short break".
> > 
> You have no idea how many times in preparing the patchset I moved the
> addition above the break, and then back below it, and above it again!
> You pick what you think is best. :-)
> 
> > The test-build target rebuild all.
> It rebuilds the libs, but not the apps, which is why we can't just
> use test-build target, or we will skip testpmd.
> 
> > I think it should be standard apps like the examples
> > and not re-link the libs before building.
> > The other way is to merge it with the above command (default build).
> 
> I tried merging the two into a single command, i.e. "make all
> test-build" but that failed with parallel builds because the two jobs
> try and build some things at the same time and interfere with each
> other. [The kernel drivers seemed to be the main problem]
> 
> /Bruce

Re: [dpdk-dev] [PATCH v2 3/4] devtools: remove special case build for perf thread example

[Bruce Richardson]

On Thu, Mar 30, 2017 at 10:38:02PM +0200, Thomas Monjalon wrote:
> 2017-03-30 16:30, Bruce Richardson:
> > On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote:
> > > 2017-03-29 17:38, Bruce Richardson:
> > > > Since performance-thread example app is now built as part of make examples
> > > > we don't need a special case line for it in testbuild.sh script
> > > [...]
> > > > --- a/devtools/test-build.sh
> > > > +++ b/devtools/test-build.sh
> > > > @@ -237,9 +237,6 @@ for conf in $configs ; do
> > > >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > >  		O=$(readlink -m $dir/examples)
> > > >  	! echo $target | grep -q '^x86_64' || \
> > > > -	make -j$J -sC examples/performance-thread \
> > > > -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > > -		O=$(readlink -m $dir/examples/performance-thread)
> > > 
> > > You are missing the x86_64 check.
> > 
> > That's in the makefile in the first patch
> 
> Sorry, I mean you should remove the above check:
> 	! echo $target | grep -q '^x86_64' || \
> 
Oops, yes, you are right. Do you need a V3 of this set, or can you just
fix it up as you like it on apply?

/Bruce

Re: [dpdk-dev] [PATCH v2 3/4] devtools: remove special case build for perf thread example

[Thomas Monjalon]

2017-03-31 10:15, Bruce Richardson:
> On Thu, Mar 30, 2017 at 10:38:02PM +0200, Thomas Monjalon wrote:
> > 2017-03-30 16:30, Bruce Richardson:
> > > On Thu, Mar 30, 2017 at 04:31:45PM +0200, Thomas Monjalon wrote:
> > > > 2017-03-29 17:38, Bruce Richardson:
> > > > > Since performance-thread example app is now built as part of make examples
> > > > > we don't need a special case line for it in testbuild.sh script
> > > > [...]
> > > > > --- a/devtools/test-build.sh
> > > > > +++ b/devtools/test-build.sh
> > > > > @@ -237,9 +237,6 @@ for conf in $configs ; do
> > > > >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > > >  		O=$(readlink -m $dir/examples)
> > > > >  	! echo $target | grep -q '^x86_64' || \
> > > > > -	make -j$J -sC examples/performance-thread \
> > > > > -		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
> > > > > -		O=$(readlink -m $dir/examples/performance-thread)
> > > > 
> > > > You are missing the x86_64 check.
> > > 
> > > That's in the makefile in the first patch
> > 
> > Sorry, I mean you should remove the above check:
> > 	! echo $target | grep -q '^x86_64' || \
> > 
> Oops, yes, you are right. Do you need a V3 of this set, or can you just
> fix it up as you like it on apply?

Please send a new version for this fix and the short break in next patch.

Re: [dpdk-dev] [PATCH v2 4/4] devtools: add autotest app to build script

[Ferruh Yigit]

On 3/30/2017 9:42 PM, Thomas Monjalon wrote:
> For info, Ferruh did a similar patch:
> 	http://dpdk.org/patch/22443
> Ferruh, OK to keep Bruce one?

Sure, go for it, they both do same thing.

> 
> 2017-03-30 16:33, Bruce Richardson:
>> On Thu, Mar 30, 2017 at 04:36:11PM +0200, Thomas Monjalon wrote:
>>> 2017-03-29 17:38, Bruce Richardson:
>>>> Since the test app is no longer being build by default as part of a build,
>>>> we need to update the testbuild script to take account of this.
>>> [...]
>>>> --- a/devtools/test-build.sh
>>>> +++ b/devtools/test-build.sh
>>>> @@ -229,6 +229,9 @@ for conf in $configs ; do
>>>>  	echo "================== Build $dir"
>>>>  	make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
>>>>  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
>>>> +	echo "================== Build tests for $dir"
>>>> +	make test-build -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
>>>> +		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
>>>>  	! $short || break
>>>>  	echo "================== Build examples for $dir"
>>>>  	export RTE_SDK=$(pwd)
>>>
>>> It should be added after the "short break".
>>>
>> You have no idea how many times in preparing the patchset I moved the
>> addition above the break, and then back below it, and above it again!
>> You pick what you think is best. :-)
>>
>>> The test-build target rebuild all.
>> It rebuilds the libs, but not the apps, which is why we can't just
>> use test-build target, or we will skip testpmd.
>>
>>> I think it should be standard apps like the examples
>>> and not re-link the libs before building.
>>> The other way is to merge it with the above command (default build).
>>
>> I tried merging the two into a single command, i.e. "make all
>> test-build" but that failed with parallel builds because the two jobs
>> try and build some things at the same time and interfere with each
>> other. [The kernel drivers seemed to be the main problem]
>>
>> /Bruce
> 
> 

Re: [dpdk-dev] [PATCH v2 0/4] improve build coverage

[Thomas Monjalon]

2017-03-29 17:38, Bruce Richardson:
> This patch aims to increase the amount of code coverage we get when
> doing a basic build of DPDK using the build tools and scripts. It does this
> by enabling in our makefiles and default build configuration extra drivers
> and examples which don't have extra external requirements. It then adjusts
> the testbuild script to ensure it covers the test binary which was recently
> removed from the default build.
> 
> V2: corrected test-build additions for the autotest binary, since
>   test-build skips testpmd and the other apps. Therefore we need to run two
>   build commands to build everything.
> 
> Bruce Richardson (4):
>   examples: enable performance-thread in examples build
>   config: enable crypto scheduler PMD by default
>   devtools: remove special case build for perf thread example
>   devtools: add autotest app to build script

Applied with suggested modifications, thanks