From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 619127ED0 for <dev@dpdk.org>; Tue, 17 Apr 2018 15:22:09 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CF13621BAF; Tue, 17 Apr 2018 09:22:08 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 17 Apr 2018 09:22:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=CmfS9zKZR6kn6b8kcz3JZDUXG6 3aj4A0gyltJESZveg=; b=DM0ES6ASORSJu0m46MhB8JiG6kKtGALENKHIjdafKx CBKzhLJbKGMKM0rNm4iJcEYTioaA7rxONvDYyEENEdhQPAhMhFAm/qo5UjgqqOgi a5HSKixMzwlYZec23DzstjECWUjRnXOPzTklsDu6y5Jk9NfbU/LepwoIM8HGQX/Z U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=CmfS9z KZR6kn6b8kcz3JZDUXG63aj4A0gyltJESZveg=; b=fGPY3igKt9Pw2zSQPJmKwp Skm2MrojAVBwaWTemGfdxoqH1T+xEBHFClb/Wp9UfsBW1VDEp+VkznpgZFTMNW5p BKeN2f7oig2WLFbgP2ya1DzHQtNcF8YNNLjQlY8G7qKzukmB2AujDEGuiF6Ri8Ya Qe0/kMNrKUFby4QvCK8d4J7mYLbCRKPoFRtWvNV91+JFHn+TzCrUDmAb7ffvtKTp WI4279B9+8qx5fHyDtio6usDkkwiYS21kArmrvsUt+wIebgFwyqbbkpueezUHVYH pDFybhOrK1D5pCY+Xot9F5hRjELNWIgG7fUCq5kMdW7S+0+KoEx/tCTMMDqPRB4A == X-ME-Sender: <xms:APXVWjXJmNvcWMzIhps5CyzLmCLbr5cCT9Eps6cYxmCfUEaxwQkN6Q> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 049E1E4121; Tue, 17 Apr 2018 09:22:07 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Junjie Chen <junjie.j.chen@intel.com>, bruce.richardson@intel.com, konstantin.ananyev@intel.com Cc: dev@dpdk.org Date: Tue, 17 Apr 2018 15:22:06 +0200 Message-ID: <1852475.4XxgDvW1hG@xps> In-Reply-To: <20180412051636.240746-1-junjie.j.chen@intel.com> References: <20180412051636.240746-1-junjie.j.chen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 17 Apr 2018 13:22:09 -0000 12/04/2018 07:16, Junjie Chen: > From: "Chen, Junjie" <junjie.j.chen@intel.com> > > Sometimes gcc does not inline the function despite keyword *inline*, > we obeserve rte_movX is not inline when doing performance profiling, > so use *always_inline* keyword to force gcc to inline the function. > > Signed-off-by: Chen, Junjie <junjie.j.chen@intel.com> > --- > .../common/include/arch/x86/rte_memcpy.h | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) The title should start with "eal/x86:" Something like that: eal/x86: force inlining of memcpy sub-functions Bruce, Konstantin, any review of the content/optimization?