From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by dpdk.org (Postfix) with ESMTP id 1D1A35905 for ; Thu, 28 Aug 2014 14:27:53 +0200 (CEST) Received: by mail-we0-f177.google.com with SMTP id u56so687841wes.36 for ; Thu, 28 Aug 2014 05:32:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=GlBMqkCz80+H63xEsCg14mDwGVQRouH77JSApv1floA=; b=UJn0zkMjp43Qhbmi+h9Dk/sMpX+eCHjjIs7qvPCsOp2flayeubHAQ8xb5CqeDhF9eU inSlko6YR/FczPvrZUNIFQilFCUHjDBsetkcHM2OHqKdmPxpfYfw13PNQZSA9wSfeCAq 9pf6U79XCEona2soNeJGSKRkSi3lceyGMFUaHxrNr7t6BiEgTxz7QOyT013uWVUsR5w3 axs3EErZHytvKrUsCihcNDhWiDGr7Xuwln2HMrEg1jM9XZyTwoR/2lE5ipnFzE1sXFmj ajCUEKFfCrTibZqq0uuHGqlYK78lip9PkIvChx8NeI20GlcCA4xdIk0F9x0uyICZsTSM ppJQ== X-Gm-Message-State: ALoCoQmIKgDssK469xdH6SmR384uILBRtt0KE4Aa2zG1iDGiG+s4+cYfCz7qpFLLhXUAEccTdnRy X-Received: by 10.194.47.208 with SMTP id f16mr2650547wjn.130.1409229121952; Thu, 28 Aug 2014 05:32:01 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id am1sm9599626wjc.29.2014.08.28.05.32.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Aug 2014 05:32:01 -0700 (PDT) From: Thomas Monjalon To: "Liu, Jijiang" Date: Thu, 28 Aug 2014 14:31:56 +0200 Message-ID: <1852480.GdSX0xcYZA@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D633CF@SHSMSX101.ccr.corp.intel.com> References: <1409038294-21693-1-git-send-email-jijiang.liu@intel.com> <3070853.Eook8YoHL0@xps13> <1ED644BD7E0A5F4091CF203DAFB8E4CC01D633CF@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 3/7]rte_ether:add API of VxLAN packet filter in librte_ether X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2014 12:27:53 -0000 2014-08-28 11:02, Liu, Jijiang: > From: Thomas Monjalon > > 2014-08-28 00:55, Liu, Jijiang: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > I wonder if we could use a common function to set all kind of filters? > > > > > > > > Thoughts are welcome. > > > > > > The rte_eth_dev_tunnel_filter_set() is a common filter function for > > > tunneling packet, which can set all kind of filters. > > > > I understand that. But my question was: could we have common functions for > > tunnel filters and (existing) generic filters? > > Tunneling packet is encapsulated format, in order to extend another > tunneling type support and distinguish between tunneling and non-tunneling > packet, we had better provide independent common filter API. > The existing generic filter function is related to normal L2 packet > filter(non-tunneling packet). If there are two kind of filter APIs, one is > for normal L2 packet, other is for tunneling packet, which will make user > more clear when and how to use them. So I ask wether it is possible to merge 2 functions and you answer they are different functions. I know they are different. I don't see why you can merge all different tunnels filtering in one function and not merge them with other L2 filters type? Should we wait that someone suggest a new API for HTTP filtering (for a new shiny NIC) to think about how all filters could be configured through a common API? We already have flow director, syn filter, ethertype filter, 2-tuple filter, 5-tuple filter, flex filter and you want to add tunnel filter. Last time, filters was called "generic filter" and I asked to think about how it was generic: http://dpdk.org/ml/archives/dev/2014-May/002859.html As I suspected, same story restart. I want these new i40e features as much as you. But it's not responsible to let API becoming a mess like that. All these filters must be reworked (including flow director). -- Thomas