From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C576F324B for ; Thu, 3 Aug 2017 17:36:43 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 27F2E20A21; Thu, 3 Aug 2017 11:36:43 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 03 Aug 2017 11:36:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=mOfDAHn5hUxIW5a zWTi2tX9cmhNzZXZXqWuAwXv4z/4=; b=X+CbwBfKPWoTWWLa1seQyfWtYlwhAQe m6taZY9+OB6OerHCLMI7nsm+wYKP7K2zAOsGwAks4xoKfm9SBhCCrHl+t+whxFd9 fwClmk3R2xhnQOw/V+9QfrFuQEgVidr2u/cu3lLs/TNIXkZHW5zZNiFlxtrtQdHb awd4I3rbPbFg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=mOfDAHn5hUxIW5azWTi2tX9cmhNzZXZXqWuAwXv4z/4=; b=f/v9QCQQ pwAn7BqDoKQbL1nZUAemU/Dsx//iiYCiD7YeCalauh+JXfA25bafjekxww0EW7GX YSKV1tZ3VxtCYmeqm0xbtl5EoROHFRwfuUI0AgA/dDYRcCC0SEUrzs3cgJSVLEIm RUkTYzUWyLLNDwXAkcSXz+NmYKeCkEmwo9LbEU2kCSnCeUB+/snSWflhGdYv0A8E 8RfvWP+zI6vO2wVULbgo8Cqw0wcg5dCgvyq02UiLJz2MzOl6dTLoJc3wqeLRNiFA 65ovYtddzCsg0dVMiuK0ZAcWH/GRDU5tJJVfqMLByQXbBBsaEGpgFlZ4+2dBOM0V uLgJW7B/+cXMUw== X-ME-Sender: X-Sasl-enc: 5UyQ3ZdeFkNLskF67mokQyjDV9ragU0LJJkdTKOopNtc 1501774602 Received: from xps.localnet (196.114.118.80.rev.sfr.net [80.118.114.196]) by mail.messagingengine.com (Postfix) with ESMTPA id 9F3CA7FA6E; Thu, 3 Aug 2017 11:36:42 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Thu, 03 Aug 2017 17:36:41 +0200 Message-ID: <1852586.cdvAFzMDef@xps> In-Reply-To: <20170803101622.GA42296@bricha3-MOBL3.ger.corp.intel.com> References: <20170711171046.22558-1-thomas@monjalon.net> <20170803101622.GA42296@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] pci: fix level of scan debug log on BSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 15:36:44 -0000 03/08/2017 12:16, Bruce Richardson: > On Tue, Jul 11, 2017 at 07:10:46PM +0200, Thomas Monjalon wrote: > > Printing the number of scanned devices should be a debug log, > > not an error. > > > > Signed-off-by: Thomas Monjalon > > --- [...] > > - RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count); > > + RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count); > > return 0; > > > would have gone for INFO level myself, but DEBUG works too - it's > definitely not an error. > The commit title also reads a bit strange to me. How about e.g.: > "pci: log fix level of PCI scan summary message on BSD" > > Otherwise: > Acked-by: Bruce Richardson Applied, thanks