From: Thomas Monjalon <thomas@monjalon.net>
To: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: dev@dpdk.org, "Wang, Yipeng1" <yipeng1.wang@intel.com>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v1] hash: simplify signature compare neon process
Date: Wed, 05 Jun 2019 19:25:25 +0200 [thread overview]
Message-ID: <1853801.nhDu0V4lP0@xps> (raw)
In-Reply-To: <D2C4A16CA39F7F4E8E384D204491D7A673E9ECE6@ORSMSX104.amr.corp.intel.com>
> >Replaced multiple neon instructions with single equivalent instruction.
> >This made simpler code and a bit higher performance.
> >Hash bulk lookup had 0.1% ~ 3% performance gain in tests on ARM A72
> >platforms.
> >
> >Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> >Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> >---
> [Wang, Yipeng] Sorry for the late review.
> The logic seems fine to me based on my understanding of the instructions.
> But I don't have an ARM machine to test. Please make sure
> It passes the compilation and unit tests.
> Or others (Jerin maybe?) could provide more feedback?
>
> Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
> Reviewed-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks
next prev parent reply other threads:[~2019-06-05 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 10:02 Ruifeng Wang
2019-04-29 10:02 ` Ruifeng Wang
2019-05-03 20:40 ` Thomas Monjalon
2019-05-03 20:40 ` Thomas Monjalon
2019-05-22 0:28 ` Wang, Yipeng1
2019-06-05 17:25 ` Thomas Monjalon [this message]
2019-06-04 16:58 Jerin Jacob Kollanukkaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1853801.nhDu0V4lP0@xps \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=sameh.gobriel@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).