From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DDB4CA0096 for ; Wed, 5 Jun 2019 19:25:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00A111B95B; Wed, 5 Jun 2019 19:25:30 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 27F5F2C0C for ; Wed, 5 Jun 2019 19:25:29 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8D0AB2244F; Wed, 5 Jun 2019 13:25:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 05 Jun 2019 13:25:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=jYyH3+8l1QUWJ+5gMQqIF9gRWcAr70vV7nP4Ygp9H9A=; b=KhgONpT0m79y irD4HAq0ZV4Ff+Z9oMV5QGnvR0hK3XWh2WQ3lyblGMGKKgU1EAoBJrHl8wuq2YQ2 DqxXNREEC7CcPc+sQ/EgnyglGw8ZcJR3khUgmuGRqHdCpAL/MQ74N3yqO+cnj7Vn TVu57BZm21AgusCrMY8F/3t5qUqo9XI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=jYyH3+8l1QUWJ+5gMQqIF9gRWcAr70vV7nP4Ygp9H 9A=; b=g1+BrDjtOs4qaD5YygA5Z85INBy1BQro2B53+1QIJQFWsySnBcGlwuUQ8 lkxv48i5tP7jJ9r6KK9pQ9IT3wAmx8r4R4qNSP+vOfQ4Bg50cA2CF8Zs/jO40CDP 8kIJK9upuxq7KboJECSQ+gKd7e3esgFMO/5lac+yJx55UVh7YcJdoaNRqGlRehx/ vfU/vdnXWV//v250ywIn3FuWHsTJ2+x0SIQnrrhw/TU0n/NelBbOn4bDKmomY5dt XgGdhzw+MTQF2vMb4cne4ltHJIDy7ohRmqqfE9HTI6szLWHyEfFbD2srxt5Vgmbf fW+LdD6ceMSSZ8HXl5/DFyWw6+wUA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudegvddguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C0D8C38008A; Wed, 5 Jun 2019 13:25:26 -0400 (EDT) From: Thomas Monjalon To: Ruifeng Wang Cc: dev@dpdk.org, "Wang, Yipeng1" , "Gobriel, Sameh" , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "jerinj@marvell.com" , "Honnappa.Nagarahalli@arm.com" , "nd@arm.com" Date: Wed, 05 Jun 2019 19:25:25 +0200 Message-ID: <1853801.nhDu0V4lP0@xps> In-Reply-To: References: <1556532127-46557-1-git-send-email-ruifeng.wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] hash: simplify signature compare neon process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > >Replaced multiple neon instructions with single equivalent instruction. > >This made simpler code and a bit higher performance. > >Hash bulk lookup had 0.1% ~ 3% performance gain in tests on ARM A72 > >platforms. > > > >Signed-off-by: Ruifeng Wang > >Reviewed-by: Gavin Hu > >--- > [Wang, Yipeng] Sorry for the late review. > The logic seems fine to me based on my understanding of the instructions. > But I don't have an ARM machine to test. Please make sure > It passes the compilation and unit tests. > Or others (Jerin maybe?) could provide more feedback? > > Acked-by: Yipeng Wang > Reviewed-by: Jerin Jacob Applied, thanks