From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F59B41B8E; Tue, 31 Jan 2023 13:15:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B2CF40DFB; Tue, 31 Jan 2023 13:15:44 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2386E4067B for ; Tue, 31 Jan 2023 13:15:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675167342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y1qVJ7aF8qvBrZI3/r+X+CSlzMleZOXgBMPLaB0T2sU=; b=h1Xn41RcMyNbNcXDOrzgpWL+SBXRiGTdmkLBnWNBARa95+NpMGBh5BKpJUDI14QsY6jOYx CYyIylhHvgnxU526eSMndF7PN5HK31iwedtRmFgtUl2Utoyqe191FGTbSRFvX6SEFIdAjU hL7xlWlRj2dsd/AkkVqrz0gtiHRrcmI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-423-DuLCa436PmW7Rg4Q5Mxy2Q-1; Tue, 31 Jan 2023 07:15:41 -0500 X-MC-Unique: DuLCa436PmW7Rg4Q5Mxy2Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC7C4100DEB8; Tue, 31 Jan 2023 12:15:40 +0000 (UTC) Received: from [10.39.208.22] (unknown [10.39.208.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0FA50C15BAD; Tue, 31 Jan 2023 12:15:38 +0000 (UTC) Message-ID: <18538815-2aa4-df1d-b6a0-df555872ff26@redhat.com> Date: Tue, 31 Jan 2023 13:15:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v1 09/13] test/bbdev: bbdev-test cannot compare some scenarios To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20230117165023.20567-1-hernan.vargas@intel.com> <20230117165023.20567-10-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230117165023.20567-10-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/17/23 17:50, Hernan Vargas wrote: > Updating logic for compression usecases. > > Signed-off-by: Hernan Vargas > --- > app/test-bbdev/test_bbdev_perf.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index fdf7a28ba2..3b2578baf6 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -2143,12 +2143,17 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, > total_data_size += orig_op->segments[i].length; > > TEST_ASSERT(orig_op->segments[i].length < > - (uint32_t)(data_len + 64), > + (uint32_t)(data_len + 256), Where is that value coming from? It lacks explanations in my opinion, and the patch looks like a fix but is not tagged as one. > "Length of segment differ in original (%u) and filled (%u) op", > orig_op->segments[i].length, data_len); > harq_orig = (int8_t *) orig_op->segments[i].addr; > harq_out = rte_pktmbuf_mtod_offset(m, int8_t *, offset); > > + /* Cannot compare HARQ output data for such cases */ > + if ((ldpc_llr_decimals > 1) && ((ops_ld->op_flags & RTE_BBDEV_LDPC_LLR_COMPRESSION) > + || (ops_ld->op_flags & RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION))) > + break; > + > if (!(ldpc_cap_flags & > RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS > ) || (ops_ld->op_flags & > @@ -2224,7 +2229,7 @@ validate_op_harq_chain(struct rte_bbdev_op_data *op, > > /* Validate total mbuf pkt length */ > uint32_t pkt_len = rte_pktmbuf_pkt_len(op->data) - op->offset; > - TEST_ASSERT(total_data_size < pkt_len + 64, > + TEST_ASSERT(total_data_size < pkt_len + 256, > "Length of data differ in original (%u) and filled (%u) op", > total_data_size, pkt_len); >