From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 9B9895AA0 for ; Wed, 10 Jun 2015 11:09:19 +0200 (CEST) Received: by wgv5 with SMTP id 5so30657413wgv.1 for ; Wed, 10 Jun 2015 02:09:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=pwzxaeuS/RAm0PGs2yp9H2UahkH4D2zwjDXPQNXWGmQ=; b=bIaKKXEIcRmoPQ7xObc5u0kkI/cvLJhYW4q8aqJ5chxW5JenCQCEOfZeQhZ9XORpnO B2Bd3/TdjgzcxlnJ+01hFX9n1LKwi25z2yoQ3DkrBz8XIMH+bEZRbYbmFylJDOF9lr8E TRZLHu/A3ER0tkD4YFqtxkHWK3UoyxoNPL1sym1o3LWjcnSgjm9d2evisQjMrL05kHlo XJ1tTJk8bKJeCQub7iozg3ueGr6oaeZCow4nwT26c5htaoApo83Kxr1bhGFsgh1RjmFn 2+c+FuEpDc5r2xIL0HV87mRSnrLtUY5ABHcdRerlvVpOaTrokiyMENDFKLVUrM29DSP0 Zcsg== X-Gm-Message-State: ALoCoQkgSvFtPy9tdM6tddoCNlW7qZzTJ4TkK7KWPwcWP8PGiP0+oqhUHIAMeNMBH7xsdrmU66Cq X-Received: by 10.180.189.10 with SMTP id ge10mr17135757wic.85.1433927359478; Wed, 10 Jun 2015 02:09:19 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by mx.google.com with ESMTPSA id fm8sm6864553wib.9.2015.06.10.02.09.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jun 2015 02:09:18 -0700 (PDT) From: Thomas Monjalon To: "Burakov, Anatoly" Date: Wed, 10 Jun 2015 11:08:24 +0200 Message-ID: <1857272.JbxJmyvPRA@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <20150609174057.GA4394@linux.intel.com> <1927342.Zb0Nrj3NUW@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, "Bernal Marin, Miguel" Subject: Re: [dpdk-dev] Headers files with BSD license in kernel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2015 09:09:19 -0000 2015-06-10 09:01, Burakov, Anatoly: > > 2015-06-10 01:20, Zhang, Helin: > > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > > > > > On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote: > > > > > > > Hi, > > > > > > > > > > > > > > I'm working on Clear Linux project, and when I was integrating > > > > > > > DPDK kernel modules to our kernel I found there are two > > > > > > > headers with BSD License > > > > > > > > > > > > > > rte_pci_dev_feature_defs.h > > > > > > > rte_pci_dev_features.h > > > > > > > > > > > > > > those are included in igb_uio module. > > > > > > > > > > > > > > Are those licenses correct? > > > > > > > > You can always escalate a BSD license to GPL, but the other way is not > > allowed. > > > > Ideally, the language on the file should make it clear that it is dual > > licensed. > > > > In an ideal world, igb_uio would go away, I am working on that. > > > > > > Yes, I agree with you. To be clearer, rte_pci_dev_feature_defs.h > > > should be in dual liceses, and rte_pci_dev_features.h should be in GPL > > license. > > > > Yes, it is an error from this commit: > > http://dpdk.org/browse/dpdk/commit/?id=88701645c98c9c88 > > These definitions were moved from a GPL file so they should keep the GPL > > header. > > Then it is used in EAL: > > http://dpdk.org/browse/dpdk/commit/?id=ff0b67d1c868c19 > > So it must be dual licensed, like for rte_pci_dev_ids.h: > > http://dpdk.org/browse/dpdk/tree/lib/librte_eal/common/include/ > > rte_pci_dev_ids.h > > Agreed, should have been more careful. Should I make the patch to correct this? You are welcome :)