[PATCH] doc: enhance build instructions on windows

[PATCH] doc: enhance build instructions on windows

[Andre Muezerie]

* Updated about old Meson issue
* Added instruction to get developer prompt

Andre Muezerie (1):
  doc: enhanced build instructions on Windows

 .mailmap                              |  1 +
 doc/guides/windows_gsg/build_dpdk.rst | 16 +++++++++++-----
 2 files changed, 12 insertions(+), 5 deletions(-)

-- 
1.8.3.1

[PATCH] doc: enhanced build instructions on Windows

[Andre Muezerie]

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 .mailmap                              |  1 +
 doc/guides/windows_gsg/build_dpdk.rst | 16 +++++++++++-----
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/.mailmap b/.mailmap
index 5290420..60db768 100644
--- a/.mailmap
+++ b/.mailmap
@@ -98,6 +98,7 @@ Anatolii Gerasymenko <anatolii.gerasymenko@intel.com>
 Anatoly Burakov <anatoly.burakov@intel.com>
 Anbarasan Murugesan <anbarasanx.murugesan@intel.com>
 Anders Roxell <anders.roxell@linaro.org>
+Andre Muezerie <andremue@linux.microsoft.com> <andremue@microsoft.com>
 Andrea Arcangeli <aarcange@redhat.com>
 Andrea Grandi <andrea.grandi@intel.com>
 Andre Richter <andre.o.richter@gmail.com>
diff --git a/doc/guides/windows_gsg/build_dpdk.rst b/doc/guides/windows_gsg/build_dpdk.rst
index 708875c..c5fad81 100644
--- a/doc/guides/windows_gsg/build_dpdk.rst
+++ b/doc/guides/windows_gsg/build_dpdk.rst
@@ -72,10 +72,9 @@ A good option to choose is the MSI installer for both meson and ninja together::
 
 	http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-with-the-msi-installer%22
 
-Required version is Meson 0.57.
-
-Versions starting from 0.58 are unusable with LLVM toolchain
-because of a `Meson issue <https://github.com/mesonbuild/meson/issues/8981>`_.
+Meson version 0.58 was unusable with LLVM toolchain
+because of an `issue <https://github.com/mesonbuild/meson/issues/8981>`_, but
+more recent versions are working fine.
 
 
 Install the Backend
@@ -129,13 +128,20 @@ Depending on the distribution, paths in this file may need adjustments.
 Option 3. Native Build on Windows using MSVC
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-Open a 'Developer PowerShell for VS 2022' prompt from the start menu.
+Open a 'Visual Studio Developer Command Prompt'. When doing so, it's recommended
+to specify the Target Architecture (-arch) and the Host Architecture (-host_arch).
 The developer prompt will configure the environment
 to select the appropriate compiler, linker and SDK paths
 required to build with Visual Studio 2022.
 
 .. code-block:: console
 
+    "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64
+
+Compile the code from the developer prompt.
+
+.. code-block:: console
+
    cd C:\Users\me\dpdk
    meson setup -Denable_stdatomic=true build
    meson compile -C build
-- 
1.8.3.1

Re: [PATCH] doc: enhanced build instructions on Windows

[Thomas Monjalon]

Hello and welcome,

25/10/2024 16:15, Andre Muezerie:
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
> --- a/doc/guides/windows_gsg/build_dpdk.rst
> +++ b/doc/guides/windows_gsg/build_dpdk.rst
> @@ -72,10 +72,9 @@ A good option to choose is the MSI installer for both meson and ninja together::
>  
>  	http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-with-the-msi-installer%22
>  
> -Required version is Meson 0.57.
> -
> -Versions starting from 0.58 are unusable with LLVM toolchain
> -because of a `Meson issue <https://github.com/mesonbuild/meson/issues/8981>`_.
> +Meson version 0.58 was unusable with LLVM toolchain
> +because of an `issue <https://github.com/mesonbuild/meson/issues/8981>`_, but
> +more recent versions are working fine.

Please could we be more explicit about which version is working fine?