From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com
 [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 58D73595B
 for <dev@dpdk.org>; Thu, 13 Nov 2014 10:37:17 +0100 (CET)
Received: by mail-wi0-f169.google.com with SMTP id n3so1264823wiv.4
 for <dev@dpdk.org>; Thu, 13 Nov 2014 01:47:15 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=JXoAVuOUbOqqVJQuKbxwxprXyY88QLu1v9PchvlamNc=;
 b=KVaqMPxReizL8sLNqNfUdgs56RJVpOlRDuDOlUm52pP4/OzSmCb4idDWJKS4LPn3nu
 qiMQg2ejhFcsmxOfpSDpGkaJwKgJAxI/PmvQHjd8w17ncQcmJDiQMMvLatXnP6k9jcBO
 8vRBEA0bSGDazorcAzXTm1VtbmFrOCz6xr3CX/kfLkZ6Z05iHrr7emONBv6cRvvgFOFn
 VkKK6CSZaYZFgrmJu1dkNCSkL8zQOztVd31kxgS2LAaw+M+d7+2/7JxoFjs959NVG+R1
 WnLVlqdTM/SFQH8a1qKjQuHq4qTQZBeaj48hVgx5gw0Fy0wlqpU5yPn4kSYzLr1qJdlr
 Gs/g==
X-Gm-Message-State: ALoCoQluOjpathSF8Yct0a2dFrlWhnT33x3PaOytuLOAKw1g7o2uEve4oTTiGkS717yp5PPuQWPV
X-Received: by 10.180.86.38 with SMTP id m6mr2020211wiz.65.1415872035350;
 Thu, 13 Nov 2014 01:47:15 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id dm10sm17305289wib.18.2014.11.13.01.47.14
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 13 Nov 2014 01:47:14 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: zzang <zhida.zang@intel.com>
Date: Thu, 13 Nov 2014 10:46:57 +0100
Message-ID: <1858688.dTAFT58TFH@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; )
In-Reply-To: <1411888086-10818-1-git-send-email-zhida.zang@intel.com>
References: <1411888086-10818-1-git-send-email-zhida.zang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: support of link flow control
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 13 Nov 2014 09:37:17 -0000

Hi Zhida,

> Add support of link flow control.
> 
> Signed-off-by: Zhida Zang <zhida.zang@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>

I think you are reworking this patch, right?

I won't review it myself because I don't i40e enough.
I just have some minor comments:

> +static int i40e_10g_fc_enable(struct i40e_hw *hw, uint16_t pause_time)

"static int" should be on a separate line.

> +		PMD_INIT_LOG(ERR, "i40e_set_fc = %d\n", err);

Carriage return is already included in PMD_INIT_LOG now.

Thanks for keep us informed of the status of this patch.
-- 
Thomas