From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE7F2A0543; Tue, 24 May 2022 22:28:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1F60400EF; Tue, 24 May 2022 22:28:21 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 3634C400D6 for ; Tue, 24 May 2022 22:28:20 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 570843200754; Tue, 24 May 2022 16:28:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 24 May 2022 16:28:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1653424097; x= 1653510497; bh=Hy5a2el3uEchqlYXzy+9e97VXgHtmhhGtmKVXODqZyM=; b=I tkL5DZG2tI8itdTW8aXwZnhBe5myCy0j+LsAM6EOCVK8TbiGxyz58G/q7SQ856p7 KlcxSIlbDsusyTNpSPmTtFQMk2iNhc+BvWH58UvHCBuKvvJoDQ7krW2J2ADsWtib TQU0n4kj0AtRwWIFimM3Lq/ZwFSM6C6yzdRt/k82S/kezGRoWyplFlUPyqrvPtEM rxxzqSTC1j+sYNQ35+IU8vtknLqvtaRybI5WfBPD9CU96dLzhVr++8KMoQki+QHA eKMMJ0Rkuct8XQ+rN2jorhX5/08p4ZrFkSoyovN5+Bj4kbFb9yOJgfjPkMSxHC81 xfw/BUi5EkU9US5JDl5Dw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653424097; x= 1653510497; bh=Hy5a2el3uEchqlYXzy+9e97VXgHtmhhGtmKVXODqZyM=; b=U cPrQfm2tgkaeVpFUYoVDkqSXJuQRJX8T1NfylUkOefZ1lfqj8YBa8A0LWKlhRiIc kP2NAf2zipaBiyEC2HNzpkKCcTjaWcYdHGjiXlESyb5y+imht96B+Jp4Azls+wWt A40fcBBOXjlw//71DbrJSPfOq2IuCaIdL7XzIU5kHwQY3o+MPvkA9eg2PWbuqyCg 9tSjO2Jw8uekK9Uk6/U6fgIXoMaWREnncUtzh+ahKMtn+xKvJjqZuCqqBaebcjwE 8Wx34uy10m9UTwBYTAtSJ1x6fAM89q3mOxkCdP2sKd8PHWGLkIWvUeu/lFbzJnem IbsgV63i4DjC+u+AXQJPQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjeefgdduhedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 May 2022 16:28:15 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@xilinx.com, Xiaoyun Li , Aman Singh , Yuying Zhang , Bruce Richardson Subject: Re: [PATCH v2 2/2] app/testpmd: register driver specific commands Date: Tue, 24 May 2022 22:28:06 +0200 Message-ID: <1859176.gKo4GoxMFQ@thomas> In-Reply-To: <20220524200642.1322115-3-david.marchand@redhat.com> References: <20220513075718.18674-1-david.marchand@redhat.com> <20220524200642.1322115-1-david.marchand@redhat.com> <20220524200642.1322115-3-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 24/05/2022 22:06, David Marchand: > + count = 0; > + for (i = 0; builtin_ctx[i] != NULL; i++, count++) > + ; > + TAILQ_FOREACH(c, &driver_commands_head, next) { > + for (i = 0; c->commands[i].ctx != NULL; i++, count++) > + ; > + } Just a personal preference: the iterator "i" is incremented inside the "for" instructions, but I would have incremented "count" as a statement of the loops. Acked-by: Thomas Monjalon Thanks