From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3B386D040
 for <dev@dpdk.org>; Tue, 17 Apr 2018 00:42:34 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B417721E57;
 Mon, 16 Apr 2018 18:42:33 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Mon, 16 Apr 2018 18:42:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=F+ftZSatT+wmk6m1CcUL+hS3LR
 iKk1zOn3hX8wF7Qws=; b=XiwBIpXMQnfMuZtl71vrr1ZNo8uD9a0Y1palht1g5l
 HoM4wEzSbI/A1/zXbEgkFKN79Y7crResMEglT2GaGn1zLiJyOHPzQ4AhpaRNyoiY
 e/dg+5Wb46Po9tJbKsMybWHY4+/XH5yIFRKD/o87pSjiai3M0bBDa5S+1bFA7vFs
 I=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=F+ftZS
 atT+wmk6m1CcUL+hS3LRiKk1zOn3hX8wF7Qws=; b=eLGgttCcA0SIhOvuGtu3+P
 nBsv5t5IFr8oleSHDIRIid8uGubOF8lo49ImIclmLR4Q2TR9/+cmqeEVTIdmTEwJ
 cbKZ78i3H4fbA8PAT2Ord1GeDZmup4lY5KX78MI+M7cgDrrRsHm2TvVNWa5NXT7S
 QPkfhybsR/VpxX+JgdVb0SnNq/6sPObw0m9sEXHs+8zi7yAJw7KRanumlVf5KtBh
 /2ljK0TC+B7aA9NBDgY4UPfGmIMMqGQLYZ7VKlpOWJDEWH71AD/yMYwTy0zHNSqR
 yG0NdvP0h9VsASyjbVOKYuWSVo+hyQxRIuj9nS1ANQFzPSaLOp9ZWVH43SqXd3MA
 ==
X-ME-Sender: <xms:2SbVWtSz2W-RuUPG6TtP1bqV7EUfa-KhSn2-jGiR9hOc77z4zT2lsg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id A2CF0E443C;
 Mon, 16 Apr 2018 18:42:32 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Xueming Li <xuemingl@mellanox.com>
Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>, Yongseok Koh <yskoh@mellanox.com>,
 Olivier MATZ <olivier.matz@6wind.com>, Shahaf Shuler <shahafs@mellanox.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>
Date: Tue, 17 Apr 2018 00:42:31 +0200
Message-ID: <1859185.d5eMTAXH7r@xps>
In-Reply-To: <20180408123240.110698-2-xuemingl@mellanox.com>
References: <20180408123240.110698-1-xuemingl@mellanox.com>
 <20180408123240.110698-2-xuemingl@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: introduce generic IP/UDP
	tunnel checksum and TSO
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Apr 2018 22:42:34 -0000

08/04/2018 14:32, Xueming Li:
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -210,6 +210,8 @@ extern "C" {
>  #define PKT_TX_TUNNEL_GENEVE  (0x4ULL << 45)
>  /**< TX packet with MPLS-in-UDP RFC 7510 header. */
>  #define PKT_TX_TUNNEL_MPLSINUDP (0x5ULL << 45)
> +#define PKT_TX_TUNNEL_IP (0xDULL << 45) /**< Tx IP tunneled packet. */
> +#define PKT_TX_TUNNEL_UDP (0xEULL << 45) /**< Tx UDP tunneled packet. */

I think you need to explain in details, in the comments,
what we can expect when using these flags.
Please write the doxygen comment on the lines before the flag.

Any reason for using 0xD and 0xE values?
Because they are more generic than the first ones?

>  /* add new TX TUNNEL type here */
>  #define PKT_TX_TUNNEL_MASK    (0xFULL << 45)