[dpdk-dev] [PATCH 0/2] make a couple eth_dev_ops const

[dpdk-dev] [PATCH 0/2] make a couple eth_dev_ops const

[Stephen Hemminger]

Really trivial patches.

I also consider this a litmus test of how long it takes DPDK
project to merge trivial maintaince patches.

Stephen Hemminger (2):
  bnx: make eth_dev_ops const
  ena: make eth_dev_ops const

 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 drivers/net/ena/ena_ethdev.c   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.11.0

Re: [dpdk-dev] [PATCH 0/2] make a couple eth_dev_ops const

[Ferruh Yigit]

On 1/12/2017 7:12 PM, Stephen Hemminger wrote:
> Really trivial patches.

Patches are not in patchwork, and not in the mail list.

> 
> I also consider this a litmus test of how long it takes DPDK
> project to merge trivial maintaince patches.
> 
> Stephen Hemminger (2):
>   bnx: make eth_dev_ops const
>   ena: make eth_dev_ops const
> 
>  drivers/net/bnxt/bnxt_ethdev.c | 2 +-
>  drivers/net/ena/ena_ethdev.c   | 2 +-

Right, ena and bnxt are missing const for eth_dev_ops. Do you want me
send patches?

>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

Re: [dpdk-dev] [PATCH 0/2] make a couple eth_dev_ops const

[Thomas Monjalon]

2017-01-12 21:54, Ferruh Yigit:
> On 1/12/2017 7:12 PM, Stephen Hemminger wrote:
> > Really trivial patches.
> 
> Patches are not in patchwork, and not in the mail list.
> 
> > I also consider this a litmus test of how long it takes DPDK
> > project to merge trivial maintaince patches.

This is a nice example of why patches are not merged timely,
sometimes they are not received at all :)

In order to reduce the time needed to merge, could you please
run devtools/check-git-log.sh ?

[dpdk-dev] [PATCH] net/bnxt: make eth dev ops struct const

[Ferruh Yigit]

Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 1252a36..501c97d 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1002,7 +1002,7 @@ static int bnxt_flow_ctrl_set_op(struct rte_eth_dev *dev,
  * Initialization
  */
 
-static struct eth_dev_ops bnxt_dev_ops = {
+static const struct eth_dev_ops bnxt_dev_ops = {
 	.dev_infos_get = bnxt_dev_info_get_op,
 	.dev_close = bnxt_dev_close_op,
 	.dev_configure = bnxt_dev_configure_op,
-- 
2.9.3

[dpdk-dev] [PATCH] net/ena: make eth dev ops struct const

[Ferruh Yigit]

Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/net/ena/ena_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index b9d0e8a..8497cd7 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -227,7 +227,7 @@ static int ena_rss_reta_query(struct rte_eth_dev *dev,
 			      uint16_t reta_size);
 static int ena_get_sset_count(struct rte_eth_dev *dev, int sset);
 
-static struct eth_dev_ops ena_dev_ops = {
+static const struct eth_dev_ops ena_dev_ops = {
 	.dev_configure        = ena_dev_configure,
 	.dev_infos_get        = ena_infos_get,
 	.rx_queue_setup       = ena_rx_queue_setup,
-- 
2.9.3

Re: [dpdk-dev] [PATCH] net/bnxt: make eth dev ops struct const

[Ferruh Yigit]

On 1/16/2017 1:27 PM, Ferruh Yigit wrote:
> Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Both applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/bnxt: make eth dev ops struct const

[Thomas Monjalon]

2017-01-16 13:44, Ferruh Yigit:
> On 1/16/2017 1:27 PM, Ferruh Yigit wrote:
> > Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Both applied to dpdk-next-net/master, thanks.

I must admit it is the force of Stephen:
he sends just a cover letter and do not reply, so you do the patch for him :)

Re: [dpdk-dev] [PATCH] net/bnxt: make eth dev ops struct const

[Stephen Hemminger]

On Tue, 17 Jan 2017 21:57:33 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:

> 2017-01-16 13:44, Ferruh Yigit:
> > On 1/16/2017 1:27 PM, Ferruh Yigit wrote:  
> > > Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>  
> > 
> > Both applied to dpdk-next-net/master, thanks.  
> 
> I must admit it is the force of Stephen:
> he sends just a cover letter and do not reply, so you do the patch for him :)

Actually I did do the patches but git send-email ate them :-)

Re: [dpdk-dev] [PATCH] net/bnxt: make eth dev ops struct const

[Ferruh Yigit]

On 1/16/2017 1:44 PM, Ferruh Yigit wrote:
> On 1/16/2017 1:27 PM, Ferruh Yigit wrote:
>> Reported-by: Stephen Hemminger <sthemmin@microsoft.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Both applied to dpdk-next-net/master, thanks.
> 

Updated mail address of Stephen to the mail address initially used:
Reported-by: Stephen Hemminger <stephen@networkplumber.org>