DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Sergey Alekseev <sergey.alekseev@vdomresearch.com>
Cc: dev@dpdk.org, Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ip_frag: fix hash key usage
Date: Wed, 28 Mar 2018 00:29:38 +0200	[thread overview]
Message-ID: <1860185.tFcqzqpjh1@xps> (raw)
In-Reply-To: <1519178599-3661-1-git-send-email-sergey.alekseev@vdomresearch.com>

Hi,

21/02/2018 03:03, Sergey Alekseev:
> ---
>  lib/librte_ip_frag/ip_frag_internal.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Please we need an explanation and Signed-off-by.
Could you send a v2?

Do not hesitate to Cc Konstantin (maintainer of this lib) for reviews.
Thanks

> --- a/lib/librte_ip_frag/ip_frag_internal.c
> +++ b/lib/librte_ip_frag/ip_frag_internal.c
> @@ -61,7 +61,7 @@ ipv4_frag_hash(const struct ip_frag_key *key, uint32_t *v1, uint32_t *v2)
>  	uint32_t v;
>  	const uint32_t *p;
>  
> -	p = (const uint32_t *)&key->src_dst;
> +	p = (const uint32_t *) key->src_dst;
>  
>  #ifdef RTE_ARCH_X86
>  	v = rte_hash_crc_4byte(p[0], PRIME_VALUE);
> @@ -82,7 +82,7 @@ ipv6_frag_hash(const struct ip_frag_key *key, uint32_t *v1, uint32_t *v2)
>  	uint32_t v;
>  	const uint32_t *p;
>  
> -	p = (const uint32_t *) &key->src_dst;
> +	p = (const uint32_t *) key->src_dst;
>  
>  #ifdef RTE_ARCH_X86
>  	v = rte_hash_crc_4byte(p[0], PRIME_VALUE);

      reply	other threads:[~2018-03-27 22:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21  2:03 Sergey Alekseev
2018-03-27 22:29 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1860185.tFcqzqpjh1@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=sergey.alekseev@vdomresearch.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).