From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 92F94A49A
 for <dev@dpdk.org>; Wed, 28 Mar 2018 00:29:54 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 153A920D79;
 Tue, 27 Mar 2018 18:29:54 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 27 Mar 2018 18:29:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=maVX5dvOvDu1qu+kjIUaOuLNOv
 fgXJQ9OVn9wTVkWqQ=; b=WFXl28SugPYfMXIkNieonM91mkOV072/0FIFb71NWT
 cyuU4oHuX8ndX9P3LwxTNKWzCz2BKG4eIhBY5kGK3xHYy5ozO0+U7a0weDHWJUMS
 qbDPKX4PhN/Uh6tRJ+fbEjPLf3wty+L/nxGp6//iN9Gw0k8+WorCnO/JKE61Hh10
 c=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=maVX5d
 vOvDu1qu+kjIUaOuLNOvfgXJQ9OVn9wTVkWqQ=; b=aXLLWUOFLoGiKlRrln/Srz
 JCJLCLi55QWKTW3tZglBY71FrNoMUO+8UhFczGwOdnK6rxv6OLqS9JLTW4heiSzv
 JXOrogXY6Qb1RqFdYX1h3ixXz6jKbT9Mmjgf//ts1Aw5PSQfkPFBHRSmFLm/zaJ6
 xGAlP0h/wpB8sraW0dTr53210ntxacHmxApDc51dEupacu/Yflsf8dcwB4zte+VG
 FqfpKE0XviA2mmWsT4Nm468LqUeiaclmmb4Sgt+geEu8O+grxeloOsBJWe/jSBmc
 tKt1zOK539cw2z8dI1vez8Jf9JBYE5JuZzQRge9HSnIwtWmLXpOSTsiS74mxZcEQ
 ==
X-ME-Sender: <xms:4cW6WptBPY7pv8_TTvkqg9mixzqL7gN-dCeYhQN9fobMNMqx9KR1CA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 67CB8E4488;
 Tue, 27 Mar 2018 18:29:53 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Sergey Alekseev <sergey.alekseev@vdomresearch.com>
Cc: dev@dpdk.org, Konstantin Ananyev <konstantin.ananyev@intel.com>
Date: Wed, 28 Mar 2018 00:29:38 +0200
Message-ID: <1860185.tFcqzqpjh1@xps>
In-Reply-To: <1519178599-3661-1-git-send-email-sergey.alekseev@vdomresearch.com>
References: <1519178599-3661-1-git-send-email-sergey.alekseev@vdomresearch.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] ip_frag: fix hash key usage
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Mar 2018 22:29:54 -0000

Hi,

21/02/2018 03:03, Sergey Alekseev:
> ---
>  lib/librte_ip_frag/ip_frag_internal.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Please we need an explanation and Signed-off-by.
Could you send a v2?

Do not hesitate to Cc Konstantin (maintainer of this lib) for reviews.
Thanks

> --- a/lib/librte_ip_frag/ip_frag_internal.c
> +++ b/lib/librte_ip_frag/ip_frag_internal.c
> @@ -61,7 +61,7 @@ ipv4_frag_hash(const struct ip_frag_key *key, uint32_t *v1, uint32_t *v2)
>  	uint32_t v;
>  	const uint32_t *p;
>  
> -	p = (const uint32_t *)&key->src_dst;
> +	p = (const uint32_t *) key->src_dst;
>  
>  #ifdef RTE_ARCH_X86
>  	v = rte_hash_crc_4byte(p[0], PRIME_VALUE);
> @@ -82,7 +82,7 @@ ipv6_frag_hash(const struct ip_frag_key *key, uint32_t *v1, uint32_t *v2)
>  	uint32_t v;
>  	const uint32_t *p;
>  
> -	p = (const uint32_t *) &key->src_dst;
> +	p = (const uint32_t *) key->src_dst;
>  
>  #ifdef RTE_ARCH_X86
>  	v = rte_hash_crc_4byte(p[0], PRIME_VALUE);