* [PATCH] app/test: update skipped count when setup returns skipped
@ 2022-05-24 14:16 Anoob Joseph
2022-05-25 6:10 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Anoob Joseph @ 2022-05-24 14:16 UTC (permalink / raw)
To: Thomas Monjalon, David Marchand, Ferruh Yigit
Cc: Anoob Joseph, dev, Akhil Goyal, Ciara Power, Jerin Jacob
If the setup function returns TEST_SKIPPED, the logs would say the test
case is skipped while the summary count would consider it under failed
cases. Address this by counting such test cases under 'skipped'.
Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
app/test/test.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test/test.c b/app/test/test.c
index 5194131..f4d2854 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -358,6 +358,8 @@ unit_test_suite_runner(struct unit_test_suite *suite)
suite->failed++;
} else if (test_success == -ENOTSUP) {
suite->unsupported++;
+ } else if (test_success == TEST_SKIPPED) {
+ suite->skipped++;
} else {
suite->failed++;
}
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] app/test: update skipped count when setup returns skipped
2022-05-24 14:16 [PATCH] app/test: update skipped count when setup returns skipped Anoob Joseph
@ 2022-05-25 6:10 ` Akhil Goyal
2022-06-07 16:41 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Akhil Goyal @ 2022-05-25 6:10 UTC (permalink / raw)
To: Anoob Joseph, Thomas Monjalon, David Marchand, Ferruh Yigit
Cc: Anoob Joseph, dev, Ciara Power, Jerin Jacob Kollanukkaran
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
> Subject: [PATCH] app/test: update skipped count when setup returns skipped
>
> If the setup function returns TEST_SKIPPED, the logs would say the test
> case is skipped while the summary count would consider it under failed
> cases. Address this by counting such test cases under 'skipped'.
>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 14078 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] app/test: update skipped count when setup returns skipped
2022-05-25 6:10 ` Akhil Goyal
@ 2022-06-07 16:41 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2022-06-07 16:41 UTC (permalink / raw)
To: Anoob Joseph
Cc: David Marchand, Ferruh Yigit, dev, Ciara Power,
Jerin Jacob Kollanukkaran, Akhil Goyal
25/05/2022 08:10, Akhil Goyal:
> > Subject: [PATCH] app/test: update skipped count when setup returns skipped
> >
> > If the setup function returns TEST_SKIPPED, the logs would say the test
> > case is skipped while the summary count would consider it under failed
> > cases. Address this by counting such test cases under 'skipped'.
> >
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-07 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-24 14:16 [PATCH] app/test: update skipped count when setup returns skipped Anoob Joseph
2022-05-25 6:10 ` Akhil Goyal
2022-06-07 16:41 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).