From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 53703569C for ; Mon, 13 Jul 2015 18:28:57 +0200 (CEST) Received: by widjy10 with SMTP id jy10so74688833wid.1 for ; Mon, 13 Jul 2015 09:28:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=dCt+/OcHQLiRSqbm26LvVwIxD2ipaaZ2HK4FZpwOr34=; b=htjF6TcYLmht036f6wgMKkSAJFsqQOQXaLDXTiHj+oe21qpdUzli7ES2b/Q4n6lfwp k108C9F7NlZ2BJU1rbr6QX7eKyPwzyotxdKoL9tqgoAeZ+dCoiO7IYO1+9AdaF/QZ6qv CeT4PmkeVcw8B4wXKDJmnq4FJkb7pALEeUflHL9Vi6fsC34hUFUhhWDAxh91oOnQciNj sLQB/x6lam4gWD9Uo7m7T8FlD9qz/rukAPGarxMNJDarEz9Wvl5V7dhmeHlt+y5/xqYD Gs9GhW92vT0pSgHCjvJW1rTxgRg5sXtjIzN+q30t1awxqHZdh4/RMf57Y1v6F8YYv2iZ vBYQ== X-Gm-Message-State: ALoCoQkZXWAfwUlNOildHDPG5H2J85Bhw9B+BFADYiT5/LjCxYYcgeU2gKJKKccYOpsFvDKEPMlY X-Received: by 10.194.201.71 with SMTP id jy7mr70531963wjc.93.1436804937183; Mon, 13 Jul 2015 09:28:57 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id k5sm15551368wij.1.2015.07.13.09.28.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jul 2015 09:28:56 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Date: Mon, 13 Jul 2015 18:27:43 +0200 Message-ID: <1862129.zWrQIqxoo8@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1435912347-19499-1-git-send-email-helin.zhang@intel.com> <2161590.Y1eMLetJSj@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v10 19/19] mbuf: remove old packet type bit masks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2015 16:28:57 -0000 2015-07-13 16:25, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-07-10 00:31, Helin Zhang: > > > As unified packet types are used instead, those old bit masks and the > > > relevant macros for packet type indication need to be removed. > > > > It breaks mlx4 and cxgbe drivers. [...] > I think I have already reworked with that changes in v9 and v10 recently. > http://www.dpdk.org/dev/patchwork/patch/6253/ No, your changes were for t4_ethrx_handler(). Since recent cxgbe change, we also need to update process_responses(). > > The cxgbe changes need to be updated after > > 78fc1a716ae8 ("cxgbe: improve Rx performance") I suggest this update: > > > > --- a/drivers/net/cxgbe/sge.c > > +++ b/drivers/net/cxgbe/sge.c > > @@ -1419,7 +1419,11 @@ static int process_responses(struct sge_rspq *q, int > > budget, > > unmap_rx_buf(&rxq->fl); > > > > if (cpl->l2info & htonl(F_RXF_IP)) { > > +#ifdef RTE_NEXT_ABI > > + mbuf->packet_type = RTE_PTYPE_L3_IPV4; > > +#else > > pkt->ol_flags |= PKT_RX_IPV4_HDR; > > +#endif > > if (unlikely(!csum_ok)) > > pkt->ol_flags |= > > PKT_RX_IP_CKSUM_BAD; > > > > @@ -1427,7 +1431,11 @@ static int process_responses(struct sge_rspq *q, int > > budget, > > htonl(F_RXF_UDP | F_RXF_TCP)) > > && !csum_ok) > > pkt->ol_flags |= > > PKT_RX_L4_CKSUM_BAD; > > } else if (cpl->l2info & htonl(F_RXF_IP6)) { > > +#ifdef RTE_NEXT_ABI > > + mbuf->packet_type = RTE_PTYPE_L3_IPV6; > > +#else > > pkt->ol_flags |= PKT_RX_IPV6_HDR; > > +#endif > > } >