From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85866A0C45; Wed, 4 Aug 2021 11:34:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FD054014F; Wed, 4 Aug 2021 11:34:27 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id ADE684003E; Wed, 4 Aug 2021 11:34:25 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id DF20A580D04; Wed, 4 Aug 2021 05:34:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 04 Aug 2021 05:34:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= +xF8PZO0+9hw8zM6ZeEoobQ4TTCwB2F5KOQpzETzW1w=; b=xN6C5tUEruzZyv6b OVeBlYXXZRpbYAD3WmvKHpxCc9qHzxAoOYrmvbsVfPkHUw8Z2ebmiN7AoybCIfwd F9Ncg8pCRa2VQXMazidoDMnr6psZ8X9SNfP6srHHF+qJwS1kRTvhSbVcj8lESrYM se6dG86xeVIhlSGfkYNZSaukvau9t1UNXNkxGvd7NIHqWmqG/VndKSYJAYava7H4 2h6FKhSJnTG9+nBQykbAIS8GUoBpCrqFhPI0PsgYugZ2YHF3j4aglb89wJBBEwZ9 oYyn4M+VXAnxjHbSfeX2LTcmbP05p2PL8S34i6Y0Jfvb28YolxiIsfKjVD2gY8lP o0Q9nw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=+xF8PZO0+9hw8zM6ZeEoobQ4TTCwB2F5KOQpzETzW 1w=; b=Z1DA0dCC0HpRAdjXE6QLFMV5FX5TBRvo4s8JVIfdpAdM45V0p9anI1b6K mSAPkGhJmonxzTvcbw3plfMe9Pba6HYSRJTd8znycf4TEzSoGwjVwRtWzc0nTcmk I3j9DcEkQiuwsvQphQYOPwKXEbRoZTL0GqofgnTLVF3sSXxhhqokJC/uy2zZmgOb hHrgHw7BaCHA9VZrHzYS85957n3uhleGveIS25LWwQUSfPMLVec9B6PeMqNPkM+a H8WJn1ET4h/jIXgRw/HBHwxKic0UerTCwx1P9zFaMIJR2TVfi+cD6jcSpQzk9+4F k5qTRLYIX9lQllsGryIDovrLSCrog== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrieejucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrth htvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeuieeivdff geehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepth hhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 Aug 2021 05:34:22 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, stable@dpdk.org, Viacheslav Ovsiienko , Xueming Li , Andrew Rybchenko , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Parav Pandit , Stephen Hemminger , Long Li Date: Wed, 04 Aug 2021 11:34:21 +0200 Message-ID: <1862927.fmMXKf2Rp4@thomas> In-Reply-To: <20210804080301.1440491-1-dkozlyuk@nvidia.com> References: <20210728220618.1048721-1-dkozlyuk@nvidia.com> <20210804080301.1440491-1-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] bus: clarify log for non-NUMA-aware devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/08/2021 10:03, Dmitry Kozlyuk: > PCI, vmbus, and auxiliary drivers printed a warning > when NUMA node had been reported as (-1) or not reported by OS: > > EAL: Invalid NUMA socket, default to 0 > > This message and its level might confuse users because the configuration > is valid and nothing happens that requires attention or intervention. > It was also printed without the device identification and with an indent > (PCI only), which is confusing unless DEBUG logging is on to print > the header message with the device name. > > Reduce level to INFO, reword the message, and suppress it when there is > only one NUMA node because NUMA awareness does not matter in this case. > Also, remove the indent for PCI. > > Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe") > Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") > Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus") > Cc: stable@dpdk.org > > Signed-off-by: Dmitry Kozlyuk > Reviewed-by: Viacheslav Ovsiienko > Reviewed-by: Xueming Li > Acked-by: Andrew Rybchenko > --- > The messages say "socket" and not "node", because this is current > terminology in DPDK. Yes we need to fix this terminology in a separate patch. Applied, thanks.